PATCH
This patch adds common code usable for all Matrix Vision boards.
---
board/matrix_vision/common/Makefile | 54 ++++++++++++++ board/matrix_vision/common/mv_common.c | 125 ++++++++++++++++++++++++++++++++ board/matrix_vision/common/mv_common.h | 25 +++++++ 3 files changed, 204 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/board/matrix_vision/common/Makefile
new file mode 100644
index 0000000..b496258
board/matrix_vision/common/Makefile new file +54 -0
54 lines not on this page · raw message
(quoted diff) +0 -0
b/board/matrix_vision/common/mv_common.c
new file mode 100644
index 0000000..284de16
board/matrix_vision/common/mv_common.c new file +125 -0
125 lines not on this page · raw message
(quoted diff) +0 -0
b/board/matrix_vision/common/mv_common.h
new file mode 100644
index 0000000..046c038
board/matrix_vision/common/mv_common.h new file +25 -0
@@ -0,0 +1,25 @@ +/* +* Copyright 2008 Matrix Vision GmbH +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + + +extern int mv_load_fpga (void ); +extern void mv_reset_environment (void );
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschiaeftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz,
Quoted 10 lines · In message <1247834498.3953.34.camel@swa-m460> you wrote:
This patch adds common code usable for all Matrix Vision boards.
Signed-off-by Andr=C3=A9 Schwarz <[email protected]>---
board/matrix_vision/common/Makefile | 54 ++++++++++++++ board/matrix_vision/common/mv_common.c | 125 ++++++++++++++++++++++++++++++++ board/matrix_vision/common/mv_common.h | 25 +++++++ 3 files changed, 204 insertions(+), 0 deletions(-)
No. Please see my previous review comments.
The patches that add common code and that remove this common code from the multiple places where it was before should be merged into one atomic change.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Far back in the mists of ancient time, in the great and glorious days of the former Galactic Empire, life was wild, rich and largely tax free. - Douglas Adams, _The Hitchhiker's Guide to the Galaxy_