Fix compilation warning for arch/x86/kernel/apm_32.c
Subsystems (2)
PATCH 5/6 Fix compilation warning for arch/x86/kernel/apm_32.c
Following fix is inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,
---
arch/x86/kernel/apm_32.c +1 -1
@@ -811,7 +811,7 @@ static int apm_do_idle(void)u8 ret =0 ;int idled =0 ;int polling; -int err; +int uninitialized_var (err ); polling = !!(current_thread_info ()->status &TS_POLLING );if (polling) {
---
Regards--
Subrata
Quoted 9 lines · Subrata Modak
Following fix is inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,Signed-off-by Subrata Modak<[email protected]>,---
arch/x86/kernel/apm_32.c static int apm_do_idle(void) · line 814
Quoted 5 lines
arch/x86/kernel/apm_32.c +1
-1@@ -811,7 +811,7 @@ static int apm_do_idle(void)u8 ret =0 ;int idled =0 ;int polling; -int err; +int uninitialized_var (err );
Please dont use uninitialized_var() as it's dangerous - in something as performance-uncritical as this we should initialize it to 0 and mention it in the changelog that this works around a GCC false positive warning.
Thanks,
Ingo
Quoted 8 lines · Ingo Molnar
Quoted 6 lines · Subrata Modak
Following fix is inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,Signed-off-by Subrata Modak<[email protected]>,---
Quoted 13 lines
arch/x86/kernel/apm_32.c static int apm_do_idle(void) · line 814
Quoted 8 lines
arch/x86/kernel/apm_32.c +1
-1@@ -811,7 +811,7 @@ static int apm_do_idle(void)u8 ret =0 ;int idled =0 ;int polling; -int err; +int uninitialized_var (err );Please dont use
uninitialized_var()as it's dangerous - in something as performance-uncritical as this we should initialize it to 0 and mention it in the changelog that this works around a GCC false positive warning.
Sure. Resending as you suggested.
Regards--
Subrata
Quoted 4 lines
Thanks,
Ingo