Skip to contentSkip to conversation

use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

PATCH In review Eric Sandeen 2 participants 3 messages Jul 20, 2009 – Aug 1, 2009 XFS filesystem

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 use XFS_CORRUPTION_ERROR in xfs_btree_check_sblock

In Red Hat Bug 512552
- Can't write to XFS mount during raid5 resync

a user ran into corruption while resyncing a raid, and we failed a consistency test, but didn't get much more info; it'd be nice to call XFS_CORRUPTION_ERROR here so we can see the buffer contents.

Compile-tested only...

Signed-off-by Eric Sandeen <[email protected]>

---

fs/xfs/xfs_btree.c +2 -2
index e9df995..2671738 100644
@@ -120,8 +120,8 @@ xfs_btree_check_sblock(
 			XFS_RANDOM_BTREE_CHECK_SBLOCK))) {
 		if (bp)
 			xfs_buftrace("SBTREE ERROR", bp);
-		XFS_ERROR_REPORT("xfs_btree_check_sblock", XFS_ERRLEVEL_LOW,
-				 cur->bc_mp);
+		XFS_CORRUPTION_ERROR("xfs_btree_check_sblock",
+			XFS_ERRLEVEL_LOW, cur->bc_mp, block);
 		return XFS_ERROR(EFSCORRUPTED);
 	}
 	return 0;

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 9 lines · Eric Sandeen

In Red Hat Bug 512552
- Can't write to XFS mount during raid5 resync

a user ran into corruption while resyncing a raid, and we failed a consistency test, but didn't get much more info; it'd be nice to call XFS_CORRUPTION_ERROR here so we can see the buffer contents.

Compile-tested only...

Looks good to me, I'll throw it into my XFSQA queue..

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by
#2 lore raw
Quoted 4 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen

In Red Hat Bug 512552
- Can't write to XFS mount during raid5 resync

Quoted 8 lines
Quoted 6 lines

a user ran into corruption while resyncing a raid, and we failed a consistency test, but didn't get much more info; it'd be nice to call XFS_CORRUPTION_ERROR here so we can see the buffer contents.

Compile-tested only...

Looks good to me, I'll throw it into my XFSQA queue..

I has survied quite a few xfsqa runs for me, so

Reviewed-by Christoph Hellwig <[email protected]>

sounds like another 2.6.31 candidate to me..

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs