Fix compilation warning for fs/ocfs2/xattr.c
PATCH 1/1 Fix compilation warning for fs/ocfs2/xattr.c
Hi,
gcc 4.4.1 generates the following build warning on i386:
CC [M] fs/ocfs2/xattr.ofs/ocfs2/xattr.c: In function ???ocfs2_xattr_block_get???:fs/ocfs2/xattr.c:1055: warning: ???block_off??? may be used uninitialized in this function
The following fix is based on a similar approach by David Howells few days back: http://lkml.org/lkml/2009/7/9/109,
---
fs/ocfs2/xattr.c +2 -1
@@ -1052,7 +1052,8 @@ static int ocfs2_xattr_block_get(structstruct ocfs2_xattr_block *xb;struct ocfs2_xattr_value_root *xv;size_t size; -int ret = -ENODATA , name_offset, name_len, block_off, i; +int ret = -ENODATA , name_offset, name_len, i; +int uninitialized_var (block_off ); xs->bucket =ocfs2_xattr_bucket_new (inode);if (!xs->bucket) {
---
Regards--
Subrata
Quoted 10 lines · Subrata Modak
gcc 4.4.1 generates the following build warning on i386:
CC [M]
fs/ocfs2/xattr.ofs/ocfs2/xattr.c: In function ?ocfs2_xattr_block_get?:fs/ocfs2/xattr.c:1055: warning: ?block_off? may be used uninitialized in this functionThe following fix is based on a similar approach by David Howells few days back: http://lkml.org/lkml/2009/7/9/109,
Signed-off-by Subrata Modak<[email protected]>,
This is now in the fixes branch of ocfs2.git.
Joel
Signature · 9 lines
Life's Little Instruction Book #15 "Own a great stereo system." Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127