ioctl number overlapped?
Happen to see this:
include/linux.kvm.h
503 #define KVM_IRQ_LINE_STATUS _IOWR(KVMIO, 0x67, struct kvm_irq_level)
504 #define KVM_REGISTER_COALESCED_MMIO \
505 _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
Both ioctl use 0x67, and the code has released to v2.6.30...
Signature · 2 lines
regards Yang, Sheng
Quoted 10 lines · Sheng
Happen to see this:
include/linux.kvm.h503 #define
KVM_IRQ_LINE_STATUS_IOWR(KVMIO, 0x67, struct kvm_irq_level)
504 #defineKVM_REGISTER_COALESCED_MMIO\
505_IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)Both ioctl use
0x67, and the code has released to v2.6.30...
I don't think they are really overlapping. One of them is RW another W (haven't checked if the structure sizeof is different).
--
Gleb.
Quoted 10 lines · Gleb Natapov
Quoted 8 lines · Sheng
Happen to see this:
include/linux.kvm.h503 #define
KVM_IRQ_LINE_STATUS_IOWR(KVMIO, 0x67, struct kvm_irq_level)
504 #defineKVM_REGISTER_COALESCED_MMIO\
505_IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
Quoted 7 lines
Quoted 3 lines
Both ioctl use
0x67, and the code has released to v2.6.30...I don't think they are really overlapping. One of them is RW another W (haven't checked if the structure sizeof is different).
Nevertheless we shouldn't do this.
Signature · 1 line
error compiling committee.c: too many arguments to function