Skip to contentSkip to conversation

ir-kbd-i2c: Drop irrelevant inline keywords

PATCH Jean Delvare 2 participants 3 messages Jul 19, 2009 – Jul 21, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Functions which are referenced by their address can't be inlined by definition.

---
 linux/drivers/media/video/ir-kbd-i2c.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
linux/drivers/media/video/ir-kbd-i2c.c +2 -2
@@ -127,12 +127,12 @@ static int get_key_haup_common(struct IR
 	return 1;
 }
 
-static inline int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
+static int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
 {
 	return get_key_haup_common (ir, ir_key, ir_raw, 3, 0);
 }
 
-static inline int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
+static int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
 {
 	return get_key_haup_common (ir, ir_key, ir_raw, 6, 3);
 }
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 4 lines · Jean Delvare

Functions which are referenced by their address can't be inlined by definition.

Jean,

Looks godd to me, but you forgot to add [PATCH] to the subject. I'll add this one to my revised patch set I submit to the list, unless you object.

Regards,
Andy

Quoted 23 lines
---
 linux/drivers/media/video/ir-kbd-i2c.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
linux/drivers/media/video/ir-kbd-i2c.c +2 -2
@@ -127,12 +127,12 @@ static int get_key_haup_common(struct IR
 	return 1;
 }
 
-static inline int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
+static int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
 {
 	return get_key_haup_common (ir, ir_key, ir_raw, 3, 0);
 }
 
-static inline int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
+static int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
 {
 	return get_key_haup_common (ir, ir_key, ir_raw, 6, 3);
 }
#2 lore raw
Quoted 11 lines · Andy Walls
Quoted 4 lines · Jean Delvare

Functions which are referenced by their address can't be inlined by definition.

Jean,

Looks godd to me, but you forgot to add [PATCH] to the subject. I'll add this one to my revised patch set I submit to the list, unless you object.

Oops, you're right. Yes, please pick it up and push it forward, thanks!

Signature · 1 line
Jean Delvare