Skip to contentSkip to conversation

janitor: useless checks before free

PATCH New Pierre Habouzit 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Pierre Habouzit

author
#0 lore raw

PATCH 1/1 janitor: useless checks before free

Signed-off-by Pierre Habouzit <[email protected]>

---

On the same vein, a few simplifications wrt if (x) free(x)

 pack-revindex.c |    3 +--
 walker.c        |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
pack-revindex.c +1 -2
index 1de53c8..77a0465 100644
@@ -149,8 +149,7 @@ void discard_revindex(void)
 	if (pack_revindex_hashsz) {
 		int i;
 		for (i = 0; i < pack_revindex_hashsz; i++)
-			if (pack_revindex[i].revindex)
-				free(pack_revindex[i].revindex);
+			free(pack_revindex[i].revindex);
 		free(pack_revindex);
 		pack_revindex_hashsz = 0;
 	}
walker.c +1 -1
index e57630e..11d9052 100644
@@ -245,7 +245,7 @@ void walker_targets_free(int targets, char **target, const char **write_ref)
 {
 	while (targets--) {
 		free(target[targets]);
-		if (write_ref && write_ref[targets])
+		if (write_ref)
 			free((char *) write_ref[targets]);
 	}
 }
Signature · 1 line
1.6.4.rc1.193.g47c25d