power: trivial comment fixes
Subsystems (2)
PATCH 1/1 power: trivial comment fixes
--- kernel/power/snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/power/snapshot.c +2 -2
@@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al#define BM_END_OF_MAP (~0UL) -#define BM_BITS_PER_BLOCK (PAGE_SIZE << 3) +#define BM_BITS_PER_BLOCK (PAGE_SIZE * BITS_PER_BYTE)struct bm_block {struct list_head hook;/* hook into a list of bitmap blocks */
@@ -275,7 +275,7 @@ static void memory_bm_free(struct memory/** * create_bm_block_list - create a list of block bitmap objects -* @nr_blocks - number of blocks to allocate +* @pages - number of pages to track * @list - list to put the allocated blocks into * @ca - chain allocator to be used for allocating memory */
Quoted 2 lines · Wu Fengguang
CC Rafael J. Wysocki <[email protected]>Signed-off-by Wu Fengguang <[email protected]>
Thanks for the patch, I'll add it to the suspend tree when I'm back home (probably on Monday).
Best,
Rafael
Quoted 24 lines
--- kernel/power/snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/power/snapshot.c +2
-2@@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al#define BM_END_OF_MAP (~0UL) -#define BM_BITS_PER_BLOCK (PAGE_SIZE << 3) +#define BM_BITS_PER_BLOCK (PAGE_SIZE * BITS_PER_BYTE)struct bm_block {struct list_head hook;/* hook into a list of bitmap blocks */ @@ -275,7 +275,7 @@ static void memory_bm_free(struct memory/** * create_bm_block_list - create a list of block bitmap objects -* @nr_blocks - number of blocks to allocate +* @pages - number of pages to track * @list - list to put the allocated blocks into * @ca - chain allocator to be used for allocating memory */
Quoted 28 lines · On Fri, 17 Jul 2009 03:19:02 +0200 Rafael J. Wysocki wrote:
Quoted 2 lines · Wu Fengguang
CC Rafael J. Wysocki <[email protected]>Signed-off-by Wu Fengguang <[email protected]>Thanks for the patch, I'll add it to the suspend tree when I'm back home (probably on Monday).
Best,
RafaelQuoted 17 lines
--- kernel/power/snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/power/snapshot.c +1
-1@@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al#define BM_END_OF_MAP (~0UL) -#define BM_BITS_PER_BLOCK (PAGE_SIZE << 3) +#define BM_BITS_PER_BLOCK (PAGE_SIZE * BITS_PER_BYTE)struct bm_block {struct list_head hook;/* hook into a list of bitmap blocks */ @@ -275,7 +275,7 @@ static void memory_bm_free(struct memory
Quoted 7 lines
kernel/power/snapshot.c static void memory_bm_free(struct memory · line 281
Quoted 7 lines
kernel/power/snapshot.c +1
-1/** * create_bm_block_list - create a list of block bitmap objects -* @nr_blocks - number of blocks to allocate +* @pages - number of pages to track * @list - list to put the allocated blocks into * @ca - chain allocator to be used for allocating memory */
BTW:
kernel-doc uses @parameter:
and not @parameter -
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
Quoted 30 lines · Randy Dunlap
Quoted 28 lines · On Fri, 17 Jul 2009 03:19:02 +0200 Rafael J. Wysocki wrote:
Quoted 2 lines · Wu Fengguang
CC Rafael J. Wysocki <[email protected]>Signed-off-by Wu Fengguang <[email protected]>Thanks for the patch, I'll add it to the suspend tree when I'm back home (probably on Monday).
Best,
RafaelQuoted 17 lines
--- kernel/power/snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/power/snapshot.c +1
-1@@ -233,7 +233,7 @@ static void *chain_alloc(struct chain_al#define BM_END_OF_MAP (~0UL) -#define BM_BITS_PER_BLOCK (PAGE_SIZE << 3) +#define BM_BITS_PER_BLOCK (PAGE_SIZE * BITS_PER_BYTE)struct bm_block {struct list_head hook;/* hook into a list of bitmap blocks */ @@ -275,7 +275,7 @@ static void memory_bm_free(struct memory
Quoted 11 lines
Quoted 7 lines
kernel/power/snapshot.c static void memory_bm_free(struct memory · line 281
Quoted 7 lines
kernel/power/snapshot.c +1
-1/** * create_bm_block_list - create a list of block bitmap objects -* @nr_blocks - number of blocks to allocate +* @pages - number of pages to track * @list - list to put the allocated blocks into * @ca - chain allocator to be used for allocating memory */ BTW:
kernel-doc uses @parameter:
and not @parameter -
Yes, kerneldocs in this file generally require fixes. They're somewhere in my todo list.
Best,
Rafael