Skip to contentSkip to conversation

Use do_div from div64.h for vsprintf

PATCH New Dirk Behme 3 participants 3 messages Jul 22, 2009 – Jul 26, 2009

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH v2 1/1 Use do_div from div64.h for vsprintf

Use do_div from div64.h for vsprintf in case of 64bit division. For 32bit division, do_div from div64.h can't be used as it needs a 64bit parameter.

CC Simon Kagstrom <[email protected]>

---

This patch replaces first version

http://lists.denx.de/pipermail/u-boot/2009-July/055599.html

due to compiler warnings

http://lists.denx.de/pipermail/u-boot/2009-July/056994.html

 lib_generic/vsprintf.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
lib_generic/vsprintf.c +4 -3
Index: u-boot-main/lib_generic/vsprintf.c
===================================================================
@@ -22,18 +22,19 @@ extern int do_reset (cmd_tbl_t *cmdtp, i
 #endif
 
 #ifdef CONFIG_SYS_64BIT_VSPRINTF
+#include <div64.h>
 # define NUM_TYPE long long
 #else
 # define NUM_TYPE long
-#endif
-#define noinline __attribute__((noinline))
-
 #define do_div(n, base) ({ \
 	unsigned int __res; \
 	__res = ((unsigned NUM_TYPE) n) % base; \
 	n = ((unsigned NUM_TYPE) n) / base; \
 	__res; \
 })
+#endif
+#define noinline __attribute__((noinline))
+
 
 const char hex_asc[] = "0123456789abcdef";
 #define hex_asc_lo(x)   hex_asc[((x) & 0x0f)]
#1 lore raw

PATCH v2 1/1 Use do_div from div64.h for vsprintf

Quoted 6 lines · On Wednesday 22 July 2009 17:51:56 Dirk Behme wrote:

Use do_div from div64.h for vsprintf in case of 64bit division. For 32bit division, do_div from div64.h can't be used as it needs a 64bit parameter.

CC Simon Kagstrom <[email protected]>

I just did some testing on the image size effect of this patch. All this is done on Canyonlands (PPC4xx):

a) Without 64bit printf support, without this patch
b) With 64bit printf support, without this patch
c) With 64bit printf support, with this patch

Image-type Image-size
---------------------------

a               351028
b               352536
c               351400

So without this patch the 64bit printf support increases the image size by 5390 bytes and with this patch by "only" 984 bytes.

So ack from me for this patch:

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH v2 1/1 Use do_div from div64.h for vsprintf

In reply to Dirk Behme

Dear Dirk Behme,

Quoted 10 lines · In message <[email protected]> you…

Use do_div from div64.h for vsprintf in case of 64bit division. For 32bit division, do_div from div64.h can't be used as it needs a 64bit parameter.

CC Simon Kagstrom <[email protected]>

---

This patch replaces first version

Quoted 8 lines

http://lists.denx.de/pipermail/u-boot/2009-July/055599.html

due to compiler warnings

http://lists.denx.de/pipermail/u-boot/2009-July/056994.html

 lib_generic/vsprintf.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You could end up being oddly sad and full of a strange, diffuse  com-
passion  which would lead you to believe that it might be a good idea
to wipe out the whole human race and start again with amoebas.
                                 - Terry Pratchett, _Guards! Guards!_