Skip to contentSkip to conversation

ppc4xx: Fix problem with NOR range assignment in Canyonlands ft_board_setup

PATCH New Stefan Roese 1 participant 2 messages Jul 27, 2009 – Jul 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Fix problem with NOR range assignment in Canyonlands ft_board_setup

This patch fixes the problem, that the current fdt board fixup code only set's one range, the one for NOR. By this it's overwriting the already correctly configured values done in __ft_board_setup(). Just remove this now unneeded NOR fixup and all the ranges are correctly defined.

Cc Dirk Eibach <[email protected]>
Cc Felix Radensky <[email protected]>
---
 board/amcc/canyonlands/canyonlands.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)
board/amcc/canyonlands/canyonlands.c +0 -15
index cfc1023..12385bf 100644
@@ -579,23 +579,8 @@ extern void __ft_board_setup(void *blob, bd_t *bd);
 
 void ft_board_setup(void *blob, bd_t *bd)
 {
-	u32 val[4];
-	int rc;
-
 	__ft_board_setup(blob, bd);
 
-	/* Fixup NOR mapping */
-	val[0] = CONFIG_SYS_NOR_CS;		/* chip select number */
-	val[1] = 0;				/* always 0 */
-	val[2] = CONFIG_SYS_FLASH_BASE_PHYS_L;		/* we fixed up this address */
-	val[3] = gd->bd->bi_flashsize;
-	rc = fdt_find_and_setprop(blob, "/plb/opb/ebc", "ranges",
-				  val, sizeof(val), 1);
-	if (rc) {
-		printf("Unable to update property NOR mapping, err=%s\n",
-		       fdt_strerror(rc));
-	}
-
 	if (gd->board_type == BOARD_CANYONLANDS_SATA) {
 		/*
 		 * When SATA is selected we need to disable the first PCIe
Signature · 1 line
1.6.3.3
author Applied
#1 lore raw

PATCH 1/1 ppc4xx: Fix problem with NOR range assignment in Canyonlands ft_board_setup

Quoted 8 lines · On Monday 27 July 2009 09:13:38 Stefan Roese wrote:

This patch fixes the problem, that the current fdt board fixup code only set's one range, the one for NOR. By this it's overwriting the already correctly configured values done in __ft_board_setup(). Just remove this now unneeded NOR fixup and all the ranges are correctly defined.

Cc Dirk Eibach <[email protected]>
Cc Felix Radensky <[email protected]>

Applied to ppc4xx/master. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================