Fix FEC compile warning message
PATCH 1/1 Fix FEC compile warning message
Provide function protocol for icache_invalid().
--- drivers/net/mcffec.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/net/mcffec.c +4 -0
@@ -95,6 +95,10 @@ struct fec_info_s fec_info[] = {#endif }; +#ifdef CONFIG_SYS_UNIFY_CACHE +extern void icache_invalid (void ); +#endif +int fec_send (struct eth_device *dev,volatile void *packet,int length);int fec_recv (struct eth_device *dev);int fec_init (struct eth_device *dev,bd_t * bd);
Signature · 1 line
1.5.6.4
PATCH 1/1 Fix FEC compile warning message
Dear TsiChung Liew,
Quoted 12 lines · In message <[email protected]> you wrote:
Provide function protocol for
icache_invalid().Signed-off-by TsiChung Liew <[email protected]>--- drivers/net/mcffec.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)drivers/net/mcffec.c +0
-0
drivers/net/mcffec.c struct fec_info_s fec_info[] = { · line 100
Quoted 6 lines
drivers/net/mcffec.c +3
-0@@ -95,6 +95,10 @@ struct fec_info_s fec_info[] = {#endif }; +#ifdef CONFIG_SYS_UNIFY_CACHE +extern void icache_invalid (void ); +#endif
Could you please rename this function into invalidate_icache(), and add a prototype declaration to include/asm-?/cache.h, like it is for example doene for PowerPC in include/asm-ppc/cache.h ?
I would like to see that all architectures use the same names for the same functions...
Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If it has syntax, it isn't user friendly.
PATCH 1/1 Fix FEC compile warning message
Wolfgang,
Yes, I will do that for the next merging window. Ignore this patch.
Thanks!
Best Regards,
TsiChung
-----Original Message-----
From: [email protected] [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Wolfgang Denk
Sent: Tuesday, July 28, 2009 4:59 PM
To: TsiChung Liew
Cc: U-Boot; Ben Warre7n
Subject: Re: [U-Boot] [PATCH] Fix FEC compile warning message
Dear TsiChung Liew,
In message <[email protected]> you
Quoted 12 lines · wrote:
Provide function protocol for
icache_invalid().Signed-off-by TsiChung Liew <[email protected]>--- drivers/net/mcffec.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)drivers/net/mcffec.c index renamed from drivers/net/mcffec.c +0
-064be5de..d3741a7 100644
drivers/net/mcffec.c struct fec_info_s fec_info[] = { #endif }; · line 98
Quoted 4 lines
drivers/net/mcffec.c +3
-0@@ -95,6 +95,10 @@ struct fec_info_s fec_info[] = { #endif }; +#ifdef CONFIG_SYS_UNIFY_CACHE +extern void icache_invalid (void ); +#endif
Could you please rename this function into invalidate_icache(), and add a prototype declaration to include/asm-?/cache.h, like it is for example doene for PowerPC in include/asm-ppc/cache.h ?
I would like to see that all architectures use the same names for the same functions...
Thanks.
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If it has syntax, it isn't user friendly. _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot