gpio: add Intel Moorestown Platform Langwell chip gpio driver
PATCH v3 1/1 gpio: add Intel Moorestown Platform Langwell chip gpio driver
Changes from v2:
1. Add missed MODULE_DEVICE_TABLE
Changes from v1:
1. driver name changed from lnw.c ==> langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style clean
Quoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driver
The Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
--- drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile | 1 + drivers/gpio/langwell_gpio.c | 318 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 325 insertions(+), 0 deletions(-) create mode 100644 drivers/gpio/langwell_gpio.c
drivers/gpio/Kconfig +6 -0
@@ -167,6 +167,12 @@ config GPIO_BT8XX If unsure, say N. +config GPIO_LANGWELL + tristate "Intel Moorestown Platform Langwell GPIO support" + depends on PCI + help + Say Y here to support Intel Moorestown platform GPIO. + comment "SPI GPIO expanders:" config GPIO_MAX7301
drivers/gpio/Makefile +1 -0
@@ -13,3 +13,4 @@ obj-$(CONFIG_GPIO_PL061) += pl061.o obj-$(CONFIG_GPIO_TWL4030) += twl4030-gpio.o obj-$(CONFIG_GPIO_XILINX) += xilinx_gpio.o obj-$(CONFIG_GPIO_BT8XX) += bt8xxgpio.o +obj-$(CONFIG_GPIO_LANGWELL) += langwell_gpio.o
drivers/gpio/langwell_gpio.c new file +318 -0
318 lines not on this page · raw message
Signature · 1 line
1.6.0.4
Quoted 11 lines · On Fri, 3 Jul 2009 21:07:06 +0800 Alek Du <[email protected]> wrote:
Changes from v2:
1. Add missedMODULE_DEVICE_TABLEChanges from v1:
1. driver name changed fromlnw.c==>langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style cleanQuoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001
Quoted 8 lines
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driverThe Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
The driver breaks the x86-64 allmodconfig build:
ERROR: "irq_to_desc" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "set_irq_chip_and_handler_name" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "handle_simple_irq" [drivers/gpio/langwell_gpio.ko] undefined!
Does it make any sense to build this driver as a module? If not, it should be changed to def_bool. If so...
kernel/irq/chip.c | 2 ++ kernel/irq/handle.c | 1 + 2 files changed, 3 insertions(+)
kernel/irq/handle.c renamed from kernel/irq/handle.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +1 -0
@@ -192,6 +192,7 @@ struct irq_desc *irq_to_desc(unsigned inreturn NULL ; } +EXPORT_SYMBOL (irq_to_desc);struct irq_desc *__ref irq_to_desc_alloc_node (unsigned int irq,int node) {
kernel/irq/chip.c renamed from kernel/irq/chip.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +2 -0
@@ -340,6 +340,7 @@ handle_simple_irq(unsigned int irq, stru out_unlock:spin_unlock (&desc->lock); } +EXPORT_SYMBOL (handle_simple_irq);/** * handle_level_irq - Level type irq handler
@@ -609,6 +610,7 @@ set_irq_chip_and_handler_name(unsigned iset_irq_chip (irq, chip);__set_irq_handler (irq, handle,0 , name); } +EXPORT_SYMBOL (set_irq_chip_and_handler_name);void __init set_irq_noprobe (unsigned int irq) {
_
Andrew,
Sorry for late response. Yes, you are right, there is no meaning to build it as module, it should be changed to bool. I will submit a new patch soon, I also need a mask handler to irqchip .... otherwise the free_irq will report a error.
Thanks,
Alek
Quoted 70 lines · On Thu, 30 Jul 2009 18:59:41 +0800 Andrew Morton <[email protected]>…
Quoted 11 lines · On Fri, 3 Jul 2009 21:07:06 +0800 Alek Du <[email protected]> wrote:
Changes from v2:
1. Add missedMODULE_DEVICE_TABLEChanges from v1:
1. driver name changed fromlnw.c==>langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style cleanQuoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001Quoted 8 lines
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driverThe Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
The driver breaks the x86-64 allmodconfig build:
ERROR: "
irq_to_desc" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "set_irq_chip_and_handler_name" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "handle_simple_irq" [drivers/gpio/langwell_gpio.ko] undefined!Does it make any sense to build this driver as a module? If not, it should be changed to
def_bool. If so...kernel/irq/chip.c | 2 ++ kernel/irq/handle.c | 1 + 2 files changed, 3 insertions(+)diff -puN
kernel/irq/handle.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatchkernel/irq/handle.ckernel/irq/handle.c renamed from kernel/irq/handle.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +1
-0@@ -192,6 +192,7 @@ struct irq_desc *irq_to_desc(unsigned inreturn NULL ; } +EXPORT_SYMBOL (irq_to_desc);struct irq_desc *__ref irq_to_desc_alloc_node (unsigned int irq,int node) {diff -puN
kernel/irq/chip.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatchkernel/irq/chip.ckernel/irq/chip.c renamed from kernel/irq/chip.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +2
-0@@ -340,6 +340,7 @@ handle_simple_irq(unsigned int irq, stru out_unlock:spin_unlock (&desc->lock); } +EXPORT_SYMBOL (handle_simple_irq);/** * handle_level_irq - Level type irq handler @@ -609,6 +610,7 @@ set_irq_chip_and_handler_name(unsigned iset_irq_chip (irq, chip);__set_irq_handler (irq, handle,0 , name); } +EXPORT_SYMBOL (set_irq_chip_and_handler_name);void __init set_irq_noprobe (unsigned int irq) {_
PATCH 1/1 mm gpio: Some fixing for Langwell GPIO driver
Andrew,
Here is an incremental patch against gpio-add-intel-moorestown-platform-langwell-chip-gpio-driver.patch in mm tree. And I think you can revert 2f69806ebbdd67a816ff971ede66ac6597ffb991 export symbols patch now.
BR,
Alek
Quoted 1 line
From
626bf5fede836670db918d47d38b6956e6f7f759Mon Sep 17 00:00:00 2001
From: Alek Du <[email protected]>
Date: Fri, 31 Jul 2009 21:07:44 +0800
Subject: [PATCH] gpio: Some fixing for Langwell GPIO driver
1. remove module support.
2. add a mask handler to irqchip.
--- drivers/gpio/Kconfig | 2 +- drivers/gpio/langwell_gpio.c | 34 ++++++---------------------------- 2 files changed, 7 insertions(+), 29 deletions(-)
drivers/gpio/Kconfig +1 -1
@@ -174,7 +174,7 @@ config GPIO_BT8XX If unsure, say N. config GPIO_LANGWELL - tristate "Intel Moorestown Platform Langwell GPIO support" + bool "Intel Moorestown Platform Langwell GPIO support" depends on PCI help Say Y here to support Intel Moorestown platform GPIO.
drivers/gpio/langwell_gpio.c +6 -28
@@ -152,8 +152,13 @@ static void lnw_irq_unmask(unsigned irq)writel (BIT (gpio %32 ), gedr); }; +static void lnw_irq_mask (unsigned irq) +{ +}; +static struct irq_chip lnw_irqchip = { .name ="LNW-GPIO" , + .mask = lnw_irq_mask, .unmask = lnw_irq_unmask, .set_type = lnw_irq_type, };
@@ -277,27 +282,10 @@ done:return retval; } -static void __devexit lnw_gpio_remove(struct pci_dev *pdev) -{ -struct lnw_gpio *lnw = (struct lnw_gpio *)pci_get_drvdata (pdev); - -if (gpiochip_remove (&lnw->chip)) { -dev_err (&pdev->dev,"langwell gpio driver remove error\n" ); -return ; - } -pci_disable_device (pdev); -set_irq_chained_handler (pdev->irq,NULL ); -pci_release_regions (pdev); -iounmap (lnw->reg_base); -pci_set_drvdata (pdev,NULL ); -kfree (lnw); -} -static struct pci_driver lnw_gpio_driver = { .name ="langwell_gpio" , .id_table = lnw_gpio_ids, .probe = lnw_gpio_probe, - .remove = lnw_gpio_remove, };static int __init lnw_gpio_init (void )
@@ -305,14 +293,4 @@ static int __init lnw_gpio_init(void)return pci_register_driver (&lnw_gpio_driver); } -static void __exit lnw_gpio_exit(void) -{ -pci_unregister_driver (&lnw_gpio_driver); -} - -MODULE_AUTHOR ("Alek Du <[email protected]>" ); -MODULE_DESCRIPTION ("Intel Moorestown Platform Langwell chip GPIO driver" ); -MODULE_LICENSE ("GPL v2" ); - -module_init (lnw_gpio_init); -module_exit (lnw_gpio_exit); +device_initcall (lnw_gpio_init);
Signature · 4 lines
1.6.0.4 On Fri, 31 Jul 2009 17:02:10 +0800
Quoted 84 lines · Alek Du
Andrew,
Sorry for late response. Yes, you are right, there is no meaning to build it as module, it should be changed to bool. I will submit a new patch soon, I also need a mask handler to irqchip .... otherwise the
free_irqwill report a error.Thanks,
AlekQuoted 70 lines · On Thu, 30 Jul 2009 18:59:41 +0800 Andrew Morton <[email protected]>…
Quoted 11 lines · On Fri, 3 Jul 2009 21:07:06 +0800 Alek Du <[email protected]> wrote:
Changes from v2:
1. Add missedMODULE_DEVICE_TABLEChanges from v1:
1. driver name changed fromlnw.c==>langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style cleanQuoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001Quoted 8 lines
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driverThe Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
The driver breaks the x86-64 allmodconfig build:
ERROR: "
irq_to_desc" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "set_irq_chip_and_handler_name" [drivers/gpio/langwell_gpio.ko] undefined!
ERROR: "handle_simple_irq" [drivers/gpio/langwell_gpio.ko] undefined!Does it make any sense to build this driver as a module? If not, it should be changed to
def_bool. If so...kernel/irq/chip.c | 2 ++ kernel/irq/handle.c | 1 + 2 files changed, 3 insertions(+)diff -puN
kernel/irq/handle.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatchkernel/irq/handle.ckernel/irq/handle.c renamed from kernel/irq/handle.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +1
-0@@ -192,6 +192,7 @@ struct irq_desc *irq_to_desc(unsigned inreturn NULL ; } +EXPORT_SYMBOL (irq_to_desc);struct irq_desc *__ref irq_to_desc_alloc_node (unsigned int irq,int node) {diff -puN
kernel/irq/chip.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatchkernel/irq/chip.ckernel/irq/chip.c renamed from kernel/irq/chip.c~kernel-irq-export-symbols-needed-by-gpio-add-intel-moorestown-platform-langwell-chip-gpio-driverpatch +2
-0@@ -340,6 +340,7 @@ handle_simple_irq(unsigned int irq, stru out_unlock:spin_unlock (&desc->lock); } +EXPORT_SYMBOL (handle_simple_irq);/** * handle_level_irq - Level type irq handler @@ -609,6 +610,7 @@ set_irq_chip_and_handler_name(unsigned iset_irq_chip (irq, chip);__set_irq_handler (irq, handle,0 , name); } +EXPORT_SYMBOL (set_irq_chip_and_handler_name);void __init set_irq_noprobe (unsigned int irq) {_
Quoted 11 lines · On Fri, 3 Jul 2009 21:07:06 +0800 Alek Du <[email protected]> wrote:
Changes from v2:
1. Add missedMODULE_DEVICE_TABLEChanges from v1:
1. driver name changed fromlnw.c==>langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style cleanQuoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001
Quoted 8 lines
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driverThe Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
sparc64 allmodconfig:
drivers/gpio/langwell_gpio.c: In function `lnw_irq_type':drivers/gpio/langwell_gpio.c:117: error: implicit declaration of function get_irq_chip_data' drivers/gpio/langwell_gpio.c:117: warning: initialization makes pointer from integer without a cast drivers/gpio/langwell_gpio.c:128: error: IRQ_TYPE_EDGE_RISING' undeclared (first use in this function) drivers/gpio/langwell_gpio.c:128: error: (Each undeclared identifier is reported only once drivers/gpio/langwell_gpio.c:128: error: for each function it appears in.) drivers/gpio/langwell_gpio.c:134: error: IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function) drivers/gpio/langwell_gpio.c: In function lnw_irq_unmask':drivers/gpio/langwell_gpio.c:146: warning: initialization makes pointer from integer without a cast drivers/gpio/langwell_gpio.c: At top level:drivers/gpio/langwell_gpio.c:159: error: variable lnw_irqchip' has initializer but incomplete type drivers/gpio/langwell_gpio.c:160: error: unknown field name' specified in initializer drivers/gpio/langwell_gpio.c:160: warning: excess elements in struct initializer drivers/gpio/langwell_gpio.c:160: warning: (near initialization for lnw_irqchip') drivers/gpio/langwell_gpio.c:161: error: unknown field mask' specified in initializer drivers/gpio/langwell_gpio.c:161: warning: excess elements in struct initializer drivers/gpio/langwell_gpio.c:161: warning: (near initialization for lnw_irqchip') drivers/gpio/langwell_gpio.c:162: error: unknown field unmask' specified in initializer drivers/gpio/langwell_gpio.c:162: warning: excess elements in struct initializer drivers/gpio/langwell_gpio.c:162: warning: (near initialization for lnw_irqchip') drivers/gpio/langwell_gpio.c:163: error: unknown field set_type' specified in initializer drivers/gpio/langwell_gpio.c:163: warning: excess elements in struct initializer drivers/gpio/langwell_gpio.c:163: warning: (near initialization for lnw_irqchip') drivers/gpio/langwell_gpio.c: In function lnw_irq_handler':drivers/gpio/langwell_gpio.c:174: error: implicit declaration of function get_irq_data' drivers/gpio/langwell_gpio.c:174: warning: cast to pointer from integer of different size drivers/gpio/langwell_gpio.c:189: error: implicit declaration of function generic_handle_irq' drivers/gpio/langwell_gpio.c:195: error: dereferencing pointer to incomplete type drivers/gpio/langwell_gpio.c: In function `lnw_gpio_probe':drivers/gpio/langwell_gpio.c:263: error: implicit declaration of function set_irq_data' drivers/gpio/langwell_gpio.c:264: error: implicit declaration of function set_irq_chained_handler' drivers/gpio/langwell_gpio.c:266: error: implicit declaration of function set_irq_chip_and_handler_name' drivers/gpio/langwell_gpio.c:267: error: handle_simple_irq' undeclared (first use in this function) drivers/gpio/langwell_gpio.c:268: error: implicit declaration of function `set_irq_chip_data' drivers/gpio/langwell_gpio.c: At top level:drivers/gpio/langwell_gpio.c:159: error: storage size of `lnw_irqchip' isn't known
Andrew,
Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <linux/irq.h> by explicit.
Quoted 1 line
From
5f0f166b37c4313c27de32f6f200bbd0656603b7Mon Sep 17 00:00:00 2001
From: Alek Du <[email protected]>
Date: Fri, 18 Sep 2009 09:09:19 +0800
Subject: [PATCH] gpio: Fix Langwell gpio driver build error
Need to include <linux/irq.h> directly ...
--- drivers/gpio/langwell_gpio.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/gpio/langwell_gpio.c +1 -0
@@ -27,6 +27,7 @@#include <linux/interrupt.h> #include <linux/init.h> #include <linux/io.h> +#include <linux/irq.h> #include <linux/gpio.h> struct lnw_gpio_register {
Signature · 4 lines
1.6.0.4 On Fri, 18 Sep 2009 07:36:44 +0800
Quoted 62 lines · Andrew Morton
Quoted 11 lines · On Fri, 3 Jul 2009 21:07:06 +0800 Alek Du <[email protected]> wrote:
Changes from v2:
1. Add missedMODULE_DEVICE_TABLEChanges from v1:
1. driver name changed fromlnw.c==>langwell_gpio.c
2. removed hard coded driver data, now we get it from PCI bar1 (platform init code fills it)
3. removed alternative function setting code, it should be called in platform init part.
4. misc. style cleanQuoted 1 line
From
8eaad3aac8cffda193adcfc4b9fcbb7c461fd4b9Mon Sep 17 00:00:00 2001Quoted 8 lines
From: Alek Du <[email protected]>
Date: Tue, 30 Jun 2009 12:13:27 +0800
Subject: [PATCH] gpio: add Intel Moorestown Platform Langwell chip gpio driverThe Langwell chip is the IO hub for Intel Moorestown platform which has a 64-pin gpio block device inside. It is exposed as a dedicated PCI device. We use it to control outside peripheral as well as to do IRQ demuxing. The gpio block uses MSI to send level type interrupt to IOAPIC.
sparc64 allmodconfig:
drivers/gpio/langwell_gpio.c: In function `lnw_irq_type':drivers/gpio/langwell_gpio.c:117: error: implicit declaration of functionget_irq_chip_data' drivers/gpio/langwell_gpio.c:117: warning: initialization makes pointer from integer without a cast drivers/gpio/langwell_gpio.c:128: error:IRQ_TYPE_EDGE_RISING' undeclared (first use in this function)drivers/gpio/langwell_gpio.c:128: error: (Each undeclared identifier is reported only oncedrivers/gpio/langwell_gpio.c:128: error: for each function it appears in.)drivers/gpio/langwell_gpio.c:134: error:IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function) drivers/gpio/langwell_gpio.c: In functionlnw_irq_unmask':drivers/gpio/langwell_gpio.c:146: warning: initialization makes pointer from integer without a castdrivers/gpio/langwell_gpio.c: At top level:drivers/gpio/langwell_gpio.c:159: error: variablelnw_irqchip' has initializer but incomplete type drivers/gpio/langwell_gpio.c:160: error: unknown fieldname' specified in initializerdrivers/gpio/langwell_gpio.c:160: warning: excess elements in struct initializerdrivers/gpio/langwell_gpio.c:160: warning: (near initialization forlnw_irqchip') drivers/gpio/langwell_gpio.c:161: error: unknown fieldmask' specified in initializerdrivers/gpio/langwell_gpio.c:161: warning: excess elements in struct initializerdrivers/gpio/langwell_gpio.c:161: warning: (near initialization forlnw_irqchip') drivers/gpio/langwell_gpio.c:162: error: unknown fieldunmask' specified in initializerdrivers/gpio/langwell_gpio.c:162: warning: excess elements in struct initializerdrivers/gpio/langwell_gpio.c:162: warning: (near initialization forlnw_irqchip') drivers/gpio/langwell_gpio.c:163: error: unknown fieldset_type' specified in initializerdrivers/gpio/langwell_gpio.c:163: warning: excess elements in struct initializerdrivers/gpio/langwell_gpio.c:163: warning: (near initialization forlnw_irqchip') drivers/gpio/langwell_gpio.c: In functionlnw_irq_handler':drivers/gpio/langwell_gpio.c:174: error: implicit declaration of functionget_irq_data' drivers/gpio/langwell_gpio.c:174: warning: cast to pointer from integer of different size drivers/gpio/langwell_gpio.c:189: error: implicit declaration of functiongeneric_handle_irq'drivers/gpio/langwell_gpio.c:195: error: dereferencing pointer to incomplete typedrivers/gpio/langwell_gpio.c: In function `lnw_gpio_probe':drivers/gpio/langwell_gpio.c:263: error: implicit declaration of functionset_irq_data' drivers/gpio/langwell_gpio.c:264: error: implicit declaration of functionset_irq_chained_handler'drivers/gpio/langwell_gpio.c:266: error: implicit declaration of functionset_irq_chip_and_handler_name' drivers/gpio/langwell_gpio.c:267: error:handle_simple_irq' undeclared (first use in this function)drivers/gpio/langwell_gpio.c:268: error: implicit declaration of function `set_irq_chip_data'drivers/gpio/langwell_gpio.c: At top level:drivers/gpio/langwell_gpio.c:159: error: storage size of `lnw_irqchip' isn't known
Quoted 19 lines · On Fri, 18 Sep 2009 09:18:44 +0800 Alek Du <[email protected]> wrote:
Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <
linux/irq.h> by explicit.Quoted 1 line
From
5f0f166b37c4313c27de32f6f200bbd0656603b7Mon Sep 17 00:00:00 2001From: Alek Du <[email protected]>
Date: Fri, 18 Sep 2009 09:09:19 +0800
Subject: [PATCH] gpio: Fix Langwell gpio driver build errorNeed to include <
linux/irq.h> directly ...Signed-off-by Alek Du <[email protected]>--- drivers/gpio/langwell_gpio.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/gpio/langwell_gpio.c +0
-0
drivers/gpio/langwell_gpio.c line 33
Quoted 7 lines
drivers/gpio/langwell_gpio.c +1
-0@@ -27,6 +27,7 @@#include <linux/interrupt.h> #include <linux/init.h> #include <linux/io.h> +#include <linux/irq.h> #include <linux/gpio.h> struct lnw_gpio_register {
include/linux/irq.h says
/*
* Please do not include this file in generic code. There is currently
* no requirement for any architecture to implement anything held
* within this file.
*
* Thanks. --rmk
*/
but
y:/usr/src/linux-2.6.31> grep -rl 'linux/irq.h' drivers | wc -l 101
Russell, is that rule no longer true?
Thanks.
Quoted 39 lines · Andrew Morton
Quoted 19 lines · On Fri, 18 Sep 2009 09:18:44 +0800 Alek Du <[email protected]> wrote:
Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <
linux/irq.h> by explicit.Quoted 1 line
From
5f0f166b37c4313c27de32f6f200bbd0656603b7Mon Sep 17 00:00:00 2001From: Alek Du <[email protected]>
Date: Fri, 18 Sep 2009 09:09:19 +0800
Subject: [PATCH] gpio: Fix Langwell gpio driver build errorNeed to include <
linux/irq.h> directly ...Signed-off-by Alek Du <[email protected]>--- drivers/gpio/langwell_gpio.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/gpio/langwell_gpio.c +0
-0drivers/gpio/langwell_gpio.c line 33
Quoted 7 lines
drivers/gpio/langwell_gpio.c +1
-0@@ -27,6 +27,7 @@#include <linux/interrupt.h> #include <linux/init.h> #include <linux/io.h> +#include <linux/irq.h> #include <linux/gpio.h> struct lnw_gpio_register {
include/linux/irq.hsays/*
* Please do not include this file in generic code. There is currently
* no requirement for any architecture to implement anything held
* within this file.
*
* Thanks. --rmk
*/
Quoted 6 lines
but
y:/usr/src/linux-2.6.31> grep -rl '
linux/irq.h' drivers | wc -l 101Russell, is that rule no longer true?
Ever since ARM was converted over to genirq, I've given up fighting it. It does still mean that any arch not using genirq is going to have problems with these drivers.
I suspect that it's still the case that many of these includes should be linux/interrupt.h and not linux/irq.h
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
Quoted 8 lines · On Fri, 18 Sep 2009 15:49:51 +0800 Russell King <[email protected]>…
Ever since ARM was converted over to genirq, I've given up fighting it. It does still mean that any arch not using genirq is going to have problems with these drivers.
I suspect that it's still the case that many of these includes should be
linux/interrupt.hand notlinux/irq.h
I have included linux/interrupt.h, but it failed for sparc64 building. So I have to send the patch to add linux/irq.h.
Thanks,
Alek