staging/android/lowmemorykiller: fix module param errors
PATCH 1/1 staging/android/lowmemorykiller: fix module param errors
From: Randy Dunlap <[email protected]>
Move module_params to near the end of the source file so that their references are already known/defined. Fixes build errors:
drivers/staging/android/lowmemorykiller.c: In function '__check_cost':drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function) drivers/staging/android/lowmemorykiller.c: At top level:drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function) drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'
--- drivers/staging/android/lowmemorykiller.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/android/lowmemorykiller.c +7 -7
@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;printk (x); \ }while (0 ) -module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); -module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, -S_IRUGO |S_IWUSR ); -module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, -S_IRUGO |S_IWUSR ); -module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); - static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask) {struct task_struct *p;
@@ -166,6 +159,13 @@ static void __exit lowmem_exit(void)unregister_shrinker (&lowmem_shrinker); } +module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); +module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, +S_IRUGO |S_IWUSR ); +module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, +S_IRUGO |S_IWUSR ); +module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); +module_init (lowmem_init);module_exit (lowmem_exit);
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
Quoted 35 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Move
module_paramsto near the end of the source file so that their references are already known/defined. Fixes build errors:
drivers/staging/android/lowmemorykiller.c: In function '__check_cost':drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function)drivers/staging/android/lowmemorykiller.c: At top level:drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function)drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'Signed-off-by Randy Dunlap <[email protected]>--- drivers/staging/android/lowmemorykiller.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/staging/android/lowmemorykiller.c +0
-7@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;printk (x); \ }while (0 ) -module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); -module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, -S_IRUGO |S_IWUSR ); -module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, -S_IRUGO |S_IWUSR ); -module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); - static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask) {struct task_struct *p;@@ -166,6 +159,13 @@ static void __exit lowmem_exit(void)unregister_shrinker (&lowmem_shrinker); }
drivers/staging/android/lowmemorykiller.c static void __exit lowmem_exit(void) · line 170
Quoted 10 lines
drivers/staging/android/lowmemorykiller.c +7
-0+module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); +module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, +S_IRUGO |S_IWUSR ); +module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, +S_IRUGO |S_IWUSR ); +module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); +module_init (lowmem_init);module_exit (lowmem_exit);
isn't that a bit non-standard? from what i've seen, the standard
seems to be to define something as a module parameter *immediately* after its definition, not to collect them all at the bottom of the source file separate from the definitions. *is* there a standard for that?
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
"Kernel Newbie Corner" column @ linux.com: http://cli.gs/WG6WYX
========================================================================
Quoted 38 lines · On Fri, 31 Jul 2009 14:14:57 -0400 (EDT) Robert P. J. Day wrote:
Quoted 36 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Move
module_paramsto near the end of the source file so that their references are already known/defined. Fixes build errors:
drivers/staging/android/lowmemorykiller.c: In function '__check_cost':drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function)drivers/staging/android/lowmemorykiller.c: At top level:drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function)drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'Signed-off-by Randy Dunlap <[email protected]>--- drivers/staging/android/lowmemorykiller.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/staging/android/lowmemorykiller.c +0
-7@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;printk (x); \ }while (0 ) -module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); -module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, -S_IRUGO |S_IWUSR ); -module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, -S_IRUGO |S_IWUSR ); -module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); - static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask) {struct task_struct *p;@@ -166,6 +159,13 @@ static void __exit lowmem_exit(void)unregister_shrinker (&lowmem_shrinker); }
Quoted 15 lines
drivers/staging/android/lowmemorykiller.c static void __exit lowmem_exit(void) · line 170
Quoted 9 lines
drivers/staging/android/lowmemorykiller.c +7
-0+module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); +module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, +S_IRUGO |S_IWUSR ); +module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, +S_IRUGO |S_IWUSR ); +module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); +module_init (lowmem_init);module_exit (lowmem_exit);isn't that a bit non-standard? from what i've seen, the standard
seems to be to define something as a module parameter *immediately* after its definition, not to collect them all at the bottom of the source file separate from the definitions. *is* there a standard for that?
not that i know of. and we generally prefer to avoid forward declarations just to satisfy such errors.
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
[email protected]
Appliedpatch staging-android-lowmemorykiller-fix-module-param-errors.patch added to gregkh-2.6 tree
In reply to Randy DunlapThis is a note to let you know that I've just added the patch titled
Subject: Staging: android: lowmemorykiller: fix module param errors
to my gregkh-2.6 tree. Its filename is
staging-android-lowmemorykiller-fix-module-param-errors.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
Quoted 1 line
From [email protected] Mon Aug 10 11:43:15 2009
From: Randy Dunlap <[email protected]>
Date: Fri, 31 Jul 2009 11:10:45 -0700
Subject: Staging: android: lowmemorykiller: fix module param errors
To: lkml <[email protected]>
Cc: [email protected], [email protected]
Message-ID: <[email protected]>
From: Randy Dunlap <[email protected]>
Move module_params to near the end of the source file so that their references are already known/defined. Fixes build errors:
drivers/staging/android/lowmemorykiller.c: In function '__check_cost':drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared (first use in this function) drivers/staging/android/lowmemorykiller.c: At top level:drivers/staging/android/lowmemorykiller.c:60: error: 'lowmem_shrinker' undeclared here (not in a function) drivers/staging/android/lowmemorykiller.c:60: warning: type defaults to 'int' in declaration of 'type name'
--- drivers/staging/android/lowmemorykiller.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/android/lowmemorykiller.c +7 -7
@@ -57,13 +57,6 @@ static int lowmem_minfree_size = 4;printk (x); \ }while (0 ) -module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); -module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, -S_IRUGO |S_IWUSR ); -module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, -S_IRUGO |S_IWUSR ); -module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); - static int lowmem_shrink(int nr_to_scan, gfp_t gfp_mask) {struct task_struct *p;
@@ -166,6 +159,13 @@ static void __exit lowmem_exit(void)unregister_shrinker (&lowmem_shrinker); } +module_param_named (cost, lowmem_shrinker.seeks, int,S_IRUGO |S_IWUSR ); +module_param_array_named (adj, lowmem_adj, int, &lowmem_adj_size, +S_IRUGO |S_IWUSR ); +module_param_array_named (minfree, lowmem_minfree, uint, &lowmem_minfree_size, +S_IRUGO |S_IWUSR ); +module_param_named (debug_level, lowmem_debug_level, uint,S_IRUGO |S_IWUSR ); +module_init (lowmem_init);module_exit (lowmem_exit);