pulse: call pa_threaded_mainloop_wait() to handle spurious wakeups
PATCH 4/4 pulse: call pa_threaded_mainloop_wait() to handle spurious wakeups
pa_threaded_mainloop_wait() can wake up for no reason, according to the specs of the underlying POSIX ptrhead_cond_wait() docs, so we need to call it in a loop here which should be cleaner anyway.
--- pulse/pulse.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-)
pulse/pulse.c +10 -3
@@ -262,10 +262,17 @@ int pulse_connect(snd_pulse_t * p, const char *server)if (err <0 ) goto error; -pa_threaded_mainloop_wait (p->mainloop); +for (;;) { +pa_context_state_t state =pa_context_get_state (p->context); -if (pa_context_get_state (p->context) !=PA_CONTEXT_READY ) - goto error; +if (!PA_CONTEXT_IS_GOOD (state)) + goto error; + +if (state ==PA_CONTEXT_READY ) +break ; + +pa_threaded_mainloop_wait (p->mainloop); + }pa_threaded_mainloop_unlock (p->mainloop);
Signature · 10 lines
1.6.3.3 Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net ICQ# 11060553 http://0pointer.net/lennart/ GnuPG 0x1A015CC4