Skip to contentSkip to conversation

Remove redundant BUG_ON in __dlm_queue_ast

PATCH New Goldwyn Rodrigues 3 participants 4 messages Jul 31, 2009 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove redundant BUG_ON in __dlm_queue_ast

Remove redundant BUG_ON()

---

fs/ocfs2/dlm/dlmast.c +0 -1
index d07ddbe..81eff8e 100644
@@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
 		     lock->ast_pending, lock->ml.type);
 		BUG();
 	}
-	BUG_ON(!list_empty(&lock->ast_list));
 	if (lock->ast_pending)
 		mlog(0, "lock has an ast getting flushed right now\n");
 
Signature · 1 line
Goldwyn
#1 lore raw

PATCH 1/1 Remove redundant BUG_ON in __dlm_queue_ast

Can you explain why you think it is redundant?

Quoted 19 lines · Goldwyn Rodrigues

Remove redundant BUG_ON()

---

fs/ocfs2/dlm/dlmast.c +0 -1
index d07ddbe..81eff8e 100644
@@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
 		     lock->ast_pending, lock->ml.type);
 		BUG();
 	}
-	BUG_ON(!list_empty(&lock->ast_list));
 	if (lock->ast_pending)
 		mlog(0, "lock has an ast getting flushed right now\n");
 
#2 lore raw

PATCH 1/1 Remove redundant BUG_ON in __dlm_queue_ast

In reply to Goldwyn Rodrigues
Quoted 19 lines · Goldwyn Rodrigues

Remove redundant BUG_ON()

---

fs/ocfs2/dlm/dlmast.c +0 -1
index d07ddbe..81eff8e 100644
@@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock)
 		     lock->ast_pending, lock->ml.type);
 		BUG();
 	}
-	BUG_ON(!list_empty(&lock->ast_list));
 	if (lock->ast_pending)
 		mlog(0, "lock has an ast getting flushed right now\n");
 
#3 lore raw

PATCH 1/1 Remove redundant BUG_ON in __dlm_queue_ast

In reply to Goldwyn Rodrigues
Quoted 3 lines · Goldwyn Rodrigues

Remove redundant BUG_ON()

This is now in the fixes branch of ocfs2.git.

Joel

Signature · 10 lines
"Same dancers in the same old shoes.
 You get too careful with the steps you choose.
 You don't care about winning but you don't want to lose
 After the thrill is gone."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127