Compile error

Hi,

I'm getting following error when compiling the latest git version with gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3.

cc1: warnings being treated as errors
sim.c: In function ‘sim_op_retrieve_cb’:
sim.c:347: error: ignoring return value of ‘write’, declared with attribute warn_unused_result
sim.c: In function ‘sim_op_info_cb’:
sim.c:473: error: ignoring return value of ‘write’, declared with attribute warn_unused_result
make[2]: *** [sim.o] Error 1

Regards,
Marko

Attached is a patch to fix the errors.

WARNING: It still does nothing with the return values, but it resolves the compiler errors, *that's it*.

Someone who knows something about what should happen if the write fails really ought to review and adjust this as appropriate. I am not that person.

Shane...

From: Shane Bryan <[email protected]>
Date: Tue, 4 Aug 2009 09:13:31 -0700
Subject: [PATCH] fix ignored return size when calling write ()

sim.c uses write () but ignores the size returned. This causes compile failures with default options generated with bootstrap

---
 src/sim.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

index 6e144f4..1c0666e 100644
@@ -312,6 +312,7 @@ static void sim_op_retrieve_cb(const struct ofono_error *error,
 	char *imsi = sim->imsi;
 	char *path;
 	int fd;
+	ssize_t w_size;
 
 	if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
 		sim_op_error(modem);

@@ -333,7 +334,7 @@ static void sim_op_retrieve_cb(const struct ofono_error *error,
 		if (lseek(fd, (op->current - 1) * op->record_length +
 					SIM_CACHE_HEADER_SIZE, SEEK_SET) !=
 				(off_t) -1)
-			write(fd, data, op->record_length);
+			w_size = write(fd, data, op->record_length);
 		close(fd);
 	}
 

@@ -409,6 +410,7 @@ static void sim_op_info_cb(const struct ofono_error *error, int length,
 	enum sim_file_access update;
 	enum sim_file_access invalidate;
 	enum sim_file_access rehabilitate;
+	ssize_t w_size;
 
 	if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
 		sim_op_error(modem);

@@ -459,7 +461,7 @@ static void sim_op_info_cb(const struct ofono_error *error, int length,
 		fileinfo[4] = record_length >> 8;
 		fileinfo[5] = record_length & 0xff;
 
-		write(fd, fileinfo, 6);
+		w_size = write(fd, fileinfo, 6);
 		close(fd);
 	}
 }

1.6.0.4

Hi,

Andrew & myself have fixed this properly yesterday, the patch should now be pushed upstream.

Regards,
-Denis

Heh, figures... I was too lazy to pull latest and check before I fired off my temp fix. Thanks for pushing a fix though!

Shane...