Skip to contentSkip to conversation

ACPI: pci_slot.ko wants a 64-bit _SUN

PATCH In review Alex Chiang 2 participants 2 messages Aug 4, 2009 – Aug 31, 2009

Subsystems (2)
ACPI PCI
lore
Share & tools
lore

Alex Chiang

author
#0 lore raw

PATCH 1/1 ACPI: pci_slot.ko wants a 64-bit _SUN

Similar to commit b6adc195 (PCI hotplug: acpiphp wants a 64-bit _SUN), pci_slot.ko reads and creates sysfs directories based on the _SUN method.

Certain HP platforms return 64 bits in _SUN. This change to pci_slot.ko allows us to see the correct sysfs directories.

Reported-by Chad Smith <[email protected]>
Cc [email protected]
Signed-off-by Alex Chiang <[email protected]>

---
Stable team, this should be backported to all kernels in the stable series.

---

drivers/acpi/pci_slot.c +2 -2
index 12158e0..ab40e06 100644
@@ -57,7 +57,7 @@ ACPI_MODULE_NAME("pci_slot");
 				MY_NAME , ## arg);		\
 	} while (0)
 
-#define SLOT_NAME_SIZE 20		/* Inspired by #define in acpiphp.h */
+#define SLOT_NAME_SIZE 21		/* Inspired by #define in acpiphp.h */
 
 struct acpi_pci_slot {
 	acpi_handle root_handle;	/* handle of the root bridge */

@@ -149,7 +149,7 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
 		return AE_OK;
 	}
 
-	snprintf(name, sizeof(name), "%u", (u32)sun);
+	snprintf(name, sizeof(name), "%llu", sun);
 	pci_slot = pci_create_slot(pci_bus, device, name, NULL);
 	if (IS_ERR(pci_slot)) {
 		err("pci_create_slot returned %ld\n", PTR_ERR(pci_slot));
reviewer
#1 lore raw

applied for linux-2.6.31

thanks,
Len Brown, Intel Open Source Technology Center