Skip to contentSkip to conversation

pulse: replace manual mainloop by pa_mainloop_iterate()

PATCH In review Lennart Poettering 2 participants 2 messages Aug 4, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 pulse: replace manual mainloop by pa_mainloop_iterate()

The pa_mainloop_prepare()/_poll()/_dispatch() can be simplified by simply calling pa_mainloop_iterate() which does all this in one call.

---
 pulse/conf_pulse.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
pulse/conf_pulse.c +1 -9
index 3f9e071..35dd383 100644
@@ -61,15 +61,7 @@ conf_pulse_hook_load_if_running(snd_config_t * root, snd_config_t * config,
 		goto out;
 
 	do {
-		err = pa_mainloop_prepare(loop, -1);
-		if (err < 0)
-			goto out;
-
-		err = pa_mainloop_poll(loop);
-		if (err < 0)
-			goto out;
-
-		err = pa_mainloop_dispatch(loop);
+		err = pa_mainloop_iterate(loop, 1, NULL);
 		if (err < 0)
 			goto out;
 
Signature · 10 lines
1.6.4



Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4
#1 lore raw

At Tue, 4 Aug 2009 23:53:51 +0200,

Quoted 3 lines · Lennart Poettering

The pa_mainloop_prepare()/_poll()/_dispatch() can be simplified by simply calling pa_mainloop_iterate() which does all this in one call.

Applied all 6 patches now (with a build fix). Thanks.

Takashi