Skip to contentSkip to conversation

pxaficp-ir - remove incorrect net_device_ops

PATCH Applied Eric Miao 4 participants 9 messages Jul 28, 2009 – Aug 24, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Eric Miao

author
#1 lore raw
Quoted 9 lines · Marek Vasut

Hi!

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Quoted 4 lines

Moreover this patch corrects missing sysfs device link.

btw. guys, be honest, when did you last tested pxaficp-ir on real hardware? ;-)

Well, this seems to be brought by the net_device_ops change, which seems to happen silently without any of us being notified.

OK, netdev and Alex are copied, so that we can look into this issue a bit deeper:

1. it looks to me that SIOCSIFFLAGS actually returned -EADDRNOTAVAIL, which is likely caused by eth_validate_addr, the default eth_addr comes with irda should be "00:00:00:00:00:00" if not explicitly specified (kzalloc), and this should be the problem, solution ? Either give a valid address to the irda net_device or remove this 'ndo_validate_addr'. And which is a correct fix will impact on the .ndo_set_mac_address

2. '.ndo_change_mtu' ? It looks to me that Irda device doesn't care too much about the MTU, eth_change_mtu is supposed to work just fine and not to cause any side effects, and may just benefit later irda device drivers if there is a weird device happens to care about MTU

- eric

Marek's original patch in attachment.

Quoted 1 line

From 28b229f0f3f807d775a7e70b96c018eef935a24a Mon Sep 17 00:00:00 2001

From: Marek Vasut <[email protected]>
Date: Fri, 24 Jul 2009 02:44:02 +0200
Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Moreover this patch corrects missing sysfs device link.

---
 drivers/net/irda/pxaficp_ir.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/net/irda/pxaficp_ir.c +1 -3
index 4edbdbe..f5b7d83 100644
@@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = {
 	.ndo_stop		= pxa_irda_stop,
 	.ndo_start_xmit		= pxa_irda_hard_xmit,
 	.ndo_do_ioctl		= pxa_irda_ioctl,
-	.ndo_change_mtu		= eth_change_mtu,
-	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_set_mac_address	= eth_mac_addr,
 };
 
 static int pxa_irda_probe(struct platform_device *pdev)
@@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev)
 	if (!dev)
 		goto err_mem_3;
 
+	SET_NETDEV_DEV(dev, &pdev->dev);
 	si = netdev_priv(dev);
 	si->dev = &pdev->dev;
 	si->pdata = pdev->dev.platform_data;
Signature · 1 line
1.6.3.3
#2 lore raw

2009/7/28 Eric Miao <[email protected]>:

Quoted 28 lines
Quoted 9 lines · Marek Vasut

Hi!

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
 - failing ifconfig for IrLAN, resulting in
      SIOCSIFFLAGS: Cannot assign requested address
 - irattach working for IrCOMM, but the port stayed disabled

Quoted 4 lines

Moreover this patch corrects missing sysfs device link.

btw. guys, be honest, when did you last tested pxaficp-ir on real hardware? ;-)

Well, this seems to be brought by the net_device_ops change, which seems to happen silently without any of us being notified.

OK, netdev and Alex are copied, so that we can look into this issue a bit deeper:

1. it looks to me that SIOCSIFFLAGS actually returned -EADDRNOTAVAIL, which is likely caused by eth_validate_addr, the default eth_addr comes with irda should be "00:00:00:00:00:00" if not explicitly specified (kzalloc), and this should be the problem, solution ?  Either give a valid address to the irda net_device or remove this 'ndo_validate_addr'. And which is a correct fix will impact on the .ndo_set_mac_address

Quoted 9 lines

2. '.ndo_change_mtu' ? It looks to me that Irda device doesn't care too much about the MTU, eth_change_mtu is supposed to work just fine and not to cause any side effects, and may just benefit later irda device drivers if there is a weird device happens to care about MTU

- eric

Marek's original patch in attachment.

Sorry about that and thanks.
Then we should fix the rest of irda drivers in the same way.

#3 lore raw

Dne St 29. července 2009 13:16:25 Alexander Beregalov napsal(a):

Quoted 34 lines

2009/7/28 Eric Miao <[email protected]>:

Quoted 33 lines
Quoted 9 lines · Marek Vasut

Hi!

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Quoted 4 lines

Moreover this patch corrects missing sysfs device link.

btw. guys, be honest, when did you last tested pxaficp-ir on real hardware? ;-)

Well, this seems to be brought by the net_device_ops change, which seems to happen silently without any of us being notified.

OK, netdev and Alex are copied, so that we can look into this issue a bit deeper:

1. it looks to me that SIOCSIFFLAGS actually returned -EADDRNOTAVAIL, which is likely caused by eth_validate_addr, the default eth_addr comes with irda should be "00:00:00:00:00:00" if not explicitly specified (kzalloc), and this should be the problem, solution ? Either give a valid address to the irda net_device or remove this 'ndo_validate_addr'. And which is a correct fix will impact on the .ndo_set_mac_address

2. '.ndo_change_mtu' ? It looks to me that Irda device doesn't care too much about the MTU, eth_change_mtu is supposed to work just fine and not to cause any side effects, and may just benefit later irda device drivers if there is a weird device happens to care about MTU

Quoted 6 lines
Quoted 3 lines

- eric

Marek's original patch in attachment.

Sorry about that and thanks.
Then we should fix the rest of irda drivers in the same way.

Hi!
Was my patch applied or what's the current status? Thanks

#4 lore raw

Dne St 5. srpna 2009 16:02:34 Marek Vasut napsal(a):

Quoted 38 lines

Dne St 29. ?ervence 2009 13:16:25 Alexander Beregalov napsal(a):

Quoted 37 lines

2009/7/28 Eric Miao <[email protected]>:

Quoted 36 lines
Quoted 9 lines · Marek Vasut

Hi!

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Quoted 4 lines

Moreover this patch corrects missing sysfs device link.

btw. guys, be honest, when did you last tested pxaficp-ir on real hardware? ;-)

Well, this seems to be brought by the net_device_ops change, which seems to happen silently without any of us being notified.

OK, netdev and Alex are copied, so that we can look into this issue a bit deeper:

1. it looks to me that SIOCSIFFLAGS actually returned -EADDRNOTAVAIL, which is likely caused by eth_validate_addr, the default eth_addr comes with irda should be "00:00:00:00:00:00" if not explicitly specified (kzalloc), and this should be the problem, solution ? Either give a valid address to the irda net_device or remove this 'ndo_validate_addr'. And which is a correct fix will impact on the .ndo_set_mac_address

2. '.ndo_change_mtu' ? It looks to me that Irda device doesn't care too much about the MTU, eth_change_mtu is supposed to work just fine and not to cause any side effects, and may just benefit later irda device drivers if there is a weird device happens to care about MTU

- eric

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Marek's original patch in attachment.

Sorry about that and thanks.
Then we should fix the rest of irda drivers in the same way.

Hi!
Was my patch applied or what's the current status? Thanks

Hi!
any updates ? Are we letting this into .32 in current broken state?

Thanks!

#5 lore raw

2009/8/22 Marek Vasut <[email protected]>:

Quoted 41 lines

Dne St 5. srpna 2009 16:02:34 Marek Vasut napsal(a):

Quoted 40 lines

Dne St 29. července 2009 13:16:25 Alexander Beregalov napsal(a):

Quoted 39 lines

2009/7/28 Eric Miao <[email protected]>:

Quoted 37 lines
Quoted 9 lines · Marek Vasut

Hi!

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
 - failing ifconfig for IrLAN, resulting in
      SIOCSIFFLAGS: Cannot assign requested address
 - irattach working for IrCOMM, but the port stayed disabled

Quoted 4 lines

Moreover this patch corrects missing sysfs device link.

btw. guys, be honest, when did you last tested pxaficp-ir on real hardware? ;-)

Well, this seems to be brought by the net_device_ops change, which seems to happen silently without any of us being notified.

OK, netdev and Alex are copied, so that we can look into this issue a bit deeper:

1. it looks to me that SIOCSIFFLAGS actually returned -EADDRNOTAVAIL, which is likely caused by eth_validate_addr, the default eth_addr comes with irda should be "00:00:00:00:00:00" if not explicitly specified (kzalloc), and this should be the problem, solution ?  Either give a valid address to the irda net_device or remove this 'ndo_validate_addr'. And which is a correct fix will impact on the .ndo_set_mac_address

2. '.ndo_change_mtu' ? It looks to me that Irda device doesn't care too much about the MTU, eth_change_mtu is supposed to work just fine and not to cause any side effects, and may just benefit later irda device drivers if there is a weird device happens to care about MTU

- eric

Marek's original patch in attachment.

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

Sorry about that and thanks.
Then we should fix the rest of irda drivers in the same way.

Hi!
Was my patch applied or what's the current status? Thanks

Hi!
any updates ? Are we letting this into .32 in current broken state?

David, please have a look. Will you apply it?

maintainer
#6 lore raw

From: Alexander Beregalov <[email protected]>
Date: Sun, 23 Aug 2009 21:55:45 +0400

Quoted 1 line

David, please have a look. Will you apply it?

Can someone please repost the patch to netdev? I don't have a copy handy and I'd like to see it tracked properly patchwork too. If it's in patchwork, it won't get lost.

Thanks.

#7 lore raw
Quoted 8 lines · David Miller

From: Alexander Beregalov <[email protected]>
Date: Sun, 23 Aug 2009 21:55:45 +0400

Quoted 1 line

David, please have a look. Will you apply it?

Can someone please repost the patch to netdev? I don't have a copy handy and I'd like to see it tracked properly patchwork too. If it's in patchwork, it won't get lost.

maintainer Applied
#8 lore raw

From: Alexander Beregalov <[email protected]>
Date: Mon, 24 Aug 2009 08:38:31 +0400

Quoted 9 lines

Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Quoted 3 lines

Moreover this patch corrects missing sysfs device link.

Applied, thanks.

#9 lore raw

Dne Po 24. srpna 2009 07:57:43 David Miller napsal(a):

Quoted 12 lines

From: Alexander Beregalov <[email protected]>
Date: Mon, 24 Aug 2009 08:38:31 +0400

Quoted 9 lines

Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops

This patch fixes broken pxaficp-ir. The problem was in incorrect net_device_ops being specified which prevented the driver from operating. The symptoms were:
- failing ifconfig for IrLAN, resulting in
SIOCSIFFLAGS: Cannot assign requested address
- irattach working for IrCOMM, but the port stayed disabled

Quoted 5 lines
Quoted 3 lines

Moreover this patch corrects missing sysfs device link.

Applied, thanks.

Thank you.