slqb: add declaration for kmem_cache_init_late()
PATCH 1/1 slqb: add declaration for kmem_cache_init_late()
--- include/linux/slqb_def.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/slqb_def.h +2 -0
@@ -298,4 +298,6 @@ static __always_inline void *kmalloc_nod }#endif +void __init kmem_cache_init_late (void ); +#endif /* _LINUX_SLQB_DEF_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerQuoted 8 lines · On Thu, 6 Aug 2009 10:27:04 +0800 Wu Fengguang <[email protected]> wrote:
Signed-off-by Wu Fengguang <[email protected]>--- include/linux/slqb_def.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/slqb_def.h static __always_inline void *kmalloc_nod · line 303
Quoted 6 lines
include/linux/slqb_def.h +2
-0@@ -298,4 +298,6 @@ static __always_inline void *kmalloc_nod }#endif +void __init kmem_cache_init_late (void ); +#endif /* _LINUX_SLQB_DEF_H */
spose so.
As all sl[a-zA-Z_]b.c must implement this, why not put the declaration into slab.h?
That would require uninlining the slob one, but it's tiny and __init.
That's one for Pekka to worry about ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/1 slab: remove duplicate kmem_cache_init_late() declarations
Quoted 19 lines · Andrew Morton
Quoted 8 lines · On Thu, 6 Aug 2009 10:27:04 +0800 Wu Fengguang <[email protected]> wrote:
Signed-off-by Wu Fengguang <[email protected]>--- include/linux/slqb_def.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/slqb_def.h static __always_inline void *kmalloc_nod · line 303
Quoted 6 lines
include/linux/slqb_def.h +2
-0@@ -298,4 +298,6 @@ static __always_inline void *kmalloc_nod }#endif +void __init kmem_cache_init_late (void ); +#endif /* _LINUX_SLQB_DEF_H */ spose so.
Quoted 4 lines
As all sl[a-zA-Z_]b.c must implement this, why not put the declaration into
slab.h?That would require uninlining the slob one, but it's tiny and
__init.
Right. It seems someone recently moved the declaration from slab_def.h to slab.h, so the replacement patch is a bit smaller:
---
slab: remove duplicate kmem_cache_init_late() declarations
kmem_cache_init_late() has been declared in slab.h
--- include/linux/slob_def.h | 5 ----- include/linux/slub_def.h | 2 -- mm/slob.c | 5 +++++ 3 files changed, 5 insertions(+), 7 deletions(-)
include/linux/slub_def.h +0 -2
@@ -304,6 +304,4 @@ static __always_inline void *kmalloc_nod }#endif -void __init kmem_cache_init_late (void ); -#endif /* _LINUX_SLUB_DEF_H */
include/linux/slob_def.h +0 -5
@@ -34,9 +34,4 @@ static __always_inline void *__kmalloc(s return kmalloc(size, flags); } -static inline void kmem_cache_init_late (void ) -{ -/* Nothing to do */ -} -#endif /* __LINUX_SLOB_DEF_H */
mm/slob.c +5 -0
@@ -692,3 +692,8 @@ void __init kmem_cache_init(void) { slob_ready =1 ; } + +void __init kmem_cache_init_late (void ) +{ +/* Nothing to do */ +}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Pekka Enberg
AppliedRe: [PATCH] slab: remove duplicate kmem_cache_init_late() declarations
Quoted 6 lines · Wu Fengguang
Right. It seems someone recently moved the declaration from
slab_def.htoslab.h, so the replacement patch is a bit smaller:---
slab: remove duplicatekmem_cache_init_late()declarations
Quoted 7 lines
kmem_cache_init_late()has been declared inslab.hCC Nick Piggin <[email protected]>CC Matt Mackall <[email protected]>CC Pekka Enberg <[email protected]>CC Christoph Lameter <[email protected]>Signed-off-by Wu Fengguang <[email protected]>
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>