Skip to contentSkip to conversation

net/r8169.c: harmless (?) dupe

DISCUSSION Vincent Pelletier 1 participant 1 message Aug 6, 2009

lore
Share & tools
lore
#0 lore raw

Hi.

I was searching for rtl8102 support state in the kernel, and reading the commit[1] adding support I saw this:

+#define R810X_CPCMD_QUIRK_MASK (\

+       EnableBist | \
+       Mac_dbgo_oe | \
+       Force_half_dup | \
+       Force_half_dup | \   <- dupe
+       Force_txflow_en | \
+       Cxpl_dbg_sel | \

If it is harmless by itself, wouldn't it indicate a missing Force_rxflow_en (as in R8168_CPCMD_QUIRK_MASK) ?
I don't have the card yet, so this is no bug report, just wondering.

[1] 2857ffb7b8913ef713533ac5783abd70a20529e4

PS: Please CC me when answering, I'm not subscribed.

Signature · 1 line
Vincent Pelletier