Skip to contentSkip to conversation

sh: fix i2c init order on ap325rxa

PATCH New Magnus Damm 1 participant 2 messages Aug 6, 2009 – Aug 7, 2009 SuperH

lore
Share & tools
lore

Magnus Damm

author
#0 lore raw

PATCH 1/1 sh: fix i2c init order on ap325rxa

From: Magnus Damm <[email protected]>

Convert the AP325RXA board code to register i2c devices from arch_initcall() instead of __initcall(). This fix unbreaks pcf8563 RTC driver support.

Signed-off-by Magnus Damm <[email protected]>

---

Suitable for 2.6.31-rc.

 arch/sh/boards/board-ap325rxa.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
arch/sh/boards/board-ap325rxa.c +9 -3
@@ -399,6 +399,15 @@ static struct i2c_board_info __initdata 
 	},
 };
 
+static int __init ap325rxa_devices_i2c_setup(void)
+{
+	i2c_register_board_info(0, ap325rxa_i2c_devices,
+				ARRAY_SIZE(ap325rxa_i2c_devices));
+
+	return 0;
+}
+arch_initcall(ap325rxa_devices_i2c_setup);
+
 static struct i2c_board_info ap325rxa_i2c_camera[] = {
 	{
 		I2C_BOARD_INFO("ov772x", 0x21),

@@ -538,9 +547,6 @@ static int __init ap325rxa_devices_setup
 
 	platform_resource_setup_memory(&ceu_device, "ceu", 4 << 20);
 
-	i2c_register_board_info(0, ap325rxa_i2c_devices,
-				ARRAY_SIZE(ap325rxa_i2c_devices));
-
 	spi_register_board_info(ap325rxa_spi_devices,
 				ARRAY_SIZE(ap325rxa_spi_devices));
author
#1 lore raw

PATCH 1/1 sh: fix i2c init order on ap325rxa V2

From: Magnus Damm <[email protected]>

Convert the AP325RXA board code to register devices at arch_initcall() time instead of device_initcall(). This fix unbreaks pcf8563 RTC driver support.

Signed-off-by Magnus Damm <[email protected]>

---

Suitable for 2.6.31-rc.

 arch/sh/boards/board-ap325rxa.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/boards/board-ap325rxa.c +1 -1
@@ -547,7 +547,7 @@ static int __init ap325rxa_devices_setup
 	return platform_add_devices(ap325rxa_devices,
 				ARRAY_SIZE(ap325rxa_devices));
 }
-device_initcall(ap325rxa_devices_setup);
+arch_initcall(ap325rxa_devices_setup);
 
 /* Return the board specific boot mode pin configuration */
 static int ap325rxa_mode_pins(void)