Skip to contentSkip to conversation

irq: remove superfluous NULL pointer check in check_irq_resend()

PATCH In review Bartlomiej Zolnierkiewicz 1 participant 3 messages Aug 6, 2009 – Aug 9, 2009 IRQ

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/1 irq: remove superfluous NULL pointer check in check_irq_resend()

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] irq: remove superfluous NULL pointer check in check_irq_resend()

This takes care of the following entry from Dan's list:

kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'

Reported-by Dan Carpenter <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Cc Julia Lawall <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 kernel/irq/resend.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/irq/resend.c +1 -2
Index: b/kernel/irq/resend.c
===================================================================
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *d
 	if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {
 		desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;
 
-		if (!desc->chip || !desc->chip->retrigger ||
-					!desc->chip->retrigger(irq)) {
+		if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {
 #ifdef CONFIG_HARDIRQS_SW_RESEND
 			/* Set it pending and activate the softirq: */
 			set_bit(irq, irqs_resend);
author
#1 lore raw

[tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq_resend()

Commit-ID:  139183d579d6097cdbbd64825bbac54d8481a144
Gitweb:     http://git.kernel.org/tip/139183d579d6097cdbbd64825bbac54d8481a144
Author:     Bartlomiej Zolnierkiewicz <[email protected]>
AuthorDate: Thu, 6 Aug 2009 21:46:03 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sat, 8 Aug 2009 18:18:05 +0200

irq: Remove superfluous NULL pointer check in check_irq_resend()

This takes care of the following entry from Dan's list:

kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'

Reported-by Dan Carpenter <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Cc Julia Lawall <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/irq/resend.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/irq/resend.c +1 -2
index 89c7117..090c376 100644
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq)
 	if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {
 		desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;
 
-		if (!desc->chip || !desc->chip->retrigger ||
-					!desc->chip->retrigger(irq)) {
+		if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {
 #ifdef CONFIG_HARDIRQS_SW_RESEND
 			/* Set it pending and activate the softirq: */
 			set_bit(irq, irqs_resend);
author
#2 lore raw

[tip:irq/core] irq: Remove superfluous NULL pointer check in check_irq_resend()

In reply to Bartlomiej Zolnierkiewicz
Commit-ID:  c36ba80ea01d0aecb652c26799a912e760ce8981
Gitweb:     http://git.kernel.org/tip/c36ba80ea01d0aecb652c26799a912e760ce8981
Author:     Bartlomiej Zolnierkiewicz <[email protected]>
AuthorDate: Thu, 6 Aug 2009 21:46:03 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 9 Aug 2009 12:44:29 +0200

irq: Remove superfluous NULL pointer check in check_irq_resend()

This takes care of the following entry from Dan's list:

kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'

Reported-by Dan Carpenter <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Eugene Teo <[email protected]>
Cc Julia Lawall <[email protected]>

LKML-Reference: <[email protected]>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/irq/resend.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
kernel/irq/resend.c +1 -2
index 89c7117..090c376 100644
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq)
 	if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {
 		desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;
 
-		if (!desc->chip || !desc->chip->retrigger ||
-					!desc->chip->retrigger(irq)) {
+		if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {
 #ifdef CONFIG_HARDIRQS_SW_RESEND
 			/* Set it pending and activate the softirq: */
 			set_bit(irq, irqs_resend);