Skip to contentSkip to conversation

osst: fix read buffer overflow

PATCH In review [email protected] 1 participant 1 message Aug 6, 2009 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 11/11 osst: fix read buffer overflow

From: Roel Kluin <[email protected]>

Check whether index is within bounds before testing the element.

Cc Willem Riede <[email protected]>
Cc James E.J. Bottomley <[email protected]>

---

 drivers/scsi/osst.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/osst.c renamed from drivers/scsi/osst.c~osst-fix-read-buffer-overflow +2 -1
diff -puN drivers/scsi/osst.c~osst-fix-read-buffer-overflow drivers/scsi/osst.c
@@ -5860,7 +5860,8 @@ static int osst_probe(struct device *dev
 	}
 
 	/* find a free minor number */
-	for (i=0; os_scsi_tapes[i] && i<osst_max_dev; i++);
+	for (i = 0; i < osst_max_dev && os_scsi_tapes[i]; i++)
+		;
 	if(i >= osst_max_dev) panic ("Scsi_devices corrupt (osst)");
 	dev_num = i;
 

_