mpt2sas: Remove loop inside config request

PATCH In review Kashyap, Desai 1 participant 1 message Aug 7, 2009 SCSI

Share & tools

Kashyap, Desai

author

2009-08-07 14:29 UTC #0 lore raw

PATCH 6/9 mpt2sas: Remove loop inside config request

This restriction is introduced just to avoid loop of config_request. Retry must be limited so we have restricted config request to maximum 2 times.
---

Signed-off-by Kashyap Desai <[email protected]>

Signed-off-by Eric Moore <[email protected]>

---

drivers/scsi/mpt2sas/mpt2sas_config.c +6 -0

index 8dcfa38..55a1b20 100644
@@ -249,6 +249,12 @@ _config_request(struct MPT2SAS_ADAPTER *ioc, Mpi2ConfigRequest_t
 	retry_count = 0;
 
  retry_config:
+	if (retry_count) {
+		if (retry_count > 2) /* attempt only 2 retries */
+			return -EFAULT;
+		printk(MPT2SAS_INFO_FMT "%s: attempting retry (%d)\n",
+		    ioc->name, __func__, retry_count);
+	}
 	wait_state_count = 0;
 	ioc_state = mpt2sas_base_get_iocstate(ioc, 1);
 	while (ioc_state != MPI2_IOC_STATE_OPERATIONAL) {