ARM Cortex A8: Remove bogus config.mk entries
PATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
Remove bogus config.mk entry, fix newline and remove redundant omap3/config.mk
---
Found by Wolfgang Denk, thanks.
Compile tested with ./MAKEALL ARM_CORTEX_A8
Boot tested on BeagleBoard
This makes v1 of this patch obsolete.
cpu/arm_cortexa8/config.mk | 2 -- cpu/arm_cortexa8/omap3/config.mk | 36 ------------------------------------ 2 files changed, 38 deletions(-)
cpu/arm_cortexa8/config.mk +1 -2
@@ -30,7 +30,6 @@ PLATFORM_CPPFLAGS += -march=armv5 # Supply options according to compiler version # # ========================================================================= -PLATFORM_CPPFLAGS +=$(call cc-option) PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,)) + $(call cc-option,-malignment-traps,))
cpu/arm_cortexa8/omap3/config.mk deleted +0 -36
@@ -1,36 +0,0 @@ -# -# (C) Copyright 2002 -# Gary Jennejohn, DENX Software Engineering, <[email protected]> -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, -# MA 02111-1307 USA -# -PLATFORM_RELFLAGS += -fno-strict-aliasing -fno-common -ffixed-r8 \ - -msoft-float - -# Make ARMv5 to allow more compilers to work, even though its v7a. -PLATFORM_CPPFLAGS += -march=armv5 -# ========================================================================= -# -# Supply options according to compiler version -# -# ========================================================================= -PLATFORM_CPPFLAGS +=$(call cc-option) -PLATFORM_CPPFLAGS +=$(call cc-option,-mno-thumb-interwork,) -PLATFORM_RELFLAGS +=$(call cc-option,-mshort-load-bytes,\ - $(call cc-option,-malignment-traps,))
PATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
Quoted 2 lines · Dirk Behme
Remove bogus config.mk entry, fix newline and remove redundant
omap3/config.mk
do not do this in one step
do this in two step
Best Regards,
J.
PATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 2 lines · Dirk Behme
Remove bogus config.mk entry, fix newline and remove redundant
omap3/config.mkdo not do this in one step
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
Best regards
Dirk
PATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
Quoted 10 lines · Dirk Behme
Quoted 6 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 2 lines · Dirk Behme
Remove bogus config.mk entry, fix newline and remove redundant
omap3/config.mkdo not do this in one step
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
NACK
you remove a file and fix a generic arch file
this need to be done in 2 steps to bisect it
Best Regards,
J.
PATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
Dear Jean-Christophe,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 6 lines · Dirk Behme
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 2 lines · Dirk Behme
Remove bogus config.mk entry, fix newline and remove redundant
omap3/config.mkdo not do this in one step
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
do this in two step
NACK. It's totally fine to have this in one patch to encapsulate this clean up.
NACK
you remove a file and fix a generic arch file
this need to be done in 2 steps to bisect it
Come on, be reasonable. This actually _is_ an atomic fix for one problem, that affects two files.
If it was not for the Signed-off-by: messages I'd recommend Dirk to post his patches under a pseudonym to avoid triggering your flamewar mode with each and every of his postings.
*Please* calm down and get back to a working mode where we do make some progress with the project instead of having endless silly fighting all over the place.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Of all possible committee reactions to any given agenda item, the reaction that will occur is the one which will liberate the greatest amount of hot air. -- Thomas L. Martin
Wolfgang Denk
AppliedPATCH v2 1/1 ARM Cortex A8: Remove bogus config.mk entries
In reply to Dirk BehmeDear Dirk Behme,
Quoted 10 lines · In message <[email protected]> you…
Remove bogus config.mk entry, fix newline and remove redundant
omap3/config.mkSigned-off-by Dirk Behme <[email protected]>---
Found by Wolfgang Denk, thanks.
Compile tested with ./MAKEALL
ARM_CORTEX_A8
Quoted 7 lines
Boot tested on BeagleBoard
This makes v1 of this patch obsolete.
cpu/arm_cortexa8/config.mk | 2 -- cpu/arm_cortexa8/omap3/config.mk | 36 ------------------------------------ 2 files changed, 38 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Never underestimate the power of human stupidity when it comes to using technology they don't understand.