include/config_cmd_default.h cleanup

PATCH New Prafulla Wadaskar 6 participants 37 messages Jul 16, 2009 – Aug 21, 2009

Subsystems (3)

Network drivers Kbuild Ethernet PHY

lore

Share & tools

lore

Prafulla Wadaskar

author

2009-07-16 15:27 UTC #0 lore raw

PATCH 1/6 include/config_cmd_default.h cleanup

arranged configurations in alphabetical order CONFIG_CMD_FLASH moved under ifndef CONFIG_SYS_NO_FLASH

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 include/config_cmd_default.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

include/config_cmd_default.h +3 -3

index 0376e44..a5d87a6 100644
@@ -20,14 +20,13 @@
 #define CONFIG_CMD_BOOTD	/* bootd			*/
 #define CONFIG_CMD_CONSOLE	/* coninfo			*/
 #define CONFIG_CMD_ECHO		/* echo arguments		*/
-#define CONFIG_CMD_SAVEENV	/* saveenv			*/
-#define CONFIG_CMD_FLASH	/* flinfo, erase, protect	*/
 #define CONFIG_CMD_FPGA		/* FPGA configuration Support	*/
 #define CONFIG_CMD_IMI		/* iminfo			*/
+#define CONFIG_CMD_ITEST	/* Integer (and string) test	*/
 #ifndef CONFIG_SYS_NO_FLASH
+#define CONFIG_CMD_FLASH	/* flinfo, erase, protect	*/
 #define CONFIG_CMD_IMLS		/* List all found images	*/
 #endif
-#define CONFIG_CMD_ITEST	/* Integer (and string) test	*/
 #define CONFIG_CMD_LOADB	/* loadb			*/
 #define CONFIG_CMD_LOADS	/* loads			*/
 #define CONFIG_CMD_MEMORY	/* md mm nm mw cp cmp crc base loop mtest */

@@ -35,6 +34,7 @@
 #define CONFIG_CMD_NET		/* bootp, tftpboot, rarpboot	*/
 #define CONFIG_CMD_NFS		/* NFS support			*/
 #define CONFIG_CMD_RUN		/* run command in env variable	*/
+#define CONFIG_CMD_SAVEENV	/* saveenv			*/
 #define CONFIG_CMD_SETGETDCR	/* DCR support on 4xx		*/
 #define CONFIG_CMD_SOURCE	/* "source" command support	*/
 #define CONFIG_CMD_XIMG		/* Load part of Multi Image	*/

Signature · 1 line

1.5.3.3

Prafulla Wadaskar

author

2009-07-16 15:28 UTC #1 lore raw

PATCH v7 2/6 Marvell Sheevaplug Board support

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support

This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND
5. Enabled USB PHY init for kernel need
6. Boot from USB supported

Note: to boot Kirkwood kernel with USB support,
you should add "usb start" in the boot sequence

Signed-off-by Prafulla Wadaskar <[email protected]>

---
Change log:
v2: updated as per feedback for v1

v3: updated as per feedback for v2

v4: removed PHY driver dependency, coded in sheevaplug.c

v5: USB support added

v6: config_cmd_default.h used in board config

v7: sheevaplug.h alligned as per cleanup in config_cmd_default.h

 MAINTAINERS                           |    4 +
 MAKEALL                               |    1 +
 Makefile                              |    4 +-
 board/Marvell/sheevaplug/Makefile     |   51 +++++++++
 board/Marvell/sheevaplug/config.mk    |   25 ++++
 board/Marvell/sheevaplug/sheevaplug.c |  155 ++++++++++++++++++++++++++
 board/Marvell/sheevaplug/sheevaplug.h |   41 +++++++
 include/configs/sheevaplug.h          |  195 +++++++++++++++++++++++++++++++++
 8 files changed, 475 insertions(+), 1 deletions(-)
 create mode 100644 board/Marvell/sheevaplug/Makefile
 create mode 100644 board/Marvell/sheevaplug/config.mk
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.c
 create mode 100644 board/Marvell/sheevaplug/sheevaplug.h
 create mode 100644 include/configs/sheevaplug.h

MAINTAINERS +4 -0

index 705bac5..2f3b63c 100644
@@ -673,6 +673,10 @@ Hugo Villeneuve <[email protected]>
 
 	SFFSDR		ARM926EJS
 
+Prafulla Wadaskar <[email protected]>
+
+	sheevaplug	ARM926EJS (Kirkwood SoC)
+
 Richard Woodruff <[email protected]>
 
 	omap2420h4	ARM1136EJS

MAKEALL +1 -0

index 41f1445..e987d4a 100755
@@ -522,6 +522,7 @@ LIST_ARM9="			\
 	omap730p2		\
 	sbc2410x		\
 	scb9328			\
+	sheevaplug		\
 	smdk2400		\
 	smdk2410		\
 	trab			\

Makefile +3 -1

index d427760..a66c4c7 100644
@@ -2924,6 +2924,9 @@ sbc2410x_config: unconfig
 scb9328_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t scb9328 NULL imx
 
+sheevaplug_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 smdk2400_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t smdk2400 samsung s3c24x0

@@ -3168,7 +3171,6 @@ omap2420h4_config	: unconfig
 qong_config		: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 qong davedenx mx31
 
-
 #########################################################################
 ## ARM1176 Systems
 #########################################################################

board/Marvell/sheevaplug/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/sheevaplug/config.mk new file +25 -0

new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000

board/Marvell/sheevaplug/sheevaplug.c new file +155 -0

155 lines not on this page · raw message

board/Marvell/sheevaplug/sheevaplug.h new file +41 -0

41 lines not on this page · raw message

include/configs/sheevaplug.h new file +195 -0

195 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Prafulla Wadaskar

author

2009-07-16 15:28 UTC #2 lore raw

PATCH v13 3/6 Marvell MV88F6281GTW_GE Board support

This is Marvell's 88F6281_A0 based custom board developed for wireless access point product

This patch is tested for-
1. Boot from DRAM/SPI flash/NFS
2. File transfer using tftp and loadb
3. SPI flash read/write/erase
4. Booting Linux kernel and RFS from SPI flash
5. Boot from USB supported

Reviewed-by Ronen Shitrit <[email protected]>

Signed-off-by Prafulla Wadaskar <[email protected]>

---
Change log
v2: updated as per first review comments debug_prints updated to debug

v3: updaed as per review comments for v2 added mv88f6281gtw_ge.h file removed BITxx macros

v4: updated as per review comments for v3 arch_misc_init support is added and used from kirkwood

v5: updated as per review comments for v4 CONFIG_MACH_MV88F6281GTW_GE added more comments added and serial configuration removed from mv88f6281gtw_ge.c

V6: clean switch configuration using netdev.h

v7: Marvell copyright removed from u-boot.lds Maintainer added for this board

v8: u-boot.lds removed
finetuned for cosmetic and switch related changes

v9: new mpp configuration used
CONFIG_ARCH_LOWLEVEL_INIT defination removed

v10: CONFIG_ENV_SIZE set to 4kb
CONFIG_SYS_MALLOC_LEN set to 128kb

v11: updated as per feedback for v10
copyright statement corrected
mtdparts definition corrected
all code lines checked for max len 80 chars

v12: config_cmd_default.h used in board config
entry in MAINTAINERS list added

v13: mv88f6281gtw_ge.h allgined as per cleanup in config_cmd_default.h

 MAINTAINERS                                     |    1 +
 MAKEALL                                         |    1 +
 Makefile                                        |    3 +
 board/Marvell/mv88f6281gtw_ge/Makefile          |   51 ++++++
 board/Marvell/mv88f6281gtw_ge/config.mk         |   25 +++
 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c |  141 ++++++++++++++++
 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h |   36 ++++
 include/configs/mv88f6281gtw_ge.h               |  200 +++++++++++++++++++++++
 8 files changed, 458 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/mv88f6281gtw_ge/Makefile
 create mode 100644 board/Marvell/mv88f6281gtw_ge/config.mk
 create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c
 create mode 100644 board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h
 create mode 100644 include/configs/mv88f6281gtw_ge.h

MAINTAINERS +1 -0

index 2f3b63c..76268b4 100644
@@ -675,6 +675,7 @@ Hugo Villeneuve <[email protected]>
 
 Prafulla Wadaskar <[email protected]>
 
+	mv88f6281gtw_ge	ARM926EJS (Kirkwood SoC)
 	sheevaplug	ARM926EJS (Kirkwood SoC)
 
 Richard Woodruff <[email protected]>

MAKEALL +1 -0

index e987d4a..4e1f431 100755
@@ -510,6 +510,7 @@ LIST_ARM9="			\
 	cp946es			\
 	cp966			\
 	lpd7a400		\
+	mv88f6281gtw_ge		\
 	mx1ads			\
 	mx1fs2			\
 	netstar			\

Makefile +3 -0

index a66c4c7..b4d8c80 100644
@@ -2853,6 +2853,9 @@ lpd7a400_config \
 lpd7a404_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm lh7a40x lpd7a40x
 
+mv88f6281gtw_ge_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 mx1ads_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t mx1ads NULL imx

board/Marvell/mv88f6281gtw_ge/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/mv88f6281gtw_ge/config.mk new file +25 -0

new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000

board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c new file +141 -0

141 lines not on this page · raw message

board/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.h new file +36 -0

new file mode 100644
index 0000000..65b925d
@@ -0,0 +1,36 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __MV88F6281GTW_GE_H
+#define __MV88F6281GTW_GE_H
+
+#define MV88F6281GTW_GE_OE_LOW		(~((1 << 7) | (1 << 12) \
+					  |(1 << 20) | (1 << 21)))	/*enable GLED,RLED */
+#define MV88F6281GTW_GE_OE_HIGH		(~((1 << 4)|(1 << 6)|(1 << 7)|(1 << 12) \
+					  |(1 << 13)|(1 << 16)|(1 << 17)))
+#define MV88F6281GTW_GE_OE_VAL_LOW	(1 << 20)	/*make GLED on */
+#define MV88F6281GTW_GE_OE_VAL_HIGH	((1 << 6)|(1 << 13)|(1 << 16)|(1 << 17))
+
+
+#endif /* __MV88F6281GTW_GE_H */

include/configs/mv88f6281gtw_ge.h new file +200 -0

200 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Prafulla Wadaskar

author

2009-07-16 15:28 UTC #3 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

With these fixes, this driver works properly for multi chip addressging mode

Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection- fixed
3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
4. invalid data read ptr was refered for RD_PHY in case of multichip addressing mode -fixed

The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 drivers/net/phy/mv88e61xx.c |   18 +++++++++---------
 drivers/net/phy/mv88e61xx.h |    2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

drivers/net/phy/mv88e61xx.c +9 -9

index ec47286..29630f5 100644
@@ -36,7 +36,7 @@
  * By default single chip mode is configured
  * multichip mode operation can be configured in board header
  */
-static int mv88e61xx_busychk_multic(u32 devaddr)
+static int mv88e61xx_busychk_multic(char *name, u32 devaddr)
 {
 	u32 reg = 0;
 	u32 timeout = MV88E61XX_PHY_TIMEOUT;

@@ -58,11 +58,11 @@ static void mv88e61xx_wr_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 data)
 	u32 mii_dev_addr;
 
 	/* command to read PHY dev address */
-	if (!miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {
+	if (miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {
 		printf("Error..could not read PHY dev address\n");
 		return;
 	}
-	mv88e61xx_busychk_multic(mii_dev_addr);
+	mv88e61xx_busychk_multic(name, mii_dev_addr);
 	/* Write data to Switch indirect data register */
 	miiphy_write(name, mii_dev_addr, 0x1, data);
 	/* Write command to Switch indirect command register (write) */

@@ -77,18 +77,18 @@ static void mv88e61xx_rd_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 * data)
 	u32 mii_dev_addr;
 
 	/* command to read PHY dev address */
-	if (!miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {
+	if (miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {
 		printf("Error..could not read PHY dev address\n");
 		return;
 	}
-	mv88e61xx_busychk_multic(mii_dev_addr);
+	mv88e61xx_busychk_multic(name, mii_dev_addr);
 	/* Write command to Switch indirect command register (read) */
 	miiphy_write(name, mii_dev_addr, 0x0,
-		     reg_ofs | (phy_adr << 5) | (1 << 10) | (1 << 12) | (1 <<
+		     reg_ofs | (phy_adr << 5) | (1 << 11) | (1 << 12) | (1 <<
 									 15));
-	mv88e61xx_busychk_multic(mii_dev_addr);
+	mv88e61xx_busychk_multic(name, mii_dev_addr);
 	/* Read data from Switch indirect data register */
-	miiphy_read(name, mii_dev_addr, 0x1, (u16 *) & data);
+	miiphy_read(name, mii_dev_addr, 0x1, data);
 }
 #endif /* CONFIG_MV88E61XX_MULTICHIP_ADRMODE */

@@ -212,7 +212,7 @@ static int mv88e61xx_busychk(char *name)
 			printf("SMI busy timeout\n");
 			return -1;
 		}
-	} while (reg & 1 << 28);	/* busy mask */
+	} while (reg & 1 << 15);	/* busy mask */
 	return 0;
 }

drivers/net/phy/mv88e61xx.h +1 -1

index 4279464..57762b6 100644
@@ -49,7 +49,7 @@
 #define MV88E61XX_ADDR_OFST		5
 
 #ifdef CONFIG_MV88E61XX_MULTICHIP_ADRMODE
-static int mv88e61xx_busychk_multic(u32 devaddr);
+static int mv88e61xx_busychk_multic(char *name, u32 devaddr);
 static void mv88e61xx_wr_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 data);
 static void mv88e61xx_rd_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 * data);
 #define WR_PHY mv88e61xx_wr_phy

Signature · 1 line

1.5.3.3

Prafulla Wadaskar

author

2009-07-16 15:28 UTC #4 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-

Through this patch Auto negotiation can be disabled and desired interface speed can be configured

This patch is tested on RD6281A Kirkwood board

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

drivers/net/kirkwood_egiga.c +24 -0

index 3c5db19..1dfd567 100644
@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be configured
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII
+#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_1000);
+#elif (CONFIG_PHY_SPEED == _100BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_100);
+#elif (CONFIG_PHY_SPEED == _10BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_10);
+#endif /* CONFIG_PHY_SPEED == _10BASET */
+#else
 	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE);
+#endif /* CONFIG_DIS_AUTO_NEG_SPEED_GMII */
+
 	/* Disable port initially */
 	KWGBEREG_BITS_SET(regs->psc0, KWGBE_SERIAL_PORT_EN);

Signature · 1 line

1.5.3.3

Dieter Kiermaier

2009-07-16 14:45 UTC #5 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Hi Prafulla, hi Marvell engineers,

Quoted 4 lines

By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-

do you have some information why auto negotiation doesn't work on RD6281A? I'm working on custom hardware and don't want to do the same mistake :)

Many thanks,
Dieter

Quoted 47 lines

Through this patch Auto negotiation can be disabled and desired interface speed can be configured

This patch is tested on RD6281A Kirkwood board

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

drivers/net/kirkwood_egiga.c +24 -0

index 3c5db19..1dfd567 100644
@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be configured
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII
+#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_1000);
+#elif (CONFIG_PHY_SPEED == _100BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_100);
+#elif (CONFIG_PHY_SPEED == _10BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_10);
+#endif /* CONFIG_PHY_SPEED == _10BASET */
+#else
 	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE);
+#endif /* CONFIG_DIS_AUTO_NEG_SPEED_GMII */
+
 	/* Disable port initially */
 	KWGBEREG_BITS_SET(regs->psc0, KWGBE_SERIAL_PORT_EN);

Prafulla Wadaskar

author

2009-07-16 15:45 UTC #6 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Quoted 14 lines

-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Thursday, July 16, 2009 8:15 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support
Hi Prafulla, hi Marvell engineers,

Quoted 7 lines

Quoted 1 line
By default Auto Negotiation is enabled for interface speed
but on some
Quoted 2 lines
platforms like RD6281A it does not work.
If you want to forced program it to desired speed, this patch helps-
do you have some information why auto negotiation doesn't work on RD6281A?

Hi Dieter
I do not have good answer for this with me :-(
On RD6281A I thought Auto negotiation should work, but it did not.
During my debugging, I performed several trial and error methods and forcing PHY interface speed to 1000BPs worked for me.

So I exposed this configuration through this patch.

I will certainly look for better answer for you

Regards..
Prafulla . .

Quoted 58 lines

I'm working on custom hardware and don't want to do the same mistake :)

Many thanks,
Dieter

Quoted 16 lines

Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/drivers/net/kirkwood_egiga.c index 3c5db19..1dfd567 100644

drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 421

Quoted 7 lines

drivers/net/kirkwood_egiga.c +4 -0

@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be

configured

Quoted 23 lines

drivers/net/kirkwood_egiga.c +19 -0

+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII #if (!defined 
+(CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_1000);
+#elif (CONFIG_PHY_SPEED == _100BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_100);
+#elif (CONFIG_PHY_SPEED == _10BASET)
+	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE
+		| KWGBE_DIS_AUTO_NEG_SPEED_GMII
+		| KWGBE_SET_GMII_SPEED_TO_10_100
+		| KWGBE_SET_MII_SPEED_TO_10);
+#endif /* CONFIG_PHY_SPEED == _10BASET */ #else
 	KWGBEREG_WR(regs->psc0, PORT_SERIAL_CONTROL_VALUE);
+#endif /* CONFIG_DIS_AUTO_NEG_SPEED_GMII */
+
 	/* Disable port initially */
 	KWGBEREG_BITS_SET(regs->psc0, KWGBE_SERIAL_PORT_EN);

Prafulla Wadaskar

author

2009-07-16 15:28 UTC #7 lore raw

PATCH 6/6 Marvell RD6281A Board support

In reply to Prafulla Wadaskar

This is Marvell's 88F6281_A0 based reference design board

This patch is tested for-
1. Boot from DRAM/NAND flash/NFS
2. File transfer using tftp and loadb
3. NAND flash read/write/erase

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 MAINTAINERS                     |    1 +
 MAKEALL                         |    1 +
 Makefile                        |    3 +
 board/Marvell/rd6281a/Makefile  |   51 ++++++++++
 board/Marvell/rd6281a/config.mk |   25 +++++
 board/Marvell/rd6281a/rd6281a.c |  179 +++++++++++++++++++++++++++++++++
 board/Marvell/rd6281a/rd6281a.h |   41 ++++++++
 include/configs/rd6281a.h       |  209 +++++++++++++++++++++++++++++++++++++++
 8 files changed, 510 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/rd6281a/Makefile
 create mode 100644 board/Marvell/rd6281a/config.mk
 create mode 100644 board/Marvell/rd6281a/rd6281a.c
 create mode 100644 board/Marvell/rd6281a/rd6281a.h
 create mode 100644 include/configs/rd6281a.h

MAINTAINERS +1 -0

index 76268b4..ff587e1 100644
@@ -676,6 +676,7 @@ Hugo Villeneuve <[email protected]>
 Prafulla Wadaskar <[email protected]>
 
 	mv88f6281gtw_ge	ARM926EJS (Kirkwood SoC)
+	rd6281a		ARM926EJS (Kirkwood SoC)
 	sheevaplug	ARM926EJS (Kirkwood SoC)
 
 Richard Woodruff <[email protected]>

MAKEALL +1 -0

index 4e1f431..3d7e4da 100755
@@ -521,6 +521,7 @@ LIST_ARM9="			\
 	omap1610inn		\
 	omap5912osk		\
 	omap730p2		\
+	rd6281a			\
 	sbc2410x		\
 	scb9328			\
 	sheevaplug		\

Makefile +3 -0

index b4d8c80..3a011c8 100644
@@ -2921,6 +2921,9 @@ omap730p2_cs3boot_config :	unconfig
 	fi;
 	@$(MKCONFIG) -a $(call xtract_omap730p2,$@) arm arm926ejs omap730p2 NULL omap
 
+rd6281a_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 sbc2410x_config: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t sbc2410x NULL s3c24x0

board/Marvell/rd6281a/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/rd6281a/config.mk new file +25 -0

new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000

board/Marvell/rd6281a/rd6281a.c new file +179 -0

179 lines not on this page · raw message

board/Marvell/rd6281a/rd6281a.h new file +41 -0

41 lines not on this page · raw message

include/configs/rd6281a.h new file +209 -0

209 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Jean-Christophe PLAGNIOL-VILLARD

2009-07-18 18:48 UTC #8 lore raw

PATCH 6/6 Marvell RD6281A Board support

Quoted 27 lines

include/configs/rd6281a.h new file +21 -0

new file mode 100644
index 0000000..065e4aa
@@ -0,0 +1,209 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,

include/configs/rd6281a.h line 31

Quoted 10 lines

include/configs/rd6281a.h new file +10 -0

+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_RD6281A_H
+#define _CONFIG_RD6281A_H
+
+/*
+ * Version number information
+ */
+#define CONFIG_IDENT_STRING	"\nMarvell-Sheevaplug"

???
Sheevaplug?

Best Regards,
J.

Prafulla Wadaskar

author

2009-07-19 04:50 UTC #9 lore raw

PATCH 6/6 Marvell RD6281A Board support

Quoted 36 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Sunday, July 19, 2009 12:18 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 6/6] Marvell RD6281A Board support
Review
Quoted 1 line
(quoted diff) +0 -0
b/include/configs/rd6281a.h new
Quoted 13 lines
file mode 100644 index 0000000..065e4aa
include/configs/rd6281a.h new file +9 -0
@@ -0,0 +1,209 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
include/configs/rd6281a.h line 19
Quoted 10 lines
include/configs/rd6281a.h new file +10 -0
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General 
Public License

Quoted 14 lines

include/configs/rd6281a.h line 31

Quoted 12 lines

include/configs/rd6281a.h new file +12 -0

+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_RD6281A_H
+#define _CONFIG_RD6281A_H
+
+/*
+ * Version number information
+ */
+#define CONFIG_IDENT_STRING	"\nMarvell-Sheevaplug"

???
Sheevaplug?

Sorry.. I observed this after git-send :-) , patch already reposted
Reference: http://lists.denx.de/pipermail/u-boot/2009-July/056438.html

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

Jean-Christophe PLAGNIOL-VILLARD

2009-07-18 18:43 UTC #10 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

In reply to Prafulla Wadaskar

Quoted 20 lines · Prafulla Wadaskar

By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
drivers/net/kirkwood_egiga.c +0 -0
index 3c5db19..1dfd567 100644

drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 424

Quoted 10 lines

drivers/net/kirkwood_egiga.c +7 -0

@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be configured
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII
+#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))

Could you find a better config taht _1000BASET & co

Best Regards,
J.

Prafulla Wadaskar

author

2009-07-19 04:54 UTC #11 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Quoted 40 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Sunday, July 19, 2009 12:14 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support
Quoted 1 line · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed
but on some
Quoted 18 lines
platforms like RD6281A it does not work.
If you want to forced program it to desired speed, this patch helps-
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/drivers/net/kirkwood_egiga.c index 3c5db19..1dfd567 100644
drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 421
Quoted 7 lines
drivers/net/kirkwood_egiga.c +4 -0
@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be 
configured

Quoted 4 lines

drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 424
Quoted 3 lines
drivers/net/kirkwood_egiga.c +3 -0
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII #if (!defined 
+(CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
Could you find a better config taht _1000BASET & co

Hi Jean,
I have reused it from include/miiphy.h which is relevant too.

Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

Ben Warren

2009-07-21 06:22 UTC #12 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

In reply to Jean-Christophe PLAGNIOL-VILLARD

Quoted 26 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 24 lines · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
drivers/net/kirkwood_egiga.c +1 -0
index 3c5db19..1dfd567 100644
@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*

Quoted 10 lines

drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 445
Quoted 7 lines
drivers/net/kirkwood_egiga.c +6 -0
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be configured
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII
+#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
 
Could you find a better config taht _1000BASET & co

Global configs for this type of thing are a bad idea (what if you want one interface @ 1000 and one @ 100? I guess this will have to do for now, but let's ensure that it's temporary.

Quoted 2 lines

Best Regards,
J.

regards,
Ben

Wolfgang Denk

2009-07-21 07:39 UTC #13 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Dear Ben Warren,

Quoted 3 lines · In message <[email protected]> you wrote:

Quoted 3 lines
Quoted 3 lines
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work.

What exactly is the reason that it doesn't work?

Is it some deficiency of the board hardware that always exaists, or a problem only present in combination with certain switches. or what exactly?

Quoted 5 lines

Quoted 5 lines
Quoted 5 lines
If you want to forced program it to desired speed, this patch helps-
Through this patch Auto negotiation can be disabled and desired interface speed can be configured

I'm not sure if it's really a good idea to do hard-code this as a compile-time option.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
+#if (!defined (CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
Could you find a better config taht _1000BASET & co
Global configs for this type of thing are a bad idea (what if you want one interface @ 1000 and one @ 100? I guess this will have to do for now, but let's ensure that it's temporary.

I am not convinced that such a patch should go in at all.

Foir the boards that really need such a configuration, it should be possible to set this for example using a standard "mii" command as part of a "preboot" environment setting.

This way the user can disable it at runtime (if he doesn;t need it), and we don't need to change the code.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Go to Heaven for the climate, Hell for the company."    - Mark Twain

Prafulla Wadaskar

author

2009-07-21 19:08 UTC #14 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

In reply to Ben Warren

Quoted 50 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Tuesday, July 21, 2009 11:53 AM
To: Jean-Christophe PLAGNIOL-VILLARD
Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas Pitre; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support
Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 3 lines · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work.
If you want to forced program it to desired speed, this
patch helps-
Quoted 11 lines
Quoted 11 lines
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/kirkwood_egiga.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)
Quoted 12 lines
drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 421
Quoted 12 lines
(quoted diff) +0 -0
b/drivers/net/kirkwood_egiga.c index 3c5db19..1dfd567 100644
drivers/net/kirkwood_egiga.c +4 -0
@@ -415,7 +415,31 @@ static int kwgbe_init(struct eth_device *dev)
 	/* Assign port configuration and command. */
 	KWGBEREG_WR(regs->pxc, PRT_CFG_VAL);
 	KWGBEREG_WR(regs->pxcx, PORT_CFG_EXTEND_VALUE);
+	/*
+	 * Forced 10/100/1000BASE-T interface speed configuration
+	 * By default Auto Negotiation of interface speed is enabled
+	 * This can be forced disabled and desired speed can be 
configured
Quoted 7 lines
drivers/net/kirkwood_egiga.c static int kwgbe_init(struct eth_device *dev) · line 445
Quoted 4 lines
drivers/net/kirkwood_egiga.c +3 -0
+	 */
+#ifdef CONFIG_DIS_AUTO_NEG_SPEED_GMII #if (!defined 
+(CONFIG_PHY_SPEED) || (CONFIG_PHY_SPEED == _1000BASET))
 
Could you find a better config taht _1000BASET & co

Quoted 3 lines

Global configs for this type of thing are a bad idea (what if you want one interface @ 1000 and one @ 100? I guess this will have to do for now, but let's ensure that it's temporary.

I agree. I will find better way to configure this stuff.

Regards..
Prafulla ..

Quoted 7 lines

Quoted 3 lines
Best Regards,
J.
regards,
Ben

Ben Warren

Applied

2009-07-21 06:51 UTC #15 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

In reply to Prafulla Wadaskar

Prafulla,

Quoted 5 lines · Prafulla Wadaskar

By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-

Quoted 7 lines

Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---

Applied to net repo.

thanks,
Ben

Wolfgang Denk

2009-07-21 07:41 UTC #16 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Dear Ben Warren,

Quoted 7 lines · In message <[email protected]> you wrote:

Quoted 5 lines · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-

Quoted 8 lines

Quoted 7 lines
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---
Applied to net repo.

Please reconsider - see my previous comment. [Sorry it came so late.]

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're too beautiful to ignore.  Too much woman.
	-- Kirk to Yeoman Rand, "The Enemy Within", stardate unknown

Ben Warren

2009-07-21 07:43 UTC #17 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Quoted 19 lines · Wolfgang Denk

Dear Ben Warren,
Quoted 15 lines · In message <[email protected]> you wrote:
Quoted 13 lines · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work. If you want to forced program it to desired speed, this patch helps-
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Signed-off-by Prafulla Wadaskar <[email protected]>
---

Quoted 10 lines

Quoted 2 lines
Applied to net repo.
Please reconsider - see my previous comment. [Sorry it came so late.]
Best regards,
Wolfgang Denk

No problem. I assumed it was a chip erratum but should have looked closer. Let's wait for Prafulla's response.

regards,
Ben

Prafulla Wadaskar

author

2009-07-21 19:01 UTC #18 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Quoted 38 lines

-----Original Message-----
From: Ben Warren [mailto:biggerbadderben at gmail.com]
Sent: Tuesday, July 21, 2009 1:14 PM
To: Wolfgang Denk
Cc: Prafulla Wadaskar; Manas Saksena; Ronen Shitrit; Nicolas Pitre; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 5/6] net: Kirkwood_egiga: forced interface speed config support
Quoted 9 lines · Wolfgang Denk
Dear Ben Warren,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines · Prafulla Wadaskar
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work.
If you want to forced program it to desired speed, this
patch helps-
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Prafulla Wadaskar <[email protected]>
---
Applied to net repo.
Please reconsider - see my previous comment. [Sorry it came
so late.]
Quoted 1 line

Quoted 7 lines

Quoted 5 lines
Best regards,
Wolfgang Denk
No problem. I assumed it was a chip erratum but should have looked closer. Let's wait for Prafulla's response.

Ideally auto negotiation must work, but :-(
I don't think this is not for SoC/PHY erratum since both are working okay with other boards. Only the difference is on RD6281A the multichip mode is used,
I am discovering why it is not working.

Meanwhile this patch does not harm anything, it enables RD6281A usecase We can undo it latter if I could positively discover the fix ;-D

Regards..
Prafulla . .

Quoted 4 lines

regards,
Ben

Jean-Christophe PLAGNIOL-VILLARD

2009-07-21 19:20 UTC #19 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

Quoted 6 lines

Quoted 6 lines
Quoted 4 lines
Wolfgang Denk
No problem. I assumed it was a chip erratum but should have looked closer. Let's wait for Prafulla's response.

Quoted 7 lines

Ideally auto negotiation must work, but :-(
I don't think this is not for SoC/PHY erratum since both are working okay with other boards. Only the difference is on RD6281A the multichip mode is used,
I am discovering why it is not working.
Meanwhile this patch does not harm anything, it enables RD6281A usecase We can undo it latter if I could positively discover the fix ;-D

I agree that need to be debug and fix
but until Prafulla will found the bug, it will a least make the network working

maybe we could forced it at the runtime instead

Best Regards,
J.

Lennert Buytenhek

2009-07-21 19:32 UTC #20 lore raw

PATCH 5/6 net: Kirkwood_egiga: forced interface speed config support

In reply to Prafulla Wadaskar

Quoted 24 lines · Prafulla Wadaskar

Quoted 24 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
By default Auto Negotiation is enabled for interface speed but on some platforms like RD6281A it does not work.
If you want to forced program it to desired speed, this
patch helps-
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Through this patch Auto negotiation can be disabled and desired interface speed can be configured
This patch is tested on RD6281A Kirkwood board
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Prafulla Wadaskar <[email protected]>
---
Applied to net repo.
Please reconsider - see my previous comment. [Sorry it came
so late.]
Quoted 6 lines
Best regards,
Wolfgang Denk

Quoted 8 lines

Quoted 2 lines
No problem. I assumed it was a chip erratum but should have looked closer. Let's wait for Prafulla's response.
Ideally auto negotiation must work, but :-(
I don't think this is not for SoC/PHY erratum since both are working okay with other boards.
Only the difference is on RD6281A the multichip mode is used, I am discovering why it is not working.

Isn't it just because on the RD6281A, the first ethernet MAC of the CPU is connected to an ethernet switch chip instead of an ethernet PHY, and therefore there is no negotiation to be done? (The second MAC is connected to a PHY directly, so that one should just use autoneg.)

Even on the RD6281Z, we should just force the ethernet MAC to a fixed speed/duplex, since even though PHY polling might work there, we'll be talking to the PHY corresponding to the first switch port, which means that you might not be able to tftp from the second switch port or so if there's nothing plugged into the first one.

FWIW, the linux kernel port also forces 1000/full on the CPU MACs where a switch chip is connected. On those CPU MACs where there is a switch chip connected, the (R)(G)MII interface becomes purely a bus to transport packets into and out of the crossbar, one that is always up.

Ben Warren

Applied

2009-07-21 06:52 UTC #21 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

In reply to Prafulla Wadaskar

Prafulla,

Quoted 10 lines · Prafulla Wadaskar

With these fixes, this driver works properly for multi chip addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection- fixed
3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
4. invalid data read ptr was refered for RD_PHY in case of multichip addressing mode -fixed

Quoted 5 lines

The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it
Signed-off-by Prafulla Wadaskar <[email protected]>
---

Applied to net repo.

thanks,
Ben

Wolfgang Denk

2009-08-10 08:09 UTC #22 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 10 lines · In message <[email protected]> you wrote:

With these fixes, this driver works properly for multi chip addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection- fixed
3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
4. invalid data read ptr was refered for RD_PHY in case of multichip addressing mode -fixed

Quoted 8 lines

The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/phy/mv88e61xx.c |   18 +++++++++---------
 drivers/net/phy/mv88e61xx.h |    2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

This patch causes compiler warnings:

mv88e61xx.c: In function 'mv88e61xx_busychk_multic':
mv88e61xx.c:46: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c: In function 'mv88e61xx_wr_phy':
mv88e61xx.c:61: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c:57: warning: unused variable 'reg'
mv88e61xx.c: In function 'mv88e61xx_rd_phy':
mv88e61xx.c:80: warning: passing argument 4 of 'miiphy_read' from incompatible pointer type mv88e61xx.c:76: warning: unused variable 'reg'

(when building for the rd6281a board using ELDK 4.2, i. e. gcc-4.2.2)

Also, the rd6281a board throws this warning:

nand_util.c:45:2: warning: #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output!

Could you please provide fixes?

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"One thing they don't tell you about doing  experimental  physics  is
that sometimes you must work under adverse conditions... like a state
of sheer terror."                                    - W. K. Hartmann

Wolfgang Denk

2009-08-10 08:25 UTC #23 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

Dear Prafulla Wadaskar,

Quoted 10 lines · In message <[email protected]> you wrote:

With these fixes, this driver works properly for multi chip addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed
2. PHY dev address error detection- fixed
3. wrong busy bit was refered in function mv88e61xx_busychk -fixed
4. invalid data read ptr was refered for RD_PHY in case of multichip addressing mode -fixed

Quoted 8 lines

The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/phy/mv88e61xx.c |   18 +++++++++---------
 drivers/net/phy/mv88e61xx.h |    2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

With ELDK 4.1 (gcc 4.0.0) I also get this compiler warning:

mv88e61xx.c: In function 'mv88e61xx_switch_initialize':
mv88e61xx.c:346: warning: 'idstr' may be used uninitialized in this function

when building for the mv88f6281gtw_ge board.

This looks reasonabme, as

361 if (reg == 0x1610)
362 idstr = "88E6161";
363 if (reg == 0x1650)
364 idstr = "88E6165";
365 if (reg == 0x1210) {

366                 idstr = "88E6123";
367                 /* ports 2,3,4 not available */
368                 swconfig->ports_enabled &= 0x023;

369 }

may ideed leave "idstr" uninitialized; you may want to change this into a switch() construct and add a default: case.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Always try to do things in chronological order; it's  less  confusing
that way.

Prafulla Wadaskar

author

2009-08-10 08:59 UTC #24 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

Quoted 51 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Monday, August 10, 2009 1:56 PM
To: Prafulla Wadaskar
Cc: Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ben Warren; u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH 4/6] net: phy: bugfixes:
mv88E61xx multichip addressing support
Dear Prafulla Wadaskar,
In message
Quoted 6 lines · <[email protected]> you wrote:
With these fixes, this driver works properly for multi chip addressging mode
Bugfixes:
1. Build error fixed for function mv88e61xx_busychk_multic-fixed 2. PHY dev address error detection- fixed 3. wrong busy bit
was refered
Quoted 4 lines
in function mv88e61xx_busychk -fixed 4. invalid data read ptr was refered for RD_PHY in case of
multichip addressing mode -fixed
Quoted 8 lines
The Multichip Address mode is tested with RD6281A board having MV88E6165 switch on it
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 drivers/net/phy/mv88e61xx.c |   18 +++++++++---------
 drivers/net/phy/mv88e61xx.h |    2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)
With ELDK 4.1 (gcc 4.0.0) I also get this compiler warning:
mv88e61xx.c: In function 'mv88e61xx_switch_initialize':
mv88e61xx.c:346: warning: 'idstr' may be used uninitialized in this function
when building for the mv88f6281gtw_ge board.
This looks reasonabme, as
361 if (reg == 0x1610)
362 idstr = "88E6161";
363 if (reg == 0x1650)
364 idstr = "88E6165";
365 if (reg == 0x1210) {

Quoted 7 lines

366                 idstr = "88E6123";
367                 /* ports 2,3,4 not available */
368                 swconfig->ports_enabled &= 0x023;
369 }
may ideed leave "idstr" uninitialized; you may want to change this into a switch() construct and add a default: case.

Thanks
Bugfix patch posted for this
Regards..
Prafulla . .

Quoted 12 lines

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: 
wd at denx.de Always try to do things in chronological order; 
it's  less  confusing that way.

Prafulla Wadaskar

author

2009-08-10 13:53 UTC #25 lore raw

PATCH 1/1 net: phy: bugfixes: mv88E61xx compiler warnings fixed

In reply to Wolfgang Denk

1. mv88E61xx driver compiler warnings fixed
2. idstr if-else statements changed to switch() construct and added default case too.
This fixed idstr may be uninitialized warning

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 drivers/net/phy/mv88e61xx.c |   23 ++++++++++++++---------
 1 files changed, 14 insertions(+), 9 deletions(-)

drivers/net/phy/mv88e61xx.c +14 -9

index 29630f5..3754e8b 100644
@@ -38,7 +38,7 @@
  */
 static int mv88e61xx_busychk_multic(char *name, u32 devaddr)
 {
-	u32 reg = 0;
+	u16 reg = 0;
 	u32 timeout = MV88E61XX_PHY_TIMEOUT;
 
 	/* Poll till SMIBusy bit is clear */

@@ -54,8 +54,7 @@ static int mv88e61xx_busychk_multic(char *name, u32 devaddr)
 
 static void mv88e61xx_wr_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 data)
 {
-	u16 reg;
-	u32 mii_dev_addr;
+	u16 mii_dev_addr;
 
 	/* command to read PHY dev address */
 	if (miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {

@@ -73,8 +72,7 @@ static void mv88e61xx_wr_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 data)
 
 static void mv88e61xx_rd_phy(char *name, u32 phy_adr, u32 reg_ofs, u16 * data)
 {
-	u16 reg;
-	u32 mii_dev_addr;
+	u16 mii_dev_addr;
 
 	/* command to read PHY dev address */
 	if (miiphy_read(name, 0xEE, 0xEE, &mii_dev_addr)) {

@@ -357,15 +355,22 @@ int mv88e61xx_switch_initialize(struct mv88e61xx_config *swconfig)
 	}
 
 	RD_PHY(name, MV88E61XX_PRT_OFST, PHY_PHYIDR2, &reg);
-	reg &= 0xfff0;
-	if (reg == 0x1610)
+	switch (reg &= 0xfff0) {
+	case 0x1610:
 		idstr = "88E6161";
-	if (reg == 0x1650)
+		break;
+	case 0x1650:
 		idstr = "88E6165";
-	if (reg == 0x1210) {
+		break;
+	case 0x1210:
 		idstr = "88E6123";
 		/* ports 2,3,4 not available */
 		swconfig->ports_enabled &= 0x023;
+		break;
+	default:
+		/* Could not detect switch id */
+		idstr = "88E61??";
+		break;
 	}
 
 	/* Port based VLANs configuration */

Signature · 1 line

1.5.3.3

Ben Warren

Applied

2009-08-10 21:54 UTC #26 lore raw

PATCH 1/1 net: phy: bugfixes: mv88E61xx compiler warnings fixed

Prafulla,

Quoted 7 lines · Prafulla Wadaskar

1. mv88E61xx driver compiler warnings fixed
2. idstr if-else statements changed to switch() construct and added default case too.
This fixed idstr may be uninitialized warning
Signed-off-by Prafulla Wadaskar <[email protected]>
---

Applied to net repo.

thanks,
Ben

Prafulla Wadaskar

author

2009-08-10 08:31 UTC #27 lore raw

PATCH 4/6 net: phy: bugfixes: mv88E61xx multichip addressing support

In reply to Wolfgang Denk

Quoted 18 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Monday, August 10, 2009 1:39 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek; Ben Warren; Jean-Christophe Plagniol-Villard
Subject: Re: [U-Boot] [PATCH 4/6] net: phy: bugfixes:
mv88E61xx multichip addressing support
Dear Prafulla Wadaskar,
In message
Quoted 2 lines · <[email protected]> you wrote:
With these fixes, this driver works properly for multi chip addressging mode

<snip..>

Quoted 4 lines

Also, the rd6281a board throws this warning:
nand_util.c:45:2: warning: #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output!

Patch posted for this
Regards..
Prafulla . .

Quoted 19 lines

Could you please provide fixes?

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 7 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: 
wd at denx.de "One thing they don't tell you about doing  
experimental  physics  is that sometimes you must work under 
adverse conditions... like a state
of sheer terror."                                    - W. K. Hartmann

Prafulla Wadaskar

author

2009-08-10 13:25 UTC #28 lore raw

PATCH 1/1 arm: rd6281a: Fixed NAND specific warning

In reply to Wolfgang Denk

It is recommended to define the macro CONFIG_SYS_64BIT_VSPRINTF for NAND specific warning removal, same is done in this patch

Signed-off-by Prafulla Wadaskar <[email protected]>

---
 include/configs/rd6281a.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

include/configs/rd6281a.h +1 -0

index 3d8e25c..3f4d42c 100644
@@ -107,6 +107,7 @@
 #define NAND_MAX_CHIPS			1
 #define CONFIG_SYS_NAND_BASE		0xD8000000	/* KW_DEFADR_NANDF */
 #define NAND_ALLOW_ERASE_ALL		1
+#define CONFIG_SYS_64BIT_VSPRINTF	/* needed for nand_util.c */
 #endif
 
 /*

Signature · 1 line

1.5.3.3

Wolfgang Denk

Applied

2009-08-21 21:26 UTC #29 lore raw

PATCH 1/1 arm: rd6281a: Fixed NAND specific warning

Dear Prafulla Wadaskar,

Quoted 7 lines · In message <[email protected]> you wrote:

It is recommended to define the macro CONFIG_SYS_64BIT_VSPRINTF for NAND specific warning removal, same is done in this patch
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 include/configs/rd6281a.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If something is different, it's either better or worse,  and  usually
both.                                                    - Larry Wall

Jean-Christophe PLAGNIOL-VILLARD

2009-07-18 18:40 UTC #30 lore raw

PATCH v13 3/6 Marvell MV88F6281GTW_GE Board support

In reply to Prafulla Wadaskar

Quoted 10 lines · Prafulla Wadaskar

This is Marvell's 88F6281_A0 based custom board developed for wireless access point product
This patch is tested for-
1. Boot from DRAM/SPI flash/NFS
2. File transfer using tftp and loadb
3. SPI flash read/write/erase
4. Booting Linux kernel and RFS from SPI flash
5. Boot from USB supported

Quoted 3 lines

Reviewed-by Ronen Shitrit <[email protected]>
Signed-off-by Prafulla Wadaskar <[email protected]>
---

applied to u-boot-arm

Best Regards,
J.

Prafulla Wadaskar

author

2009-07-19 04:55 UTC #31 lore raw

PATCH v13 3/6 Marvell MV88F6281GTW_GE Board support

Quoted 23 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Sunday, July 19, 2009 12:11 AM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH v13 3/6] Marvell MV88F6281GTW_GE Board support
Quoted 1 line · Prafulla Wadaskar
This is Marvell's 88F6281_A0 based custom board developed
for wireless
Quoted 9 lines
access point product
This patch is tested for-
1. Boot from DRAM/SPI flash/NFS
2. File transfer using tftp and loadb
3. SPI flash read/write/erase
4. Booting Linux kernel and RFS from SPI flash 5. Boot from USB supported

Quoted 4 lines

Quoted 3 lines
Reviewed-by Ronen Shitrit <[email protected]>
Signed-off-by Prafulla Wadaskar <[email protected]>
---
applied to u-boot-arm

Thanks Jean..
Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

Jean-Christophe PLAGNIOL-VILLARD

2009-07-18 17:41 UTC #32 lore raw

PATCH v7 2/6 Marvell Sheevaplug Board support

In reply to Prafulla Wadaskar

Quoted 12 lines · Prafulla Wadaskar

Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support
This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND
5. Enabled USB PHY init for kernel need
6. Boot from USB supported

Quoted 4 lines

Note: to boot Kirkwood kernel with USB support,
you should add "usb start" in the boot sequence
Signed-off-by Prafulla Wadaskar <[email protected]>

Applied to u-boot-arm

Best Regards,
J.

Prafulla Wadaskar

author

2009-07-19 04:56 UTC #33 lore raw

PATCH v7 2/6 Marvell Sheevaplug Board support

Quoted 22 lines

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Saturday, July 18, 2009 11:11 PM
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Manas Saksena; Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan Sarnaik; Lennert Buijtenhek
Subject: Re: [U-Boot] [PATCH v7 2/6] Marvell Sheevaplug Board support
Quoted 11 lines · Prafulla Wadaskar
Reference:
http://plugcomputer.org/
http://openplug.org/plugwiki/index.php/Das_U-boot_plug_support
This patch is tested for-
1. Boot from DRAM/NAND flash
2. File transfer using tftp
3. NAND flash read/write/erase
4. Linux kernel and RFS Boot from NAND 5. Enabled USB PHY init for kernel need 6. Boot from USB supported

Quoted 5 lines

Quoted 4 lines
Note: to boot Kirkwood kernel with USB support,
you should add "usb start" in the boot sequence
Signed-off-by Prafulla Wadaskar <[email protected]>
Applied to u-boot-arm

Thank you Jean..
Regards..
Prafulla . .

Quoted 4 lines

Best Regards,
J.

Wolfgang Denk

Applied

2009-07-17 21:26 UTC #34 lore raw

PATCH 1/6 include/config_cmd_default.h cleanup

In reply to Prafulla Wadaskar

Dear Prafulla Wadaskar,

Quoted 7 lines · In message <[email protected]> you wrote:

arranged configurations in alphabetical order CONFIG_CMD_FLASH moved under ifndef CONFIG_SYS_NO_FLASH
Signed-off-by Prafulla Wadaskar <[email protected]>
---
 include/config_cmd_default.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am a computer. I am dumber than any human and smarter than any  ad-
ministrator.

Prafulla Wadaskar

author

2009-07-16 15:32 UTC #35 lore raw

PATCH 6/6 Marvell RD6281A Board support

This is Marvell's 88F6281_A0 based reference design board

This patch is tested for-
1. Boot from DRAM/NAND flash/NFS
2. File transfer using tftp and loadb
3. NAND flash read/write/erase

Signed-off-by Prafulla Wadaskar <[email protected]>

---
Change log:
Sorry.. One commit was missing...

 MAINTAINERS                     |    1 +
 MAKEALL                         |    1 +
 Makefile                        |    3 +
 board/Marvell/rd6281a/Makefile  |   51 ++++++++++
 board/Marvell/rd6281a/config.mk |   25 +++++
 board/Marvell/rd6281a/rd6281a.c |  179 +++++++++++++++++++++++++++++++++++
 board/Marvell/rd6281a/rd6281a.h |   41 ++++++++
 include/configs/rd6281a.h       |  198 +++++++++++++++++++++++++++++++++++++++
 8 files changed, 499 insertions(+), 0 deletions(-)
 create mode 100644 board/Marvell/rd6281a/Makefile
 create mode 100644 board/Marvell/rd6281a/config.mk
 create mode 100644 board/Marvell/rd6281a/rd6281a.c
 create mode 100644 board/Marvell/rd6281a/rd6281a.h
 create mode 100644 include/configs/rd6281a.h

MAINTAINERS +1 -0

index 76268b4..ff587e1 100644
@@ -676,6 +676,7 @@ Hugo Villeneuve <[email protected]>
 Prafulla Wadaskar <[email protected]>
 
 	mv88f6281gtw_ge	ARM926EJS (Kirkwood SoC)
+	rd6281a		ARM926EJS (Kirkwood SoC)
 	sheevaplug	ARM926EJS (Kirkwood SoC)
 
 Richard Woodruff <[email protected]>

MAKEALL +1 -0

index 4e1f431..3d7e4da 100755
@@ -521,6 +521,7 @@ LIST_ARM9="			\
 	omap1610inn		\
 	omap5912osk		\
 	omap730p2		\
+	rd6281a			\
 	sbc2410x		\
 	scb9328			\
 	sheevaplug		\

Makefile +3 -0

index b4d8c80..3a011c8 100644
@@ -2921,6 +2921,9 @@ omap730p2_cs3boot_config :	unconfig
 	fi;
 	@$(MKCONFIG) -a $(call xtract_omap730p2,$@) arm arm926ejs omap730p2 NULL omap
 
+rd6281a_config: unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs $(@:_config=) Marvell kirkwood
+
 sbc2410x_config: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm920t sbc2410x NULL s3c24x0

board/Marvell/rd6281a/Makefile new file +51 -0

51 lines not on this page · raw message

board/Marvell/rd6281a/config.mk new file +25 -0

new file mode 100644
index 0000000..a4ea769
@@ -0,0 +1,25 @@
+#
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+# Written-by: Prafulla Wadaskar <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+# MA 02110-1301 USA
+#
+
+TEXT_BASE = 0x00600000

board/Marvell/rd6281a/rd6281a.c new file +179 -0

179 lines not on this page · raw message

board/Marvell/rd6281a/rd6281a.h new file +41 -0

41 lines not on this page · raw message

include/configs/rd6281a.h new file +198 -0

198 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Jean-Christophe PLAGNIOL-VILLARD

2009-07-22 22:15 UTC #36 lore raw

PATCH 6/6 Marvell RD6281A Board support

Quoted 11 lines · Prafulla Wadaskar

This is Marvell's 88F6281_A0 based reference design board
This patch is tested for-
1. Boot from DRAM/NAND flash/NFS
2. File transfer using tftp and loadb
3. NAND flash read/write/erase
Signed-off-by Prafulla Wadaskar <[email protected]>
---
Change log:
Sorry.. One commit was missing...

applied to u-boot-arm

Best Regards,
J.