Skip to contentSkip to conversation

crap/rtl8187se: Fix comment-out-typo

PATCH In review Michael Buesch 2 participants 2 messages Aug 9, 2009 – Aug 10, 2009 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crap/rtl8187se: Fix comment-out-typo

This fixes a comment-out-typo that resulted in a dangling if-branch.

---

Completely untested, but looks sane.

 drivers/staging/rtl8187se/r8180_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8187se/r8180_core.c +1 -1
@@ -3394,21 +3394,21 @@ short rtl8180_tx(struct net_device *dev,
 			if(remain == 4 && i+4 >= buflen) break;
 			/* ensure the last desc has at least 4 bytes payload */
 
 		}
 		txbuf = txbuf + i;
 		*(tail+3)=*(tail+3) &~ 0xfff;
 		*(tail+3)=*(tail+3) | i; // buffer lenght
 		// Use short preamble or not
 		if (priv->ieee80211->current_network.capability&WLAN_CAPABILITY_SHORT_PREAMBLE)
 			if (priv->plcp_preamble_mode==1 && rate!=0)	//  short mode now, not long!
-			//	*tail |= (1<<16);				// enable short preamble mode.
+			;//	*tail |= (1<<16);				// enable short preamble mode.
 
 #ifdef CONFIG_RTL8185B
 		if(bCTSEnable) {
 			*tail |= (1<<18);
 		}
 
 		if(bRTSEnable) //rts enable
 		{
 			*tail |= ((ieeerate2rtlrate(priv->ieee80211->basic_rate))<<19);//RTS RATE
 			*tail |= (1<<23);//rts enable
Signature · 1 line
Greetings, Michael.
#1 lore raw
Quoted 27 lines · Michael Buesch

This fixes a comment-out-typo that resulted in a dangling if-branch.

---

Completely untested, but looks sane.

 drivers/staging/rtl8187se/r8180_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8187se/r8180_core.c +1 -1
@@ -3394,21 +3394,21 @@ short rtl8180_tx(struct net_device *dev,
 			if(remain == 4 && i+4 >= buflen) break;
 			/* ensure the last desc has at least 4 bytes payload */
 
 		}
 		txbuf = txbuf + i;
 		*(tail+3)=*(tail+3) &~ 0xfff;
 		*(tail+3)=*(tail+3) | i; // buffer lenght
 		// Use short preamble or not
 		if (priv->ieee80211->current_network.capability&WLAN_CAPABILITY_SHORT_PREAMBLE)
 			if (priv->plcp_preamble_mode==1 && rate!=0)	//  short mode now, not long!
-			//	*tail |= (1<<16);				// enable short preamble mode.
+			;//	*tail |= (1<<16);				// enable short preamble mode.

drivers/staging/rtl8187se/r8180_core.c short rtl8180_tx(struct net_device *dev, · line 3414

Quoted 10 lines
drivers/staging/rtl8187se/r8180_core.c +0 -0
 
 #ifdef CONFIG_RTL8185B
 		if(bCTSEnable) {
 			*tail |= (1<<18);
 		}
 
 		if(bRTSEnable) //rts enable
 		{
 			*tail |= ((ieeerate2rtlrate(priv->ieee80211->basic_rate))<<19);//RTS RATE
 			*tail |= (1<<23);//rts enable

Thanks for the reminder of why rtl8187se remains abandoned...

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.