Disable PowerMac cpufreq on SMP kernels
Subsystems (2)
PATCH 1/1 Disable PowerMac cpufreq on SMP kernels
The build of a PowerMac 32bit kernel currently fails with
error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
This patch just disables this driver on SMP kernels, as it is obviously not supported.
arch/powerpc/platforms/Kconfig +1 -1
@@ -149,7 +149,7 @@ menu "CPU Frequency drivers" config CPU_FREQ_PMAC bool "Support for Apple PowerBooks" - depends on ADB_PMU && PPC32 + depends on ADB_PMU && PPC32 && !SMP select CPU_FREQ_TABLE help This adds support for frequency switching on Apple PowerBooks,
Quoted 8 lines · Bastian Blank
The build of a PowerMac 32bit kernel currently fails with
error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
This patch just disables this driver on SMP kernels, as it is obviously not supported.
Signed-off-by Bastian Blank <[email protected]>
Why not remove the #error instead ? :-) I don't think it's still meaningful, especially since we use the timebase for delays nowadays which doesn't depend on the CPU frequency...
Ben.
Quoted 18 lines
arch/powerpc/platforms/Kconfig +1
-2@@ -149,7 +149,7 @@ menu "CPU Frequency drivers" config CPU_FREQ_PMAC bool "Support for Apple PowerBooks" - depends on ADB_PMU && PPC32 + depends on ADB_PMU && PPC32 && !SMP select CPU_FREQ_TABLE help This adds support for frequency switching on Apple PowerBooks, --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
PATCH 1/1 Remove SMP warning from PowerMac cpufreq
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 2 lines · Bastian Blank
This patch just disables this driver on SMP kernels, as it is obviously not supported.
Why not remove the #error instead ? :-) I don't think it's still meaningful, especially since we use the timebase for delays nowadays which doesn't depend on the CPU frequency...
Your call. Take this one:
The build of a PowerMac 32bit kernel currently fails with
error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
Thie patch removes the not longer applicable SMP warning from the PowerMac cpufreq code.
arch/powerpc/platforms/powermac/cpufreq_32.c +0 -8
@@ -44,14 +44,6 @@*/ #undef DEBUG_FREQ -/* -* There is a problem with the core cpufreq code on SMP kernels, -* it won't recalculate the Bogomips properly -*/ -#ifdef CONFIG_SMP -#warning "WARNING, CPUFREQ not recommended on SMP kernels" -#endif -extern void low_choose_7447a_dfs (int dfs);extern void low_choose_750fx_pll (int pll);extern void low_sleep_handler (void );
Signature · 2 lines
Those who hate and fight must stop themselves -- otherwise it is not stopped. -- Spock, "Day of the Dove", stardate unknown