inlined spinlocks on sparc64
Hi,
I deleted the original thread, so I can't reply there. Just a heads up on the spinlock inlining on sparc64. I decided to give your patches a shot, since one of my IO benchmarks here basically degenerates into a spinlock microbenchmark with > 50% time spent there (unlock part, according to perf). Some of that is surely caching effects, but still.
For this particular workload, I get a net improvement of about 3.5% with the inlined functions. Not bad.
Signature · 1 line
Jens Axboe
From: Jens Axboe <[email protected]>
Date: Thu, 13 Aug 2009 10:20:58 +0200
Quoted 8 lines
I deleted the original thread, so I can't reply there. Just a heads up on the spinlock inlining on sparc64. I decided to give your patches a shot, since one of my IO benchmarks here basically degenerates into a spinlock microbenchmark with > 50% time spent there (unlock part, according to perf). Some of that is surely caching effects, but still.
For this particular workload, I get a net improvement of about 3.5% with the inlined functions. Not bad.
Doesn't surprise me, any function call can result in a register window spill onto the stack, and that's 128 bytes of writes.
Later when you leave the code path you have to refill that spilled window and you get 128 bytes of reads for each one of those.
Quoted 9 lines · David Miller
From: Jens Axboe <[email protected]>
Date: Thu, 13 Aug 2009 10:20:58 +0200Quoted 6 lines
I deleted the original thread, so I can't reply there. Just a heads up on the spinlock inlining on sparc64. I decided to give your patches a shot, since one of my IO benchmarks here basically degenerates into a spinlock microbenchmark with > 50% time spent there (unlock part, according to perf). Some of that is surely caching effects, but still.
Quoted 8 lines
Quoted 2 lines
For this particular workload, I get a net improvement of about 3.5% with the inlined functions. Not bad.
Doesn't surprise me, any function call can result in a register window spill onto the stack, and that's 128 bytes of writes.
Later when you leave the code path you have to refill that spilled window and you get 128 bytes of reads for each one of those.
Good thing it's not register starved ;-)
Forgot to mention that it grew my kernel image by exactly 80KB, total size is around 5.5MB.
Signature · 1 line
Jens Axboe
Quoted 10 lines · Jens Axboe
Hi,
I deleted the original thread, so I can't reply there. Just a heads up on the spinlock inlining on sparc64. I decided to give your patches a shot, since one of my IO benchmarks here basically degenerates into a spinlock microbenchmark with > 50% time spent there (unlock part, according to perf). Some of that is surely caching effects, but still.
For this particular workload, I get a net improvement of about 3.5% with the inlined functions. Not bad.
That sounds good! Btw. Andrew added the patches to his -mm tree, so it looks like the patches will be merged during the next merge window.