x86 : omit duplicate processing at pte_pgprot()
I'm sorry, I resend the same context message accidentally. So, please ignore this message.
thank you.
Quoted 28 lines · [email protected] wrote:
I suggest following PATCH that omit duplicate processing of mask.
pte_pgprot()macro [arch/x86/include/asm/pgtable.h] callpte_flags()[arch/x86/include/asm/pgtable_types.h] that return value is masked byPTE_FLAGS_MASKinpte_flags()function, and this macro also masks the returned value byPTE_FLAGS_MASK.I guess that we don't have to do the mask processing at
pte_pgprot()macro because it has already been masked atpte_flags(). So, how about the following PATCH ?<Hiroyasu OHYAMA>
arch/x86/include/asm/pgtable.h +0
-0@@ -265,7 +265,7 @@ static inline pgprot_t pgprot_modify(pgprot_t oldprot, pgprot_t newprot)return __pgprot (preservebits | addbits); } -#define pte_pgprot(x) __pgprot(pte_flags(x) & PTE_FLAGS_MASK) +#define pte_pgprot(x) __pgprot(pte_flags(x))#define canon_pgprot (p) __pgprot(massage_pgprot(p))Signature · 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/