Skip to contentSkip to conversation

kvm: export kvm_para.h

PATCH Superseded Michael S. Tsirkin 2 participants 3 messages Aug 10, 2009 – Aug 16, 2009 KVM

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: export kvm_para.h

kvm_para.h contains userspace interface and so
should be exported.

---

Avi, this fixes a bug (in build system) that has been there since 2.6.26. Since userspace already uses this header, I think it would be nice to have the fix in 2.6.31.

 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/linux/Kbuild +1 -0
index ab93554..598d407 100644
@@ -267,6 +267,7 @@ unifdef-y += keyboard.h
 ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
       		  $(srctree)/include/asm-$(SRCARCH)/kvm.h),)
 unifdef-y += kvm.h
+unifdef-y += kvm_para.h
 endif
 unifdef-y += llc.h
 unifdef-y += loop.h
Signature · 1 line
1.6.2.5
#1 lore raw
Quoted 4 lines · Michael S. Tsirkin

kvm_para.h contains userspace interface and so
should be exported.

Doesn't it need asm/kvm_para.h as well?

Signature · 1 line
error compiling committee.c: too many arguments to function
#2 lore raw
Quoted 7 lines · Avi Kivity
Quoted 4 lines · Michael S. Tsirkin

kvm_para.h contains userspace interface and so
should be exported.

Doesn't it need asm/kvm_para.h as well?

Yes, that was v2.

Quoted 2 lines
Signature · 1 line
error compiling committee.c: too many arguments to function