wl1251: correct definitions for 0th bit defines
PATCH 1/1 wl1251: correct definitions for 0th bit defines
ACX_SLV_SOFT_RESET_BIT and ACX_REG_EEPROM_START_BIT are both defined as "1" in the vendor driver code, but they were defined to be BIT(1) ("2") here.
The SOFT_RESET typo ensures that wl1251_boot_soft_reset() doesn't; as a result the device hangs when trying to reprogram the PLL registers while running.
Signed-off-by Bob Copeland <[email protected]>
--- drivers/net/wireless/wl12xx/wl1251_reg.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/wl12xx/wl1251_reg.h +2 -2
@@ -309,8 +309,8 @@ enum wl12xx_acx_int_reg { ACX_REG_TABLE_LEN }; -#define ACX_SLV_SOFT_RESET_BIT BIT(1) -#define ACX_REG_EEPROM_START_BIT BIT(1) +#define ACX_SLV_SOFT_RESET_BIT BIT(0) +#define ACX_REG_EEPROM_START_BIT BIT(0)/* Command/Information Mailbox Pointers */
Signature · 4 lines
1.6.2.5 -- Bob Copeland %% www.bobcopeland.com
Quoted 7 lines · Bob Copeland
ACX_SLV_SOFT_RESET_BITandACX_REG_EEPROM_START_BITare both defined as "1" in the vendor driver code, but they were defined to be BIT(1) ("2") here.The
SOFT_RESETtypo ensures thatwl1251_boot_soft_reset()doesn't; as a result the device hangs when trying to reprogram the PLL registers while running.
My bad, thanks for fixing this.
Quoted 1 line
Signed-off-by Bob Copeland <[email protected]>
Acked-by Kalle Valo <[email protected]>
Signature · 1 line
Kalle Valo