Skip to contentSkip to conversation

usbhid/hid-code.c: local function should be static

PATCH Applied H Hartley Sweeten 2 participants 2 messages Aug 17, 2009 – Aug 18, 2009

Subsystems (2)
HID USB HID/hidbp drivers (USB keyboards, mice, remote controls, ...)
lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 usbhid/hid-code.c: local function should be static

__usbhid_submit_report() is a local function wrapped by the exported symbol usbhid_submit_report(). As such, it should be static.

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Jiri Kosina <[email protected]>

---

drivers/hid/usbhid/hid-core.c +2 -1
index 3c1fcb7..1f31a9e 100644
@@ -489,7 +489,8 @@ static void hid_ctrl(struct urb *urb)
 	wake_up(&usbhid->wait);
 }
 
-void __usbhid_submit_report(struct hid_device *hid, struct hid_report *report, unsigned char dir)
+static void __usbhid_submit_report(struct hid_device *hid, struct hid_report *report,
+				   unsigned char dir)
 {
 	int head;
 	struct usbhid_device *usbhid = hid->driver_data;
Applied
#1 lore raw
Quoted 2 lines · H Hartley Sweeten

__usbhid_submit_report() is a local function wrapped by the exported symbol usbhid_submit_report(). As such, it should be static.

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs