Skip to contentSkip to conversation

linux-2.6.18.8-xen: ixgbe: memset size in netif_napi_del()

PATCH New Simon Horman 1 participant 1 message Aug 18, 2009 Network drivers

lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 linux-2.6.18.8-xen: ixgbe: memset size in netif_napi_del()

By inspection the memset appears to be long as napi->poll_dev is a struct net_device not a struct napi_struct.

Cc Mitch Williams <[email protected]>
Signed-off-by Simon Horman <[email protected]>

---

Compile tested only.

drivers/net/ixgbe/kcompat.h +1 -1
Index: linux-2.6.18-xen.hg/drivers/net/ixgbe/kcompat.h
===================================================================
@@ -1595,7 +1595,7 @@ extern int __kc_adapter_clean(struct net
 	do { \
 		WARN_ON(!test_bit(__LINK_STATE_RX_SCHED, &(_napi)->poll_dev.state)); \
 		dev_put(&(_napi)->poll_dev); \
-		memset(&(_napi)->poll_dev, 0, sizeof(struct napi_struct));\
+		memset(&(_napi)->poll_dev, 0, sizeof((_napi)->poll_dev));\
 	} while (0)
 #else /* DRIVER_IGB || DRIVER_IXGBE */
 #define netif_rx_complete(netdev, napi) netif_rx_complete(netdev)