Skip to contentSkip to conversation

nfs MNT include cleanup

DISCUSSION maximilian attems 3 participants 7 messages Aug 11, 2009 – Aug 18, 2009 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build MNTPROC_MNT and MNTPROC_UMNT no longer defined.

usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_call=E2=80=99:
usr/kinit/nfsmount/mount.c:179: error: =E2=80=98MNTPROC_MNT=E2=80=99 un= declared (first use in this function) usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier is r= eported only once
usr/kinit/nfsmount/mount.c:179: error: for each function it appears in.= )
usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:211: error: =E2=80=98MNTPROC_MNT=E2=80=99 un= declared (first use in this function) usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:226: error: =E2=80=98MNTPROC_UMNT=E2=80=99 u= ndeclared (first use in this function) usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:232: error: =E2=80=98MNTPROC_MNT=E2=80=99 un= declared (first use in this function) usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:251: error: =E2=80=98MNTPROC_UMNT=E2=80=99 u= ndeclared (first use in this function)
make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1
make[3]: *** [usr/kinit/nfsmount] Error 2
make[2]: *** [all] Error 2
make[1]: *** [klibc] Error 2
make[1]: Leaving directory `/home/maks/src/klibc-latest'

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · maximilian attems

2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build MNTPROC_MNT and MNTPROC_UMNT no longer defined.

I assume then that klibc is out of tree? I can't find it in my kernel = =20
repo.

Quoted 4 lines

usr/kinit/nfsmount/mount.c: In function =91mount_call=92:
usr/kinit/nfsmount/mount.c:179: error: =91MNTPROC_MNT=92 undeclared =20 (first use in this function)
usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier =20

Quoted 8 lines

is reported only once
usr/kinit/nfsmount/mount.c:179: error: for each function it appears =20 in.)
usr/kinit/nfsmount/mount.c: In function =91mount_v2=92:
usr/kinit/nfsmount/mount.c:211: error: =91MNTPROC_MNT=92 undeclared =20 (first use in this function)
usr/kinit/nfsmount/mount.c: In function =91umount_v2=92:
usr/kinit/nfsmount/mount.c:226: error: =91MNTPROC_UMNT=92 undeclared =

=20

Quoted 6 lines

(first use in this function)
usr/kinit/nfsmount/mount.c: In function =91mount_v3=92:
usr/kinit/nfsmount/mount.c:232: error: =91MNTPROC_MNT=92 undeclared =20 (first use in this function)
usr/kinit/nfsmount/mount.c: In function =91umount_v3=92:
usr/kinit/nfsmount/mount.c:251: error: =91MNTPROC_UMNT=92 undeclared =

=20

Quoted 6 lines

(first use in this function)
make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1 make[3]: *** [usr/kinit/nfsmount] Error 2 make[2]: *** [all] Error 2
make[1]: *** [klibc] Error 2
make[1]: Leaving directory `/home/maks/src/klibc-latest'

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

#3 lore raw
Quoted 6 lines · Chuck Lever
Quoted 2 lines · maximilian attems

2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build MNTPROC_MNT and MNTPROC_UMNT no longer defined.

=20
I assume then that klibc is out of tree? I can't find it in my kernel repo.

sorry for late reply, indeed you'll find it here:
http://git.kernel.org/?p=3Dlibs/klibc/klibc.git;a=3Dsummary
=20

Quoted 1 line
Quoted 1 line

usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_call=E2=80=99=

:

Quoted 1 line
Quoted 1 line

usr/kinit/nfsmount/mount.c:179: error: =E2=80=98MNTPROC_MNT=E2=80=99=

undeclared

Quoted 7 lines
Quoted 7 lines

(first use in this function) usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier is reported only once
usr/kinit/nfsmount/mount.c:179: error: for each function it appears in.)
usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:211: error: =E2=80=98MNTPROC_MNT=E2=80=99=

undeclared

Quoted 3 lines
Quoted 3 lines

(first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v2=E2=80=99:
usr/kinit/nfsmount/mount.c:226: error: =E2=80=98MNTPROC_UMNT=E2=80=99=

undeclared

Quoted 3 lines
Quoted 3 lines

(first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98mount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:232: error: =E2=80=98MNTPROC_MNT=E2=80=99=

undeclared

Quoted 3 lines
Quoted 3 lines

(first use in this function)
usr/kinit/nfsmount/mount.c: In function =E2=80=98umount_v3=E2=80=99:
usr/kinit/nfsmount/mount.c:251: error: =E2=80=98MNTPROC_UMNT=E2=80=99=

undeclared

Quoted 6 lines
Quoted 6 lines

(first use in this function)
make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1 make[3]: *** [usr/kinit/nfsmount] Error 2 make[2]: *** [all] Error 2
make[1]: *** [klibc] Error 2
make[1]: Leaving directory `/home/maks/src/klibc-latest'

we might still define those for ourselve, let's see..

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 24 lines · maximilian attems
Quoted 6 lines · Chuck Lever
Quoted 2 lines · maximilian attems

2ad780978b7c0c3e7877949f098cbd06e7c73839 broke klibc build MNTPROC_MNT and MNTPROC_UMNT no longer defined.

I assume then that klibc is out of tree? I can't find it in my kernel repo.

sorry for late reply, indeed you'll find it here:
http://git.kernel.org/?p=3Dlibs/klibc/klibc.git;a=3Dsummary

Quoted 12 lines
Quoted 12 lines

usr/kinit/nfsmount/mount.c: In function =91mount_call=92:
usr/kinit/nfsmount/mount.c:179: error: =91MNTPROC_MNT=92 undeclared (first use in this function) usr/kinit/nfsmount/mount.c:179: error: (Each undeclared identifier is reported only once
usr/kinit/nfsmount/mount.c:179: error: for each function it appears in.)
usr/kinit/nfsmount/mount.c: In function =91mount_v2=92:
usr/kinit/nfsmount/mount.c:211: error: =91MNTPROC_MNT=92 undeclared (first use in this function)
usr/kinit/nfsmount/mount.c: In function =91umount_v2=92:
usr/kinit/nfsmount/mount.c:226: error: =91MNTPROC_UMNT=92 undeclare=

d

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

(first use in this function)
usr/kinit/nfsmount/mount.c: In function =91mount_v3=92:
usr/kinit/nfsmount/mount.c:232: error: =91MNTPROC_MNT=92 undeclared (first use in this function)
usr/kinit/nfsmount/mount.c: In function =91umount_v3=92:
usr/kinit/nfsmount/mount.c:251: error: =91MNTPROC_UMNT=92 undeclare=

d

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

(first use in this function)
make[4]: *** [usr/kinit/nfsmount/mount.o] Error 1 make[3]: *** [usr/kinit/nfsmount] Error 2 make[2]: *** [all] Error 2
make[1]: *** [klibc] Error 2
make[1]: Leaving directory `/home/maks/src/klibc-latest'

we might still define those for ourselve, let's see..

That makes sense to me as an immediate fix.

However, the kernel has its own NFS mount client (the piece that =20 handles rpcbind query and obtaining the root file handle), and you can = =20
pass a C string of mount options to the kernel with mount(2). Perhaps = =20
in the long term, you might consider replacing the specialized code in = =20
klibc with simply passing the server, export path, and mount options =20 right to the kernel and let it do the work. This should work with any = =20
kernel later than 2.6.23.

I'm happy to help with any questions.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

#6 lore raw
Quoted 10 lines · Chuck Lever

However, the kernel has its own NFS mount client (the piece that handles rpcbind query and obtaining the root file handle), and you can pass a C string of mount options to the kernel with mount(2). Perhaps in the long term, you might consider replacing the specialized code in klibc with simply passing the server, export path, and mount options right to the kernel and let it do the work. This should work with any kernel later than 2.6.23.

I'm happy to help with any questions.

sounds good indeed.
a quick one: can it do nfs v4 mounts?

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw
Quoted 10 lines · maximilian attems
Quoted 9 lines · Chuck Lever

However, the kernel has its own NFS mount client (the piece that handles rpcbind query and obtaining the root file handle), and you can pass a C string of mount options to the kernel with mount(2). Perhaps in the long term, you might consider replacing the specialized code in klibc with simply passing the server, export path, and mount options right to the kernel and let it do the work. This should work with any kernel later than 2.6.23.

Quoted 4 lines
Quoted 1 line

I'm happy to help with any questions.

sounds good indeed.
a quick one: can it do nfs v4 mounts?

Yes, in fact. Set the file system type to "nfs4" instead of "nfs" when invoking mount(2).

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

#9 lore raw
In reply to a message not in the archive
Quoted 9 lines · maximilian attems
Quoted 8 lines · Chuck Lever

However, the kernel has its own NFS mount client (the piece that handles rpcbind query and obtaining the root file handle), and you can pass a C string of mount options to the kernel with mount(2). Perhaps in the long term, you might consider replacing the specialized code in klibc with simply passing the server, export path, and mount options right to the kernel and let it do the work. This should work with any kernel later than 2.6.23.

Quoted 5 lines
Quoted 1 line

I'm happy to help with any questions.

sounds good indeed.
a quick one: can it do nfs v4 mounts?

I believe that was the reason for the change in the first place, and yes, klibc should *absolutely* use it.

-hpa (who once again apologizes for lack of time...)

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.