input: i8042 - add Acer Aspire 5536 to the noloop list
Subsystems (2)
PATCH 1/1 input: i8042 - add Acer Aspire 5536 to the noloop list
Without this patch it is not possible to reenable touchpad after disabling it using disable button.
--- drivers/input/serio/i8042-x86ia64io.h | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
drivers/input/serio/i8042-x86ia64io.h +8 -0
@@ -167,6 +167,14 @@ static struct dmi_system_id __initdata i8042_dmi_noloop_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "Rev 1"), }, }, + { + .ident = "Acer Aspire 5536", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5536"), + DMI_MATCH(DMI_PRODUCT_VERSION, "0100"), + }, + }, { } };
Signature · 1 line
1.6.3.3
Quoted 2 lines · Eugeniy Meshcheryakov
Without this patch it is not possible to reenable touchpad after disabling it using disable button.
Applied, thank you Eugeniy.
However for 2.6.32 I am looking for more generic solution, could you please try the patch below (without yours applied)?
Thanks!
Signature · 23 lines
Dmitry Input: i8042 - bypass AUX IRQ delivery test on laptops From: Dmitry Torokhov <[email protected]> It seems that many laptops do not fully implement AUX LOOP command in their keyboard controllers, causing issues with touchpad detection. Hovewer we know that almost every laptop/portable uses PS/2 pointing device and even if user disables it in favor of external mouse the system will not use IRQ 12 for anything else. Therefore we may bypass AUX IRQ delivery test when running on a laptop and assume that it is routed properly. Just to be safe we require the box to have good PNP data in order to bypass the test. Signed-off-by: Dmitry Torokhov <[email protected]> --- drivers/input/serio/i8042-x86ia64io.h | 34 +++++++++++++++++++++++++++++++++ drivers/input/serio/i8042.c | 4 +++- 2 files changed, 37 insertions(+), 1 deletions(-)
drivers/input/serio/i8042-x86ia64io.h +34 -0
@@ -449,6 +449,34 @@ static struct dmi_system_id __initdata i8042_dmi_nopnp_table[] = { }, { } }; + +static struct dmi_system_id __initdata i8042_dmi_laptop_table[] = { + { + .ident ="Portable" , + .matches = { +DMI_MATCH (DMI_CHASSIS_TYPE ,"8" ),/* Portable */ + }, + }, + { + .ident ="Laptop" , + .matches = { +DMI_MATCH (DMI_CHASSIS_TYPE ,"9" ),/* Laptop */ + }, + }, + { + .ident ="Notebook" , + .matches = { +DMI_MATCH (DMI_CHASSIS_TYPE ,"10" ),/* Notebook */ + }, + }, + { + .ident ="Sub-Notebook" , + .matches = { +DMI_MATCH (DMI_CHASSIS_TYPE ,"14" ),/* Sub-Notebook */ + }, + }, + +};#endif /*
@@ -727,6 +755,12 @@ static int __init i8042_pnp_init(void) i8042_kbd_irq = i8042_pnp_kbd_irq; i8042_aux_irq = i8042_pnp_aux_irq; +#ifdef CONFIG_X86 + i8042_bypass_aux_irq_test = !i8042_noaux && + !pnp_data_busted && +dmi_check_system (i8042_dmi_laptop_table); +#endif +return 0 ; }
drivers/input/serio/i8042.c +3 -1
@@ -83,6 +83,8 @@ module_param_named(debug, i8042_debug, bool, 0600);MODULE_PARM_DESC (debug,"Turn i8042 debugging mode on and off" );#endif +static bool i8042_bypass_aux_irq_test; +#include "i8042.h" static DEFINE_SPINLOCK (i8042_lock);
@@ -641,7 +643,7 @@ static int __devinit i8042_check_aux(void)* used it for a PCI card or somethig else. */ -if (i8042_noloop || aux_loop_broken) { +if (i8042_noloop || i8042_bypass_aux_irq_test || aux_loop_broken) {/* * Without LOOP command we can't test AUX IRQ delivery. Assume the port * is working and hope we are right.
Hello,
I tried your patch and it does not fix the problem. I still need to add i8042.noloop=1 to the kernel command line to be able to reenable the touchpad. Also at this laptop touchpad is detected correctly, it only stops working after disabling and reenabling (also once or twice it stopped working even without pressing the disable button, this can be related).
17 серпня 2009 о 22:24 -0700 Dmitry Torokhov написав(-ла):
Quoted 28 lines · Eugeniy Meshcheryakov
Quoted 2 lines
Without this patch it is not possible to reenable touchpad after disabling it using disable button.
Applied, thank you Eugeniy.
However for 2.6.32 I am looking for more generic solution, could you please try the patch below (without yours applied)?
Thanks!
Signature · 16 lines
Dmitry Input: i8042 - bypass AUX IRQ delivery test on laptops From: Dmitry Torokhov <[email protected]> It seems that many laptops do not fully implement AUX LOOP command in their keyboard controllers, causing issues with touchpad detection. Hovewer we know that almost every laptop/portable uses PS/2 pointing device and even if user disables it in favor of external mouse the system will not use IRQ 12 for anything else. Therefore we may bypass AUX IRQ delivery test when running on a laptop and assume that it is routed properly. Just to be safe we require the box to have good PNP data in order to bypass the test.
Quoted 3 lines · Eugeniy Meshcheryakov
I tried your patch and it does not fix the problem. I still need to add i8042.noloop=1 to the kernel command line to be able to reenable the touchpad.
What chasis type do you see in the 'dmidecode' output on the affected system?
Signature · 2 lines
Jiri Kosina SUSE Labs
19 серпня 2009 о 10:56 +0200 Jiri Kosina написав(-ла):
Quoted 2 lines
What chasis type do you see in the 'dmidecode' output on the affected system?
Notebook
Regards,
Eugeniy Meshcheryakov
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov
maintainerQuoted 6 lines · Eugeniy Meshcheryakov
19 серпня 2009 о 10:56 +0200 Jiri Kosina написав(-ла):
Quoted 2 lines
What chasis type do you see in the 'dmidecode' output on the affected system?
Notebook
I really need to see dmesg with i8042.debug to see what is going on. The patch should only help with initial AUX discovery at startup; Eugeniy however only has trouble re-enabling the touchpad with special button.
Signature · 5 lines
Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html