Skip to contentSkip to conversation

Make LSM_MMAP_MIN_ADDR default match its help text.

PATCH Dave Jones 3 participants 5 messages Aug 18, 2009 1 message not in the archive Security (LSM)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw

Commit 788084aba2ab7348257597496befcbccabdc98a3 added the LSM_MMAP_MIN_ADDR option, whose help text states "For most ia64, ppc64 and x86 users with lots of address space a value of 65536 is reasonable and should cause no problems." Which implies that it's default setting was typoed.

security/Kconfig renamed from security/Kconfig~ +1 -1
@@ -116,7 +116,7 @@ config SECURITY_ROOTPLUG
 config LSM_MMAP_MIN_ADDR
 	int "Low address space for LSM to from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
-	default 65535
+	default 65536
 	help
 	  This is the portion of low virtual memory which should be protected
 	  from userspace allocation.  Keeping a user from writing to low pages
Acked-by
#2 lore raw
Quoted 4 lines · Dave Jones

Commit 788084aba2ab7348257597496befcbccabdc98a3 added the LSM_MMAP_MIN_ADDR option, whose help text states "For most ia64, ppc64 and x86 users with lots of address space a value of 65536 is reasonable and should cause no problems." Which implies that it's default setting was typoed.

This can wait or go now. the tests against this are always a strict > (not >=) and they are always rounded to PAGE_SIZE. Thus both have the same address protections.

-Eric

Quoted 13 lines
security/Kconfig renamed from security/Kconfig~ +1 -1
@@ -116,7 +116,7 @@ config SECURITY_ROOTPLUG
 config LSM_MMAP_MIN_ADDR
 	int "Low address space for LSM to from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
-	default 65535
+	default 65536
 	help
 	  This is the portion of low virtual memory which should be protected
 	  from userspace allocation.  Keeping a user from writing to low pages
#3 lore raw
In reply to Dave Jones
Quoted 2 lines · Dave Jones

config LSM_MMAP_MIN_ADDR
int "Low address space for LSM to from user allocation"

This sentence no verb.

Andreas.
---

Quoted 1 line

From 4ba5116764386ceb1a9da4cb6800defd84f0e3c1 Mon Sep 17 00:00:00 2001

From: Andreas Schwab <[email protected]>
Date: Tue, 18 Aug 2009 22:08:43 +0200
Subject: [PATCH] Fix prompt for LSM_MMAP_MIN_ADDR.

---
 security/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
security/Kconfig +1 -1
index 9c60c34..4d1a2e3 100644
@@ -114,7 +114,7 @@ config SECURITY_ROOTPLUG
 	  If you are unsure how to answer this question, answer N.
 
 config LSM_MMAP_MIN_ADDR
-	int "Low address space for LSM to from user allocation"
+	int "Low address space for LSM to protect from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
 	default 65535
 	help
Signature · 6 lines
1.6.4

-- 
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Acked-by
#4 lore raw
Quoted 7 lines · Andreas Schwab
Quoted 2 lines · Dave Jones

config LSM_MMAP_MIN_ADDR
int "Low address space for LSM to from user allocation"

This sentence no verb.

Quoted 8 lines

Andreas.
---
From 4ba5116764386ceb1a9da4cb6800defd84f0e3c1 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <[email protected]>
Date: Tue, 18 Aug 2009 22:08:43 +0200
Subject: [PATCH] Fix prompt for LSM_MMAP_MIN_ADDR.

Quoted 20 lines
---
 security/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
security/Kconfig +1 -1
index 9c60c34..4d1a2e3 100644
@@ -114,7 +114,7 @@ config SECURITY_ROOTPLUG
 	  If you are unsure how to answer this question, answer N.
 
 config LSM_MMAP_MIN_ADDR
-	int "Low address space for LSM to from user allocation"
+	int "Low address space for LSM to protect from user allocation"
 	depends on SECURITY && SECURITY_SELINUX
 	default 65535
 	help
Signature · 1 line
1.6.4
author
#5 lore raw
In reply to Andreas Schwab
Quoted 6 lines · Andreas Schwab
Quoted 2 lines · Dave Jones

config LSM_MMAP_MIN_ADDR
int "Low address space for LSM to from user allocation"

This sentence no verb.

Oops. I accidentally that.

Thanks.

Dave