Skip to contentSkip to conversation

USB: fsl_qe_udc: Add fsl,mpc8323-qe-usb compatible entry

PATCH In review Anton Vorontsov 2 participants 2 messages Aug 18, 2009 – Aug 19, 2009 USB

lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 1/1 USB: fsl_qe_udc: Add fsl,mpc8323-qe-usb compatible entry

Current bindings specify that "fsl,mpc8323-qe-usb" compatible entry should be used as a base match for QE UDCs, so update the driver to comply with the bindings.

Signed-off-by Anton Vorontsov <[email protected]>

---

Quoted 6 lines · Scott Wood
Quoted 5 lines · Anton Vorontsov
Quoted 4 lines · Timur Tabi
Quoted 2 lines · Anton Vorontsov

Oh, I was wrong. fsl_qe_udc driver uses mpc8360 compatible for matching, so you can't remove it. :-/

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Ugh, that's a bug in the driver then.

Yes, but that depends on what chip was the first one? MPC8323 or MPC8360?

Actually, it depends on which one we picked in the devtree binding (assuming they're compatible both ways), which appears to be mpc8323.

A bit delayed, but here is a patch to fix the issue.

 drivers/usb/gadget/fsl_qe_udc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/usb/gadget/fsl_qe_udc.c +4 -0
index d701bf4..7881f12 100644
@@ -2751,6 +2751,10 @@ static int __devexit qe_udc_remove(struct of_device *ofdev)
 /*-------------------------------------------------------------------------*/
 static struct of_device_id __devinitdata qe_udc_match[] = {
 	{
+		.compatible = "fsl,mpc8323-qe-usb",
+		.data = (void *)PORT_QE,
+	},
+	{
 		.compatible = "fsl,mpc8360-qe-usb",
 		.data = (void *)PORT_QE,
 	},
Signature · 1 line
1.6.3.3