Skip to contentSkip to conversation

powerpc/82xx: Fix BCSR bits for MPC8272ADS boards

PATCH Applied Anton Vorontsov 2 participants 2 messages Aug 18, 2009 – Aug 25, 2009 PowerPC

lore
Share & tools
lore

Anton Vorontsov

author
#0 lore raw

PATCH 1/3 powerpc/82xx: Fix BCSR bits for MPC8272ADS boards

mpc8272_ads.c is using BCSR bits definitions from pq2ads.h, but according to User's Guide the bits are wrong for MPC8272ADS boards (I guess definitions from pq2ads should only be used for PQ2FADS boards).

So, let's introduce our own definitions for MPC8272ADS, and don't include pq2ads.h.

Signed-off-by Anton Vorontsov <[email protected]>
---
 arch/powerpc/platforms/82xx/mpc8272_ads.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
arch/powerpc/platforms/82xx/mpc8272_ads.c +7 -1
index 8054c68..67e2184 100644
@@ -29,7 +29,6 @@
 #include <sysdev/fsl_soc.h>
 #include <sysdev/cpm2_pic.h>
 
-#include "pq2ads.h"
 #include "pq2.h"
 
 static void __init mpc8272_ads_pic_init(void)

@@ -144,6 +143,13 @@ static void __init mpc8272_ads_setup_arch(void)
 		return;
 	}
 
+#define BCSR1_FETHIEN		0x08000000
+#define BCSR1_FETH_RST		0x04000000
+#define BCSR1_RS232_EN1		0x02000000
+#define BCSR1_RS232_EN2		0x01000000
+#define BCSR3_FETHIEN2		0x10000000
+#define BCSR3_FETH2_RST		0x08000000
+
 	clrbits32(&bcsr[1], BCSR1_RS232_EN1 | BCSR1_RS232_EN2 | BCSR1_FETHIEN);
 	setbits32(&bcsr[1], BCSR1_FETH_RST);
Signature · 1 line
1.6.3.3
Applied
#1 lore raw
Quoted 5 lines · Anton Vorontsov

mpc8272_ads.c is using BCSR bits definitions from pq2ads.h, but according to User's Guide the bits are wrong for MPC8272ADS boards (I guess definitions from pq2ads should only be used for PQ2FADS boards).

Quoted 7 lines

So, let's introduce our own definitions for MPC8272ADS, and don't include pq2ads.h.

Signed-off-by Anton Vorontsov <[email protected]>

---
arch/powerpc/platforms/82xx/mpc8272_ads.c | 8 +++++++-

1 files changed, 7 insertions(+), 1 deletions(-)

applied to next.

- k