fix pygrub domU grub.conf timeout=0 handling
PATCH 1/1 fix pygrub domU grub.conf timeout=0 handling
Hello,
When you install Fedora 11 PV domU/guest with virt-install or virt-manager, it will have timeout=0 in it's grub.conf. This is a new default in F11.
pygrub of Xen 3.4.1 doesn't seem to be able to handle timeout=0, instead it waits the user to press ENTER.. this causes confusion and makes it look like the guest has crashed. Graphical VNC console is not yet available at this point, so the kernel can be only chosen from "xm console <f11domain>", where pygrub is waiting for user input.
This patch fixes the problem and let's you start F11 domUs without going to the text console to select the kernel. The change is taken from the RHEL5.3 version of pygrub.
Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs.
-- Pasi
Quoted 11 lines · Pasi Kärkkäinen
Hello,
When you install Fedora 11 PV domU/guest with virt-install or virt-manager, it will have timeout=0 in it's grub.conf. This is a new default in F11.
pygrub of Xen 3.4.1 doesn't seem to be able to handle timeout=0, instead it waits the user to press ENTER.. this causes confusion and makes it look like the guest has crashed. Graphical VNC console is not yet available at this point, so the kernel can be only chosen from "xm console <f11domain>", where pygrub is waiting for user input.
Quoted 6 lines
This patch fixes the problem and let's you start F11 domUs without going to the text console to select the kernel. The change is taken from the RHEL5.3 version of pygrub.
Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs.
And actually attached this time.
-- Pasi
pygrub renamed from pygrub-xen341 +1 -1
@@ -447,7 +447,7 @@ # So we may come here even after a key has been pressed. # Check both timeout and mytime to avoid exiting # when we shouldn't. - if timeout != -1 and mytime >= int(timeout): + if mytime >= int(timeout): self.isdone = True break else:
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 6 lines · Pasi Kärkkäinen
Quoted 6 lines
pygrub of Xen 3.4.1 doesn't seem to be able to handle timeout=0, instead it waits the user to press ENTER.. this causes confusion and makes it look like the guest has crashed. Graphical VNC console is not yet available at this point, so the kernel can be only chosen from "xm console <f11domain>", where pygrub is waiting for user input.
Quoted 8 lines
Quoted 6 lines
This patch fixes the problem and let's you start F11 domUs without going to the text console to select the kernel. The change is taken from the RHEL5.3 version of pygrub.
Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs.
And actually attached this time.
Really this is a reversion of c/s 19322, which was a dodgy bugfix for Solaris. So I just checked it in as a reversion.
-- Keir
Quoted 12 lines · Keir Fraser
Quoted 10 lines · Pasi Kärkkäinen
Quoted 10 lines
pygrub of Xen 3.4.1 doesn't seem to be able to handle timeout=0, instead it waits the user to press ENTER.. this causes confusion and makes it look like the guest has crashed. Graphical VNC console is not yet available at this point, so the kernel can be only chosen from "xm console <f11domain>", where pygrub is waiting for user input.
This patch fixes the problem and let's you start F11 domUs without going to the text console to select the kernel. The change is taken from the RHEL5.3 version of pygrub.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs.
And actually attached this time.
Really this is a reversion of c/s 19322, which was a dodgy bugfix for Solaris. So I just checked it in as a reversion.
Thanks!
-- Pasi