rndis_wlan: fix broken logic in add_wep_key()

PATCH New Jussi Kivilinna 1 participant 1 message Aug 20, 2009 Networking drivers (wireless)

Share & tools

Jussi Kivilinna

author

2009-08-20 18:00 UTC #0 lore raw

PATCH 1/1 rndis_wlan: fix broken logic in add_wep_key()

add_wep_key() tries to check if key length is not 5 AND not 13 but uses (key_len != 5 || key_len != 13) instead. Fix this.

Signed-off-by Jussi Kivilinna <[email protected]>

---

 drivers/net/wireless/rndis_wlan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/wireless/rndis_wlan.c +1 -1

index d42692d..c5b921b 100644
@@ -1214,7 +1214,7 @@ static int add_wep_key(struct usbnet *usbdev, char *key, int key_len, int index)
 	struct ndis_80211_wep_key ndis_key;
 	int cipher, ret;
 
-	if ((key_len != 5 || key_len != 13) || index < 0 || index > 3)
+	if ((key_len != 5 && key_len != 13) || index < 0 || index > 3)
 		return -EINVAL;
 
 	if (key_len == 5)