Skip to contentSkip to conversation

acpi: thermal: display forced passive trip points in proc

PATCH In review Frans Pop 1 participant 3 messages Aug 21, 2009

Subsystems (2)
lore
Share & tools
lore

Frans Pop

author
#0 lore raw

PATCH 1/1 acpi: thermal: display forced passive trip points in proc

Users can force a passive trip point for a thermal zone that does not have _PSV defined in ACPI by setting the passive attribute in sysfs. It's useful to display such trip points in /proc/acpi/thermal_zone.

.../TZ1/cooling_mode:<setting not supported>
.../TZ1/polling_frequency:polling frequency: 10 seconds
.../TZ1/state:state: ok

.../TZ1/temperature:temperature:             56 C
.../TZ1/trip_points:critical (S5):           110 C
.../TZ1/trip_points:passive:                 95 C: forced

---

Now that I've got this set on my notebook, I also want to see that it's set :-)

Cheers,
FJP

drivers/acpi/thermal.c +4 -0
index 564ea14..c64cfa9 100644
@@ -1050,6 +1050,10 @@ static int acpi_thermal_trip_seq_show(struct seq_file *seq, void *offset)
 				   acpi_device_bid(device));
 		}
 		seq_puts(seq, "\n");
+	} else if (tz->thermal_zone->forced_passive) {
+		seq_printf(seq,
+			   "passive:                 %i C: forced",
+			   tz->thermal_zone->forced_passive / 1000);
 	}
 
 	for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++) {
author
#1 lore raw
Quoted 10 lines · Frans Pop

Users can force a passive trip point for a thermal zone that does not have _PSV defined in ACPI by setting the passive attribute in sysfs. It's useful to display such trip points in /proc/acpi/thermal_zone.

.../TZ1/cooling_mode:<setting not supported>
.../TZ1/polling_frequency:polling frequency: 10 seconds
.../TZ1/state:state: ok

.../TZ1/temperature:temperature:             56 C
.../TZ1/trip_points:critical (S5):           110 C
.../TZ1/trip_points:passive:                 95 C: forced

Hmm. Maybe the following would be clearer:
.../TZ1/trip_points:passive (forced): 95 C

?

author
#2 lore raw
In reply to Frans Pop

Users can force a passive trip point for a thermal zone that does not have _PSV defined in ACPI by setting the passive attribute in sysfs. It's useful to display such trip points in /proc/acpi/thermal_zone.

.../TZ1/cooling_mode:<setting not supported>
.../TZ1/polling_frequency:polling frequency: 10 seconds
.../TZ1/state:state: ok

.../TZ1/temperature:temperature:             53 C
.../TZ1/trip_points:critical (S5):           110 C
.../TZ1/trip_points:passive (forced):        95 C

And if not set (passive is 0):
.../TZ1/trip_points:passive (forced):<not set>

---

I noticed I forgot the linefeed and thought of a further improvement.

drivers/acpi/thermal.c +0 -0
index 564ea14..7ff5789 100644
@@ -1050,6 +1050,13 @@ static int acpi_thermal_trip_seq_show(struct 

seq_file *seq, void *offset)
acpi_device_bid(device));
}
seq_puts(seq, "\n");
+ } else {
+ seq_printf(seq, "passive (forced):");
+ if (tz->thermal_zone->forced_passive)
+ seq_printf(seq, " %i C\n",
+ tz->thermal_zone->forced_passive / 1000);
+ else
+ seq_printf(seq, "<not set>\n");
}

for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++) {