Skip to contentSkip to conversation

directfb: allow to enable debug and trace support

PATCH New Sven Neumann 4 participants 6 messages Aug 6, 2009 – Aug 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG to enable lots of debugging output from DirectFB and BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces in case of a crash.

---
 package/directfb/Config.in   |   13 ++++++++++++-
 package/directfb/directfb.mk |   15 +++++++++++++++
 2 files changed, 27 insertions(+), 1 deletions(-)
package/directfb/Config.in +12 -1
index 4642ee0..e616314 100644
@@ -11,7 +11,18 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 	select BR2_PACKAGE_LINUX_FUSION
 	help
 	  Enable use of multiple concurrent DirectFB applications
-	  http://www.directfb.org/
+
+config BR2_PACKAGE_DIRECTFB_DEBUG
+	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Compile DirectFB with lots of debug output
+
+config BR2_PACKAGE_DIRECTFB_TRACE
+	bool "directfb call trace support"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Enable call tracing for DirectFB applications
 
 config BR2_PACKAGE_DIRECTFB_XSERVER
 	bool "build with X server backend"
package/directfb/directfb.mk +15 -0
index 8456798..b3af0ed 100644
@@ -19,6 +19,19 @@ else
 DIRECTFB_MULTI:=
 DIRECTFB_FUSION:=
 endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
+DIRECTFB_DEBUG:=--enable-debug
+else
+DIRECTFB_DEBUG:=
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
+DIRECTFB_TRACE:=--enable-trace
+else
+DIRECTFB_TRACE:=
+endif
+
 ifeq ($(BR2_PACKAGE_XSERVER),y)
 DIRECTFB_X:=--enable-x11
 else
@@ -114,6 +127,8 @@ DIRECTFB_CONF_OPT = \
 	--enable-shared \
 	--disable-explicit-deps \
 	$(DIRECTFB_MULTI) \
+	$(DIRECTFB_DEBUG) \
+	$(DIRECTFB_TRACE) \
 	$(DIRECTFB_X) \
 	$(DIRECTFB_JPEG) \
 	$(DIRECTFB_PNG) \
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

Le jeudi 06 ao?t 2009 ? 12:28 +0200, Sven Neumann a ?crit :

Quoted 60 lines

This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG to enable lots of debugging output from DirectFB and BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces in case of a crash.

---
 package/directfb/Config.in   |   13 ++++++++++++-
 package/directfb/directfb.mk |   15 +++++++++++++++
 2 files changed, 27 insertions(+), 1 deletions(-)
package/directfb/Config.in +12 -1
index 4642ee0..e616314 100644
@@ -11,7 +11,18 @@ config BR2_PACKAGE_DIRECTFB_MULTI
 	select BR2_PACKAGE_LINUX_FUSION
 	help
 	  Enable use of multiple concurrent DirectFB applications
-	  http://www.directfb.org/
+
+config BR2_PACKAGE_DIRECTFB_DEBUG
+	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Compile DirectFB with lots of debug output
+
+config BR2_PACKAGE_DIRECTFB_TRACE
+	bool "directfb call trace support"
+	depends on BR2_PACKAGE_DIRECTFB
+	help
+	  Enable call tracing for DirectFB applications
 
 config BR2_PACKAGE_DIRECTFB_XSERVER
 	bool "build with X server backend"
package/directfb/directfb.mk +13 -0
index 8456798..b3af0ed 100644
@@ -19,6 +19,19 @@ else
 DIRECTFB_MULTI:=
 DIRECTFB_FUSION:=
 endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
+DIRECTFB_DEBUG:=--enable-debug
+else
+DIRECTFB_DEBUG:=
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
+DIRECTFB_TRACE:=--enable-trace
+else
+DIRECTFB_TRACE:=
+endif
+
 ifeq ($(BR2_PACKAGE_XSERVER),y)
 DIRECTFB_X:=--enable-x11
 else

package/directfb/directfb.mk DIRECTFB_CONF_OPT = \ · line 134

Quoted 8 lines
package/directfb/directfb.mk +2 -0
@@ -114,6 +127,8 @@ DIRECTFB_CONF_OPT = \
 	--enable-shared \
 	--disable-explicit-deps \
 	$(DIRECTFB_MULTI) \
+	$(DIRECTFB_DEBUG) \
+	$(DIRECTFB_TRACE) \
 	$(DIRECTFB_X) \
 	$(DIRECTFB_JPEG) \
 	$(DIRECTFB_PNG) \

Also proposed in https://bugs.busybox.net/show_bug.cgi?id=471

I'm using --enable-debug and --enable-debug-support instead of --enable-debug only. Does it make sense ?

Signature · 1 line
Lionel Landwerlin <[email protected]>
#2 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

Hi,

Quoted 4 lines · Lionel Landwerlin

Also proposed in https://bugs.busybox.net/show_bug.cgi?id=471

I'm using --enable-debug and --enable-debug-support instead of --enable-debug only. Does it make sense ?

--enable-debug-support is on by default anyway. But these two options are definitely confusing. I am having trouble to understand does what.

My main point was to add support for the --enable-trace option. Perhaps I should have done that separately.

Sven

#3 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

In reply to Sven Neumann

Le Thu, 6 Aug 2009 12:28:15 +0200,
Sven Neumann <[email protected]> a ?crit :

Quoted 4 lines

This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG to enable lots of debugging output from DirectFB and BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces in case of a crash.

Pulled and pushed into my for-2009.08 branch, that should be pulled by Peter when he comes back from holidays.

http://git.buildroot.net/~tpetazzoni/git/buildroot/log/?h=for-2009.08

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Le Thu, 6 Aug 2009 12:28:15 +0200, Thomas> Sven Neumann <[email protected]> a ?crit :

Quoted 4 lines
Quoted 4 lines

This change adds two new options, BR2_PACKAGE_DIRECTFB_DEBUG to enable lots of debugging output from DirectFB and BR2_PACKAGE_DIRECTFB_TRACE to enable support for call traces in case of a crash.

Thomas> Pulled and pushed into my for-2009.08 branch, that should be pulled by Thomas> Peter when he comes back from holidays.

Done.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 directfb: allow to enable debug and trace support

Le Mon, 24 Aug 2009 22:59:49 +0200,
Peter Korsgaard <[email protected]> a ?crit :

Quoted 4 lines

Thomas> Pulled and pushed into my for-2009.08 branch, that should be Thomas> pulled by Peter when he comes back from holidays.

Done.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com