Skip to contentSkip to conversation

ocfs2: __ocfs2_abort() should not enable panic for local mounts

PATCH New Sunil Mushran 2 participants 2 messages Aug 19, 2009 – Aug 26, 2009 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2: __ocfs2_abort() should not enable panic for local mounts

In a clustered setup, we have to panic the box on journal abort. This is because we don't have the facility to go hard readonly. With hard ro, another node would detect node failure and initiate recovery.

Having said that, we shouldn't force panic if the volume is mounted locally. This patch defers the handling to the mount option, errors.

---
 fs/ocfs2/super.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
fs/ocfs2/super.c +2 -1
index b0ee0fd..44a0388 100644
@@ -2486,7 +2486,8 @@ void __ocfs2_abort(struct super_block* sb,
 	/* Force a panic(). This stinks, but it's better than letting
 	 * things continue without having a proper hard readonly
 	 * here. */
-	OCFS2_SB(sb)->s_mount_opt |= OCFS2_MOUNT_ERRORS_PANIC;
+	if (!ocfs2_mount_local(OCFS2_SB(sb)))
+		OCFS2_SB(sb)->s_mount_opt |= OCFS2_MOUNT_ERRORS_PANIC;
 	ocfs2_handle_error(sb);
 }
 
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 ocfs2: __ocfs2_abort() should not enable panic for local mounts

Quoted 8 lines · Sunil Mushran

In a clustered setup, we have to panic the box on journal abort. This is because we don't have the facility to go hard readonly. With hard ro, another node would detect node failure and initiate recovery.

Having said that, we shouldn't force panic if the volume is mounted locally. This patch defers the handling to the mount option, errors.

This is now in the merge-window branch of ocfs2.git.

Joel

Signature · 9 lines
"Here's something to think about:  How come you never see a headline
 like ``Psychic Wins Lottery''?"
	- Jay Leno

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127