kill-the-BKL/vt: Prevent holding the BKL on return to userspace
From: Henrik Kretzschmar <[email protected]>
kill-the-BKL/vt: Prevent holding the BKL on return to userspace
Returning from a function which holds the BLK isn't a good idea, so we won't let it return from this point.
Instead we set the return variable and let the function return the normal way without BKL held.
Signed-off-by Henrik Kretzschmar <[email protected]>
---
This patch is only for the kill-the-BKL branch.
drivers/char/vt_ioctl.c +0 -0
@@ -396,7 +396,9 @@ int vt_ioctl(struct tty_struct *tty, struct file * file,
kbd = kbd_table + console;
switch (cmd) {
case TIOCLINUX:- return tioclinux(tty, arg);
+ ret = tioclinux(tty, arg);
+ break;
+
case KIOCSOUND: if (!perm) goto eperm;
Review
Quoted 5 lines · On Wed, 26 Aug 2009 17:31:34 +0200 Henne <[email protected]> wrote:
(quoted diff) +3
-1case TIOCLINUX: - return tioclinux(tty, arg); + ret = tioclinux(tty, arg); + break; +
A quick check says that Jiri Slaby fixed this in commit a115902f67ef51fbbe83e214fb761aaa9734c1ce back in June.
jon