xfs: use correct log reservation when handling ENOSPC in xfs_create
PATCH 1/1 xfs: use correct log reservation when handling ENOSPC in xfs_create
We added the ENOSPC handling patch in xfs_create just after it got mered with xfs_mkdir. Change the log reservation to the variable for either the create or mkdir value so it does the right thing if get here for creating a directory.
fs/xfs/xfs_vnodeops.c +2 -2
@@ -1479,8 +1479,8 @@ xfs_create(if (error ==ENOSPC ) {/* flush outstanding delalloc blocks and retry */ xfs_flush_inodes (dp); - error =xfs_trans_reserve (tp, resblks,XFS_CREATE_LOG_RES (mp),0 , -XFS_TRANS_PERM_LOG_RES ,XFS_CREATE_LOG_COUNT ); + error =xfs_trans_reserve (tp, resblks, log_res,0 , +XFS_TRANS_PERM_LOG_RES , log_count); }if (error ==ENOSPC ) {/* No space at all so try a "no-allocation" reservation */
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
ping?
Quoted 23 lines · Christoph Hellwig
We added the ENOSPC handling patch in
xfs_createjust after it got mered withxfs_mkdir. Change the log reservation to the variable for either the create or mkdir value so it does the right thing if get here for creating a directory.Signed-off-by Christoph Hellwig <[email protected]>Index:
xfs/fs/xfs/xfs_vnodeops.c
===================================================================fs/xfs/xfs_vnodeops.c +2
-2@@ -1479,8 +1479,8 @@ xfs_create(if (error ==ENOSPC ) {/* flush outstanding delalloc blocks and retry */ xfs_flush_inodes (dp); - error =xfs_trans_reserve (tp, resblks,XFS_CREATE_LOG_RES (mp),0 , -XFS_TRANS_PERM_LOG_RES ,XFS_CREATE_LOG_COUNT ); + error =xfs_trans_reserve (tp, resblks, log_res,0 , +XFS_TRANS_PERM_LOG_RES , log_count); }if (error ==ENOSPC ) {/* No space at all so try a "no-allocation" reservation */
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
RE: [PATCH] xfs: use correct log reservation when handling ENOSPC inxfs_create
In reply to Christoph HellwigQuoted 13 lines · Christoph Hellwig
We added the ENOSPC handling patch in
xfs_createjust after it got mered withxfs_mkdir. Change the log reservation to the variable for either the create or mkdir value so it does the right thing if get here for creating a directory.Signed-off-by Christoph Hellwig <[email protected]>Index:
xfs/fs/xfs/xfs_vnodeops.c
===================================================================
fs/xfs/xfs_vnodeops.c xfs_create( · line 1486
Quoted 10 lines
fs/xfs/xfs_vnodeops.c +2
-2@@ -1479,8 +1479,8 @@ xfs_create(if (error ==ENOSPC ) {/* flush outstanding delalloc blocks and retry */ xfs_flush_inodes (dp); - error =xfs_trans_reserve (tp, resblks,XFS_CREATE_LOG_RES (mp),0 , -XFS_TRANS_PERM_LOG_RES ,XFS_CREATE_LOG_COUNT ); + error =xfs_trans_reserve (tp, resblks, log_res,0 , +XFS_TRANS_PERM_LOG_RES , log_count); }if (error ==ENOSPC ) {/* No space at all so try a "no-allocation" reservation */
Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs