MTX build failure

DISCUSSION Ralf Baechle 3 participants 8 messages Aug 28, 2009 MIPS

Share & tools

Ralf Baechle

author

2009-08-28 07:46 UTC #0 lore raw

CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

Ralf

Florian Fainelli

2009-08-28 08:26 UTC #1 lore raw

Le Friday 28 August 2009 09:47:09 Ralf Baechle, vous avez écrit :

Quoted 4 lines

CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123:

Quoted 8 lines

error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135:
error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

Will see what happens, thanks for notifying.

Signature · 5 lines

Best regards, Florian Fainelli
Email: [email protected]
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

Manuel Lauss

2009-08-28 08:53 UTC #2 lore raw

In reply to Ralf Baechle

Quoted 9 lines · Ralf Baechle

CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.

arch/mips/alchemy/Kconfig +1 -0

index 1e0a6df..f0c930a 100644
@@ -20,6 +20,7 @@ config MIPS_MTX1
 	select HW_HAS_PCI
 	select SOC_AU1500
 	select SYS_SUPPORTS_LITTLE_ENDIAN
+	select GPIOLIB
 
 config MIPS_BOSPORUS
 	bool "Alchemy Bosporus board"

Manuel Lauss

Florian Fainelli

Tested-by

2009-08-28 09:08 UTC #3 lore raw

Le Friday 28 August 2009 10:53:34 Manuel Lauss, vous avez écrit :

Quoted 14 lines

Quoted 4 lines · Ralf Baechle
CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123:
Quoted 8 lines
error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135:
error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

Quoted 3 lines

Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.

The patch below fixes it for me, so feel free to add my:

Tested-by Florian Fainelli <[email protected]>

Quoted 16 lines

arch/mips/alchemy/Kconfig +1 -0

index 1e0a6df..f0c930a 100644
@@ -20,6 +20,7 @@ config MIPS_MTX1
 	select HW_HAS_PCI
 	select SOC_AU1500
 	select SYS_SUPPORTS_LITTLE_ENDIAN
+	select GPIOLIB
 
 config MIPS_BOSPORUS
 	bool "Alchemy Bosporus board"

Manuel Lauss

Signature · 5 lines

Best regards, Florian Fainelli
Email: [email protected]
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

Manuel Lauss

2009-08-28 09:27 UTC #4 lore raw

In reply to Manuel Lauss

Quoted 11 lines · I wrote:

Quoted 9 lines · Ralf Baechle
CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2

Quoted 3 lines

Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.

Florian, Ralf, I prefer the latter approach; saves everyone from having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.

Here's an untested patch. What do you think? If it works for you, please add it to your patchqueue!

Thanks!

---

From: Manuel Lauss <[email protected]>
Subject: [PATCH] Alchemy: add gpio_request/gpio_free stubs for CONFIG_GPIOLIB=n

Some drivers use gpio_request/gpio_free regardless of whether gpiolib is actually built; add stubs to work around the ensuing compile failures.

Signed-off-by Manuel Lauss <[email protected]>

---
 arch/mips/include/asm/mach-au1x00/gpio-au1000.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

arch/mips/include/asm/mach-au1x00/gpio-au1000.h +9 -0

index 127d4ed..feea001 100644
@@ -578,6 +578,15 @@ static inline int irq_to_gpio(int irq)
 	return alchemy_irq_to_gpio(irq);
 }
 
+static inline int gpio_request(unsigned gpio, const char *label)
+{
+	return 0;
+}
+
+static inline void gpio_free(unsigned gpio)
+{
+}
+
 #endif	/* !CONFIG_ALCHEMY_GPIO_INDIRECT */

--
1.6.4.1

Florian Fainelli

Tested-by

2009-08-28 09:58 UTC #5 lore raw

Le Friday 28 August 2009 11:26:58 Manuel Lauss, vous avez écrit :

Quoted 29 lines

Quoted 14 lines · I wrote:
Quoted 4 lines · Ralf Baechle
CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123:
Quoted 8 lines
error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135:
error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2
Quoted 3 lines
Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.
Florian, Ralf, I prefer the latter approach; saves everyone from having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.
Here's an untested patch. What do you think? If it works for you, please add it to your patchqueue!
Thanks!
---

Quoted 7 lines

From: Manuel Lauss <[email protected]>
Subject: [PATCH] Alchemy: add gpio_request/gpio_free stubs for CONFIG_GPIOLIB=n
Some drivers use gpio_request/gpio_free regardless of whether gpiolib is actually built; add stubs to work around the ensuing compile failures.

This is better, though fixing the gpio keyboard driver might probably be a good approach.

Quoted 2 lines

Signed-off-by Manuel Lauss <[email protected]>

Tested-by Florian Fainelli <[email protected]>

Quoted 27 lines

---
 arch/mips/include/asm/mach-au1x00/gpio-au1000.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

(quoted diff) +0 -0

b/arch/mips/include/asm/mach-au1x00/gpio-au1000.h index 127d4ed..feea001 100644

arch/mips/include/asm/mach-au1x00/gpio-au1000.h +9 -1

@@ -578,6 +578,15 @@ static inline int irq_to_gpio(int irq)
 	return alchemy_irq_to_gpio(irq);
 }
 
+static inline int gpio_request(unsigned gpio, const char *label)
+{
+	return 0;
+}
+
+static inline void gpio_free(unsigned gpio)
+{
+}
+
 #endif	/* !CONFIG_ALCHEMY_GPIO_INDIRECT */
 
 
--

1.6.4.1

Signature · 5 lines

Best regards, Florian Fainelli
Email: [email protected]
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

Manuel Lauss

2009-08-28 10:10 UTC #6 lore raw

Quoted 34 lines · Florian Fainelli

Le Friday 28 August 2009 11:26:58 Manuel Lauss, vous avez écrit :
Quoted 33 lines
Quoted 14 lines · I wrote:
Quoted 4 lines · Ralf Baechle
CC drivers/input/keyboard/gpio_keys.o /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123:
Quoted 8 lines
error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135:
error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2
Quoted 3 lines
Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.
Florian, Ralf, I prefer the latter approach; saves everyone from having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.
Here's an untested patch. What do you think? If it works for you, please add it to your patchqueue!
Thanks!
---
From: Manuel Lauss <[email protected]>
Subject: [PATCH] Alchemy: add gpio_request/gpio_free stubs for CONFIG_GPIOLIB=n

Quoted 5 lines

Quoted 3 lines
Some drivers use gpio_request/gpio_free regardless of whether gpiolib is actually built; add stubs to work around the ensuing compile failures.
This is better, though fixing the gpio keyboard driver might probably be a good approach.

As I wrote above, I don't think adding "#ifdef CONFIG_GPIOLIB" to all in-kernel users
of gpio_request() is an acceptable solution; one would be to unconditionally enable GPIOLIB
on Alchemy (but I like speedy gpio calls to bitbang busses...), another this patch.

Thanks for testing!
Manuel Lauss

Ralf Baechle

author

2009-08-28 13:13 UTC #7 lore raw

In reply to Manuel Lauss

Quoted 16 lines · Manuel Lauss

Quoted 11 lines · I wrote:
Quoted 9 lines · Ralf Baechle
CC drivers/input/keyboard/gpio_keys.o
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c: In function ‘gpio_keys_probe’:
/home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:123: error: implicit declaration of function ‘gpio_request’ /home/ralf/src/linux/linux-mips/drivers/input/keyboard/gpio_keys.c:135: error: implicit declaration of function ‘gpio_free’ make[5]: *** [drivers/input/keyboard/gpio_keys.o] Error 1
make[4]: *** [drivers/input/keyboard] Error 2
make[3]: *** [drivers/input] Error 2
make[2]: *** [drivers] Error 2
make[1]: *** [sub-make] Error 2
Quoted 3 lines
Either something like the patch below, or adding stubs for gpio_request/gpio_free to asm/mach-au1x00/gpio-au1000.h in the CONFIG_GPIOLIB=n case should fix it.

Quoted 5 lines

Florian, Ralf, I prefer the latter approach; saves everyone from having to add #ifdef CONFIG_GPIOLIB around gpio_request() calls.
Here's an untested patch. What do you think? If it works for you, please add it to your patchqueue!

Thanks, this 2nd one looks good. Applied.

Ralf