Skip to contentSkip to conversation

Add common code dir for Matrix Vision boards.

PATCH New Andre Schwarz 2 participants 3 messages Aug 31, 2009 – Sep 1, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add common code dir for Matrix Vision boards.

This fixes current build failure.

---
 board/matrix_vision/common/Makefile    |   54 ++++++++++++++
 board/matrix_vision/common/mv_common.c |  126 ++++++++++++++++++++++++++++++++
 board/matrix_vision/common/mv_common.h |   25 ++++++
 3 files changed, 205 insertions(+), 0 deletions(-)
 create mode 100644 board/matrix_vision/common/Makefile
 create mode 100644 board/matrix_vision/common/mv_common.c
 create mode 100644 board/matrix_vision/common/mv_common.h
board/matrix_vision/common/Makefile new file +54 -0
new file mode 100644
index 0000000..b496258
@@ -0,0 +1,54 @@
+#
+# (C) Copyright 2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)board/$(VENDOR)/common)
+endif
+
+LIB	= $(obj)lib$(VENDOR).a
+
+COBJS-y	= mv_common.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS-y))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(AR) $(ARFLAGS) $@ $(OBJS)
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/matrix_vision/common/mv_common.c new file +126 -0

126 lines not on this page · raw message

board/matrix_vision/common/mv_common.h new file +25 -0
new file mode 100644
index 0000000..046c038
@@ -0,0 +1,25 @@
+/*
+ * Copyright 2008 Matrix Vision GmbH
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+
+extern int mv_load_fpga(void);
+extern void mv_reset_environment(void);
Signature · 6 lines
1.6.0.4


MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
#1 lore raw

PATCH 1/1 Add common code dir for Matrix Vision boards.

Dear Andre Schwarz,

Quoted 3 lines · In message <[email protected]>…

This fixes current build failure.

Hm... You did not test your patch, did you?

-> git-am -3 -i -u --whitespace=strip ~/Mail/U-Boot/8023 Commit Body is:
--------------------------
Add common code dir for Matrix Vision boards.

This fixes current build failure.

--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Add common code dir for Matrix Vision boards. /home/wd/git/u-boot/work/.git/rebase-apply/patch:168: trailing whitespace.

warning: 1 line applied after fixing whitespace errors.
...
Configuring for MVBLM7 board...
mvblm7.c: In function 'misc_init_r':
mvblm7.c:108: warning: implicit declaration of function 'mv_reset_environment'

I'm a bit disappointed that this warning is still present. I think I pointed it out before...

OK, I fixed it for you.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's all Klatchian to me.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_
#2 lore raw

PATCH 1/1 Add common code dir for Matrix Vision boards.

Wolfgang,

Quoted 8 lines · Wolfgang Denk

Dear Andre Schwarz,

Quoted 3 lines · In message <[email protected]>…

This fixes current build failure.

Hm... You did not test your patch, did you?

of course. Both boards compiled cleanly (I thought).

Quoted 2 lines

-> git-am -3 -i -u --whitespace=strip ~/Mail/U-Boot/8023

Sorry - I'm not familiar with this.

Quoted 11 lines

Commit Body is:
--------------------------
Add common code dir for Matrix Vision boards.

This fixes current build failure.

--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Add common code dir for Matrix Vision boards. /home/wd/git/u-boot/work/.git/rebase-apply/patch:168: trailing whitespace.

huh - need to do better checking.

Quoted 6 lines

warning: 1 line applied after fixing whitespace errors.
...
Configuring for MVBLM7 board...
mvblm7.c: In function 'misc_init_r':
mvblm7.c:108: warning: implicit declaration of function 'mv_reset_environment'

ok - I can see it also on my build. Missed it yesterday.

Quoted 4 lines

I'm a bit disappointed that this warning is still present. I think I pointed it out before...

yes ... and I'm very uncomfortable with this. Don't know how this could have slipped through. I greatly appreciate your help and will try to improve.

Quoted 2 lines

OK, I fixed it for you.

Thank you.

Quoted 5 lines

Best regards,

Wolfgang Denk

Regards,
Andr?

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich