Skip to contentSkip to conversation

libarchive package added

PATCH New Daniel Mack 2 participants 8 messages Aug 25, 2009 – Sep 2, 2009

lore
Share & tools
lore

Daniel Mack

author
#0 lore raw

PATCH 1/1 libarchive package added

See http://code.google.com/p/libarchive/

Signed-off-by Daniel Mack <[email protected]>
---
 package/Config.in                |    1 +
 package/libarchive/Config.in     |   15 +++++++++++++++
 package/libarchive/libarchive.mk |   19 +++++++++++++++++++
 3 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 package/libarchive/Config.in
 create mode 100644 package/libarchive/libarchive.mk
package/Config.in +1 -0
index 02ffb2d..a53e09a 100644
@@ -386,6 +386,7 @@ menu "Compressors / decompressors"
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/gzip/Config.in"
 endif
+source "package/libarchive/Config.in"
 source "package/lzo/Config.in"
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
package/libarchive/Config.in new file +15 -0
new file mode 100644
index 0000000..93bfec2
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_LIBARCHIVE
+	bool "libarchive"
+	help
+	  Libarchive is a reusable C library for reading and writing a
+	  variety of streaming archive formats.
+
+	  http://code.google.com/p/libarchive/
+
+config BR2_LIBARCHIVE_INSTALL_TO_TARGET
+	bool "install libarchive to target"
+	depends on BR2_PACKAGE_LIBARCHIVE
+	default y
+	help
+	  Say Y here to make BR2 copy the libarchive files to the target
+	  destination folder.
package/libarchive/libarchive.mk new file +19 -0
new file mode 100644
index 0000000..e3f019b
@@ -0,0 +1,19 @@
+#############################################################
+#
+# libarchive (reusable C library for archive formats)
+#
+#############################################################
+LIBARCHIVE_VERSION:=2.7.1
+LIBARCHIVE_SITE = http://libarchive.googlecode.com/files/
+LIBARCHIVE_SOURCE = libarchive-$(LIBARCHIVE_VERSION).tar.gz
+LIBARCHIVE_LIBTOOL_PATCH = NO
+LIBARCHIVE_INSTALL_STAGING = YES
+
+ifeq ($(BR2_LIBARCHIVE_INSTALL_TO_TARGET),y)
+	LIBARCHIVE_INSTALL_TARGET := YES
+endif
+
+LIBARCHIVE_DEPENDENCIES = uclibc
+
+$(eval $(call AUTOTARGETS,package,libarchive))
+
Signature · 1 line
1.6.3.3
author
#1 lore raw

PATCH 1/1 libarchive package added

ping

Quoted 72 lines · Daniel Mack

See http://code.google.com/p/libarchive/

Signed-off-by Daniel Mack <[email protected]>
---
 package/Config.in                |    1 +
 package/libarchive/Config.in     |   15 +++++++++++++++
 package/libarchive/libarchive.mk |   19 +++++++++++++++++++
 3 files changed, 35 insertions(+), 0 deletions(-)
 create mode 100644 package/libarchive/Config.in
 create mode 100644 package/libarchive/libarchive.mk
package/Config.in +1 -0
index 02ffb2d..a53e09a 100644
@@ -386,6 +386,7 @@ menu "Compressors / decompressors"
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/gzip/Config.in"
 endif
+source "package/libarchive/Config.in"
 source "package/lzo/Config.in"
 source "package/lzop/Config.in"
 source "package/lzma/Config.in"
package/libarchive/Config.in new file +15 -0
new file mode 100644
index 0000000..93bfec2
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_LIBARCHIVE
+	bool "libarchive"
+	help
+	  Libarchive is a reusable C library for reading and writing a
+	  variety of streaming archive formats.
+
+	  http://code.google.com/p/libarchive/
+
+config BR2_LIBARCHIVE_INSTALL_TO_TARGET
+	bool "install libarchive to target"
+	depends on BR2_PACKAGE_LIBARCHIVE
+	default y
+	help
+	  Say Y here to make BR2 copy the libarchive files to the target
+	  destination folder.
package/libarchive/libarchive.mk new file +19 -0
new file mode 100644
index 0000000..e3f019b
@@ -0,0 +1,19 @@
+#############################################################
+#
+# libarchive (reusable C library for archive formats)
+#
+#############################################################
+LIBARCHIVE_VERSION:=2.7.1
+LIBARCHIVE_SITE = http://libarchive.googlecode.com/files/
+LIBARCHIVE_SOURCE = libarchive-$(LIBARCHIVE_VERSION).tar.gz
+LIBARCHIVE_LIBTOOL_PATCH = NO
+LIBARCHIVE_INSTALL_STAGING = YES
+
+ifeq ($(BR2_LIBARCHIVE_INSTALL_TO_TARGET),y)
+	LIBARCHIVE_INSTALL_TARGET := YES
+endif
+
+LIBARCHIVE_DEPENDENCIES = uclibc
+
+$(eval $(call AUTOTARGETS,package,libarchive))
+
Signature · 1 line
1.6.3.3
#2 lore raw

PATCH 1/1 libarchive package added

In reply to Daniel Mack
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Mack <[email protected]> writes:

Hi,

Daniel> +++ b/package/libarchive/Config.in
Daniel> @@ -0,0 +1,15 @@
Daniel> +config BR2_PACKAGE_LIBARCHIVE
Daniel> + bool "libarchive"
Daniel> + help
Daniel> + Libarchive is a reusable C library for reading and writing a
Daniel> + variety of streaming archive formats.
Daniel> +
Daniel> + http://code.google.com/p/libarchive/
Daniel> +
Daniel> +config BR2_LIBARCHIVE_INSTALL_TO_TARGET
Daniel> + bool "install libarchive to target"
Daniel> + depends on BR2_PACKAGE_LIBARCHIVE
Daniel> + default y
Daniel> + help
Daniel> + Say Y here to make BR2 copy the libarchive files to the target
Daniel> + destination folder.

When would you not want to do this?

Signature · 1 line
Bye, Peter Korsgaard
author
#3 lore raw

PATCH 1/1 libarchive package added

Quoted 20 lines · Peter Korsgaard

Date: Tue, 01 Sep 2009 16:52:49 +0200
From: Peter Korsgaard <[email protected]>
To: Daniel Mack <[email protected]>
Cc: buildroot at uclibc.org
Subject: Re: [Buildroot] [PATCH] libarchive package added
Message-ID: <[email protected]>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Mack <[email protected]> writes:

Hi,

Daniel> +config BR2_LIBARCHIVE_INSTALL_TO_TARGET
Daniel> + bool "install libarchive to target"
Daniel> + depends on BR2_PACKAGE_LIBARCHIVE
Daniel> + default y
Daniel> + help
Daniel> + Say Y here to make BR2 copy the libarchive files to the target
Daniel> + destination folder.

Quoted 1 line

When would you not want to do this?

We need that library for a binary which is linked statically. Installing it is not necessary in our case.

But as the default is 'y', this should not be a disadvantage for anyone. We could, of course, also delete it manually at a later point.

Daniel

#4 lore raw

PATCH 1/1 libarchive package added

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Mack <[email protected]> writes:

Hi,

Quoted 1 line
Quoted 1 line

When would you not want to do this?

Daniel> We need that library for a binary which is linked Daniel> statically. Installing it is not necessary in our case.

Daniel> But as the default is 'y', this should not be a disadvantage Daniel> for anyone. We could, of course, also delete it manually at a Daniel> later point.

Ok, we don't normally do this per-package - So I'm hessitant to add it here. Other than that, it looks fine.

Signature · 1 line
Bye, Peter Korsgaard
author
#5 lore raw

PATCH 1/1 libarchive package added

Quoted 9 lines · Peter Korsgaard

Daniel> We need that library for a binary which is linked Daniel> statically. Installing it is not necessary in our case.

Daniel> But as the default is 'y', this should not be a disadvantage Daniel> for anyone. We could, of course, also delete it manually at a Daniel> later point.

Ok, we don't normally do this per-package - So I'm hessitant to add it here. Other than that, it looks fine.

Hmm, maybe that should be an option to more packages then, and it could be added on demand, eg. whenever someone needs that.

But I understand that you're hessitant, so drop that part if you like, and we remove the installed files later from our postbuild script. No problem :)

Daniel

#6 lore raw

PATCH 1/1 libarchive package added

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Daniel" == Daniel Mack <[email protected]> writes:

Hi,

Quoted 2 lines
Quoted 2 lines

Ok, we don't normally do this per-package - So I'm hessitant to add it here. Other than that, it looks fine.

Daniel> Hmm, maybe that should be an option to more packages then, and Daniel> it could be added on demand, eg. whenever someone needs that.

I think adding so many configuration options for something like that will just confuse people / complicate testing too much. Using BR2_ROOTFS_POST_BUILD_SCRIPT for this seems like a nicer (and more flexible) solution to me.

Daniel> But I understand that you're hessitant, so drop that part if you like, Daniel> and we remove the installed files later from our postbuild script. No Daniel> problem :)

Ok, added without that part. Notice that libarchive needs wchar support:

libarchive/archive_entry.c: In function 'aes_get_wcs':
libarchive/archive_entry.c:234: error: implicit declaration of function 'mbstowcs'

I've fixed the kconfig to ensure that.

Signature · 1 line
Bye, Peter Korsgaard
author
#7 lore raw

PATCH 1/1 libarchive package added

Quoted 10 lines · Peter Korsgaard

Daniel> But I understand that you're hessitant, so drop that part if you like, Daniel> and we remove the installed files later from our postbuild script. No Daniel> problem :)

Ok, added without that part. Notice that libarchive needs wchar support:

libarchive/archive_entry.c: In function 'aes_get_wcs':
libarchive/archive_entry.c:234: error: implicit declaration of function 'mbstowcs'

I've fixed the kconfig to ensure that.

Thanks :)